reducing NUMERIC size for 9.1, take two

Started by Robert Haasover 15 years ago4 messageshackers
Jump to latest
#1Robert Haas
robertmhaas@gmail.com

Here's a second version of the main patch, in which I have attempted
to respond to Tom's concerns/suggestions.

(There is still a small, side issue with numeric_maximum_size() which
I plan to fix, but this patch is the good stuff.)

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

Attachments:

numeric_2b-v2.patchapplication/octet-stream; name=numeric_2b-v2.patchDownload+191-65
#2Brendan Jurd
direvus@gmail.com
In reply to: Robert Haas (#1)
Re: reducing NUMERIC size for 9.1, take two

On 31 July 2010 07:58, Robert Haas <robertmhaas@gmail.com> wrote:

Here's a second version of the main patch, in which I have attempted
to respond to Tom's concerns/suggestions.

(There is still a small, side issue with numeric_maximum_size() which
I plan to fix, but this patch is the good stuff.)

Applies fine, compiles fine, passes regression tests, and demonstrates
the same space reduction seen with the previous version of the patch.

Marking Ready for Committer.

Cheers,
BJ

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Robert Haas (#1)
Re: reducing NUMERIC size for 9.1, take two

Robert Haas <robertmhaas@gmail.com> writes:

Here's a second version of the main patch, in which I have attempted
to respond to Tom's concerns/suggestions.

This version looks fine to me.

regards, tom lane

#4Robert Haas
robertmhaas@gmail.com
In reply to: Tom Lane (#3)
Re: reducing NUMERIC size for 9.1, take two

On Tue, Aug 3, 2010 at 6:03 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Robert Haas <robertmhaas@gmail.com> writes:

Here's a second version of the main patch, in which I have attempted
to respond to Tom's concerns/suggestions.

This version looks fine to me.

Excellent. Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company