model-writtenrun 660 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Noah Misch proposed correcting pg_dump's property-graph default ACL calculation to eliminate redundant owner REVOKE and GRANT statements, adding acldefault('g') while preserving dumps from PostgreSQL 19beta1 through a hard-coded fallback #1.
- Tom Lane explained that the catalog-version bump made beta1 dump support necessary for upgrading to beta2, although dropping that support afterward could be reasonable; he explicitly had not read the patch #2.
- Ashutosh Bapat reviewed Noah's patch and proposed a helper function and tests, then supplied a separate patch for missing property-graph ACL cases and warning-based filtering of unsupported privileges supplied through GRANT TABLE #3.
- Ashutosh bundled Noah's unchanged pg_dump patch with a revision of his own GRANT patch, arguing that the shared namespace justified accepting GRANT TABLE with property-graph privilege restrictions #4.
- Noah declined the helper refactoring, considered broader testing a future improvement, and retained beta1 compatibility because removing roughly 25 lines did not justify a follow-up; Ashutosh accepted retaining clearly identifiable compatibility code #5 #7.
- Noah favored rejecting GRANT TABLE for property graphs, and Tom explained that allowing it for sequences was a historical compatibility concession that should not extend to new relation types; Ashutosh agreed to change his patch accordingly #5 #6 #8.
- Robert Haas identified differing non-ASCII identifier quoting between quoteAclUserName() and putid() but found no functional failure in the pg_dump patch; Noah agreed the functions should be aligned, though neither candidate commit includes that separate cleanup #9 #10.
- Noah committed the pg_dump component forwarded in #4 as 592de8bd21, preserving the original implementation and beta1 fallback while adding the catalog-version bump.
- Ashutosh posted the remaining GRANT fix separately, replacing permissive handling with an error and a PROPERTY GRAPH syntax hint, retaining the missing ACL cases, and updating regression tests; he invited feedback on the error wording #11.
- Peter Eisentraut committed #11 as 4054ec5b4f with only test-comment corrections beyond rebasing and announced completion, leaving both submitted fixes landed and no further patch revision pending in the thread #12.