model-writtenrun 694 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Tristan Partin reported macro-redefinition warnings caused by standard headers already defining unreachable() when PostgreSQL's timezone header defines it again #1.
- Tristan Partin attached a proposed fix modeled on the nearby static_assert guard, conditionally defining unreachable() according to the C version and whether the macro already exists #1.
- Masahiko Sawada confirmed encountering the same warnings on Fedora, but did not report testing the proposed fix #2.
- Tom Lane explained that using PostgreSQL's pg_unreachable() implementation was intentional and proposed explicitly undefining the platform macro before redefining it #3.
- The thread ended with Tom Lane's proposed alternative, which he subsequently committed with an explanatory comment; the attached conditional-guard approach was not used #3 85656c1bef.