Jul 2026

4 commits
ssl: Use the correct feature macros for TLS protocol support
29 Jul 2026Daniel Gustafssonmasterunreleased
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #111 of 3 reviewers saw the final version

The feature-macro patch in #11 matches the commit except that src/backend/libpq/be-secure-openssl.c changes the TLS 1.3 guard from #ifdef OPENSSL_NO_TLS1_3 to #ifndef OPENSSL_NO_TLS1_3. This reverses the erroneous condition exactly as Yilin Zhang requested in #14 and Daniel confirmed in #15.

  • Tristan Partinsaw an earlier versiontrailerTristan said the patches looked good in #2, before the backend TLS 1.3 condition was corrected following #14.
  • Andreas Karlssonsaw an earlier versiontrailerAndreas approved the feature-macro change in #3 and the final submitted series in #12, before the TLS 1.3 logic correction.
  • Yilin Zhangsaw the final versiontrailerYilin identified the inverted backend TLS 1.3 guard and proposed the exact correction incorporated into the commit in #14.
ssl: Replace deprecated API to get commonName
29 Jul 2026Daniel Gustafssonmasterunreleased
LLM analysis, 100% surelanded as postedfrom patchset #112 of 3 reviewers saw the final version

The commonName extraction diff in src/backend/libpq/be-secure-openssl.c exactly matches the corresponding patch in #11, excluding base blob IDs, including the indexed lookup, ASN1 data access, memcpy, and explicit terminator.

  • Tristan Partinsaw the final versiontrailerTristan endorsed the series in #2, after which this patch received only scope, equivalent allocation-and-termination, and comment cleanups.
  • Andreas Karlssonsaw the final versiontrailerAndreas requested narrower variable scope and explicit termination in #3, questioned the ownership comment in #6, and endorsed the revised series in #12.
  • Yilin Zhangno review foundtrailerYilin's review in #14 addresses only the protocol-feature patch, with no visible review of commonName extraction.
ssl: Use TLS_method instead of deprecated SSLv23_method
29 Jul 2026Daniel Gustafssonmasterunreleased
LLM analysis, 100% surelanded as postedfrom patchset #112 of 3 reviewers saw the final version

All three SSLv23_method() replacements and the obsolete comment removal in src/backend/libpq/be-secure-openssl.c and src/interfaces/libpq/fe-secure-openssl.c exactly match the corresponding patch in #11, excluding base blob IDs.

  • Tristan Partinsaw the final versiontrailerTristan said the patches looked good in #2, and the TLS_method() change remained unchanged through #11.
  • Andreas Karlssonsaw the final versiontrailerAndreas approved this change in #3 and endorsed all final submitted patches in #12.
  • Yilin Zhangno review foundtrailerYilin's review in #14 addresses only protocol-feature detection, with no visible review of the TLS_method() replacement.
ssl: Remove static var tracking tls_init_hook warnings
29 Jul 2026Daniel Gustafssonmasterunreleased
LLM analysis, 100% surelanded as postedfrom patchset #112 of 3 reviewers saw the final version

The warning-state patch in src/backend/libpq/be-secure-openssl.c exactly matches #11, excluding base blob IDs, including the caller-owned hasWarned flag, pg_attribute_nonnull(3), and function comment.

  • Tristan Partinsaw the final versiontrailerTristan proposed nonnull protection in #2 and suggested documenting its rationale in #10, followed only by annotation, assertion, and comment refinements.
  • Andreas Karlssonsaw the final versiontrailerAndreas reviewed the initial patch in #3, reported the assertion/nonnull compiler warning in #6, and endorsed the corrected series in #12.
  • Yilin Zhangno review foundtrailerYilin's review in #14 concerns only the protocol-feature patch, with no visible review of warning-state handling.

Credits across 4 commits

Author
Daniel Gustafsson4
Reviewer
Andreas Karlsson4
Tristan Partin4
Yilin Zhang4
Committer
Daniel Gustafsson4