model-writtenrun 191 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Daniel Westermann reported xmlKeepBlanksDefault deprecation warnings on Rocky 10.2 in #1 and identified libxml2 2.12.5 in #3; Tom Lane explained that the existing content parser lacked an options argument and warned about compatibility risks in #4.
- Andrew Dunstan proposed xmlParseInNodeContext in #5, and Tom Lane adopted that approach in #7, posting a draft that passed check-world but still needed scrutiny of its dummy-root handling.
- After inspecting libxml2's ownership behavior, Tom Lane revised the patch in #8 so xml_parse attached content beneath the dummy root, simplifying callers and ensuring document cleanup also freed the content nodes.
- The work resumed in October with #9, which renamed a local variable to address newly enabled shadowing warnings without changing behavior.
- Rui Zhao tested the rewrite against three libxml2 versions and supplied two incremental fixes in #10: one preserved leading U+FEFF content by delaying the encoding assignment, and another preserved mixed-content whitespace; he also rejected a SAX-based alternative after finding unsafe error-path ownership in older libraries.
- Tom Lane proposed dropping the encoding assignment entirely and rejecting the whitespace workaround in #11, judging the latter too dependent on libxml2 internals and favoring a development-branch-only change because minor behavioral differences remained.
- Rui Zhao demonstrated that removing the encoding assignment changed non-ASCII attribute serialization and agreed to abandon the whitespace workaround in #12; Tom Lane consequently accepted the original encoding fix and planned additional tests in #13.
- Tom Lane committed 30d4a6daac, combining #9 with the encoding portion of #10, cleanup and expanded regression coverage, then confirmed the push in #14; the whitespace workaround was dropped, and backpatching was deferred pending field experience.