Aug 2026

2 commits
Fix unlink() error report in KeepFileRestoredFromArchive()
12 Aug 2026Michael Paquiermasterunreleased
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Fujii Masao identified the incorrect filename in the unlink(oldpath) error report in #9; neither attached patch fixes it. The commit changes xlogfpath to oldpath in src/backend/access/transam/xlogarchive.c, and Michael Paquier confirms applying it in #11.

  • Fujii Masaosaw the final versionLLM analysis, 99% sureFujii identified the incorrect unlink error-report argument and proposed the correction adopted by this commit in #9.
Remove redundant unlink() in KeepFileRestoredFromArchive() for non-WIN32
5 Aug 2026Michael Paquiermasterunreleased
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #33 of 3 reviewers saw the final version

The commit takes the non-Windows unlink removal from #3 in src/backend/access/transam/xlogarchive.c, omitting the injection point, TAP test, and meson registration. It adds a comment documenting the remaining Windows race, as confirmed in #8.

  • Andrey Borodinsaw the final versiontrailerAndrey endorsed the fix and identified test problems in #2, then agreed to omit the revised test in #6; the committed core logic remained unchanged.
  • Neil Chensaw the final versiontrailerNeil tested and instrumented the revised patch in #4, showing that its standby walsender never opened the raced segment; only test removal and comment changes followed.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Stepan Neretin1
Reviewer
Andrey Borodin1
Michael Paquiercommitter1
Neil Chen1
Reported by
Fujii Masao1
Committer
Michael Paquier2