Sep 2026

1 commit
Fix REPACK worker startup and shutdown sequences
17 Sep 2026Álvaro HerreramasterunreleasedREL_19_STABLE19beta4Also in: REPACK decoding worker startup/teardown differs from parallel.c (not this thread)
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #160 of 3 reviewers saw the final version

Applying the first two patches from #16 to the commit parent confirms that the commit combines their startup, teardown, and premature-exit fixes, omitting the tests and pending-flag cleanup. Committer changes rework the attachment loop and termination guard in src/backend/commands/repack.c, localize shutdown state in repack_worker.c, and introduce PqRepackMsg_Terminate in src/include/libpq/protocol.h.

  • Antonin Houskasaw an earlier versiontrailerAntonin reviewed startup handling and comments, challenged the silent-exit reproducer in #12, and confirmed the detached-queue diagnosis and proposed fix in #15, before subsequent teardown and committer logic changes.
  • Masahiko Sawadasaw an earlier versiontrailerMasahiko's review in #6 requested distinguishing workers that stopped before queue attachment from those that could have queued an error, prompting the redesigned startup wait and preceding the later termination protocol.
  • Shihao Zhongsaw an earlier versiontrailerShihao tested fork failure, cancellation races, noisy concurrent workloads, and test effectiveness in #16, supplying the corrected series before the committer further changed attachment-wait and termination logic.

Credits across 1 commit

Author
Alvaro Herrera1
Bharath Rupireddy1
shihao zhong1
Reviewer
Antonin Houska1
Masahiko Sawada1
shihao zhong1
Reported by
Bharath Rupireddy1
Nathan Bossart1
Nikolay Samokhvalov1
Committer
Alvaro Herrera1