Sep 2026

3 commits
pg_ctl: Silence warnings about unused global variables
11 Sep 2026Peter EisentrautREL_19_STABLE19beta4REL_18_STABLE18.7REL_17_STABLE17.12REL_16_STABLE16.16REL_15_STABLE15.20REL_14_STABLE14.25
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #52 of 2 reviewers saw the final version

fbaeb88978 takes only the fifth patch from #5, unchanged apart from base context, adding pg_attribute_unused() to five globals in src/bin/pg_ctl/pg_ctl.c. Its commit message explicitly reserves this behavior-preserving approach for backbranches.

  • Andreas Karlssonsaw the final versiontrailerAndreas warned in #3 that unused attributes would also hide future Windows warnings, reviewing the same implementation ultimately used for backbranches.
  • Tom Lanesaw the final versiontrailerTom considered attribute suppression suitable for backbranches in #4 and approved the revised series in #6.
pg_ctl: Error out on Windows-only options on other platforms
11 Sep 2026Peter Eisentrautmasterunreleased
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #51 of 2 reviewers saw the final version

6a1c1102c4 contains the net pg_ctl changes of the fifth and sixth patches in #5, omitting the intermediate unused attributes. The resulting src/bin/pg_ctl/pg_ctl.c matches the submitted Windows guards and rejection of -e, -N, -P and -U on other platforms.

  • Andreas Karlssonsaw an earlier versiontrailerAndreas challenged unconditional warning suppression in #3, before #5 added platform guards and changed command-line behavior.
  • Tom Lanesaw the final versiontrailerTom requested a better master solution in #4 and explicitly approved the added unsupported-option handling in #6.
Remove unused global variables
11 Sep 2026Peter EisentrautmasterunreleasedREL_19_STABLE19beta4REL_18_STABLE18.7REL_17_STABLE17.12REL_16_STABLE16.16REL_15_STABLE15.20REL_14_STABLE14.25
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #52 of 2 reviewers saw the final version

4e108ce790 combines the first four patches from #5, removing unused globals in xlog.c, postmaster.c, pg_dump_sort.c and test_resowner_many.c. The only additional edit shortens the release-priority comment in test_resowner_many.c; pg_ctl changes land separately.

  • Andreas Karlssonsaw the final versiontrailerAndreas said the four removal patches looked good in #3, and their committed code differs only by a comment edit.
  • Tom Lanesaw the final versiontrailerTom discussed the original series and backpatching in #4, then approved the revised series in #6.

Credits across 3 commits

Author
Peter EisentrautLLM3
Reviewer
Andreas Karlsson3
Tom Lane3
Committer
Peter Eisentraut3

N LLM means N of the credits come from LLM analysis, not from commit trailers.