model-writtenrun 347 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut opened the thread with five patches addressing clang 23's set-but-unused global warnings: four removed dead variables, while the pg_ctl patch marked Windows-only globals unused and raised the possibility of rejecting unsupported options elsewhere #1.
- Peter proposed backpatching to keep older branches warning-free #2; Andreas Karlsson supported the removals and backpatching but objected that unused attributes would hide genuine Windows warnings #3, and Tom Lane favored keeping that simple workaround for backbranches while improving master #4.
- Peter retained the original fixes and appended a master-only patch rejecting pg_ctl options -e, -N, -P and -U on non-Windows platforms, aligning them with -S and placing Windows-only globals behind conditional compilation #5; Tom approved the revised series #6.
- The four dead-variable removals from #5 were combined into 4e108ce790, with only a release-priority comment shortened.
- Master received the final pg_ctl implementation from #5 as 6a1c1102c4, combining the two pg_ctl patches without retaining their intermediate unused attributes.
- Backbranches received the unchanged pg_ctl attribute-suppression patch from #5 as fbaeb88978, avoiding the command-line behavior change.
- Peter closed the thread by confirming that the work had been committed and backpatched, including additional similar fixes needed in older branches; no submitted work remained pending #7.