model-writtenrun 221 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Shallow reported that embedded newlines in backup labels could inject fields into backup_label and prevent recovery, supplying reproductions and an inline check to reject CR and LF before taking the backup #1.
- Shihao Zhong reproduced the problem but questioned the use case, observing that trailing newlines currently worked and could arise when scripts read labels from files #2.
- David G. Johnston supported rejecting incompatible input #3, and Michael Paquier agreed that validation belonged in do_pg_backup_start() to cover both SQL backup functions and BASE_BACKUP, requesting recovery tests #4.
- Shihao Zhong attached the validation patch with tests for both newline and carriage-return labels, recommending master-only application because rejecting trailing newlines changed existing behavior #5.
- Michael Paquier accepted the patch and agreed that it should not go into stable branches, leaving time for further comments #6.
- Michael Paquier committed #5 as e624e1fd13, removing one source comment and expanding the commit explanation; his final message confirmed the change had landed on HEAD, with no remaining work identified #7.