model-writtenrun 56 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed consolidating and expanding pg_wchar_tbl callback documentation at the structure definition, removing unnecessary typedefs and renaming retained ones, while asking reviewers to check newly explicit behavioral guarantees #1.
- Greg Burd reviewed the patch, endorsed its focused scope, and suggested replacing “validly formed” with “well formed and valid” #2.
- Andreas Karlsson preferred the original wording because the proposed wording implied two separate properties, and Joel Jacobson questioned what validity added beyond well-formedness in the relevant encoding #3 #4.
- Peter committed the patch from #1 with minor comment clarifications and formatting changes, retaining its implementation and typedef cleanup 3ba886b35a.
- Peter confirmed completion and explained that he retained the original terminology because Unicode distinguishes well-formedness from validity; broader terminology cleanup remained a possible follow-up #5.