model-writtenrun 8560 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Heikki Linnakangas opened the thread to separate the missing pg_upgrade ICU-rule preservation from ongoing --initdb work, preferring PQescapeLiteral and expandable query and logging buffers so errors retain complete SQL diagnostics; he also identified redundant target-version branches in #1.
- Tom Lane questioned changing supposedly immutable template0 settings in #2, and Shihao Zhong clarified that pg_upgrade already copies the old cluster's locale defaults into the new template0 but omits daticurules in #3.
- Bohyun Lee submitted the combined preservation, buffer-growth, and target-version-cleanup patch in #4; Shihao tested it successfully on master and called for backpatching to PostgreSQL 16 in #5.
- Heikki questioned the broader usefulness of immutable template0 locale defaults and reported that initializing with ICU rules prevents creating databases with another locale provider in #6.
- Shihao argued for preserving existing defaults and supplied an independent CREATE DATABASE fix with regression tests in #7, restricting inherited ICU rules to databases using the ICU provider.
- Jeff Davis committed that CREATE DATABASE fix as 11910736bf, retaining the submitted code change while expanding and refining its tests, and announced completion in #8.
- Heikki split Bohyun's patch into the target-version cleanup 09b40d2cf0 and ICU-rule preservation fix 32dd742b07, with local query-selection and error-handling edits to the latter, and announced both original-issue work and the related fix complete in #9.
- Both submitted fixes had landed by the final message, while Heikki's broader question about whether template0 should carry locale defaults remained unresolved in #9.