Nov 2026

1 commit
Avoid resetting subscription two_phase state to pending when already enabled.
5 Nov 2026Amit KapilamasterunreleasedREL_19_STABLE19rc2REL_18_STABLE18.7
LLM analysis, 99% suremodified before commitlight changesfrom patchset #166 of 6 reviewers saw the final version

fc1900915b has an identical diff to #16 in src/backend/commands/subscriptioncmds.c and src/test/subscription/t/021_twophase.pl. The committer rewrote the commit message, adding the introduction history and expanding the replacement-slot explanation; there are no code or test edits.

  • shveta maliksaw the final versiontrailerIn #2 she suggested the equivalent guard expression and clearer test organization, then approved #3 in #7; only commit-message changes followed.
  • Hayato Kurodasaw the final versiontrailerHe examined redundant catalog updates in #4 and explicitly approved #3 in #6, after agreeing that broader update avoidance was separate work.
  • Bertrand Drouvotsaw the final versiontrailerHe reproduced the replacement-slot behavior change in #8, argued for preserving prior behavior in #10, and supported documenting the accepted change while requesting release-note coverage in #17.
  • vignesh Csaw the final versiontrailerHe identified the documented requirement for matching replacement-slot properties in #9 and explicitly approved the patch in #12; subsequent changes were limited to commit-message text.
  • Peter Smithsaw the final versiontrailerIn #13 he reviewed the conditional logic and proposed explicit enable/disable branches to improve readability and avoid redundant replacements, although that rewrite was not adopted.
  • Amit Kapilasaw the final versiontrailerHe approved the existing approach and requested the replacement-slot explanation in #15, then committed the final patch and confirmed the push in #18.

Credits across 1 commit

Author
Zhijie Hou1
Reviewer
Amit Kapila1
Bertrand Drouvot1
Hayato Kuroda (Fujitsu)1
Peter Smith1
shveta malik1
vignesh C1
Committer
Amit Kapila1