mysql2pgsql.perl update

Started by Andrew Hammondalmost 15 years ago5 messages
#1Andrew Hammond
andrew.george.hammond@gmail.com

Hi all.

I spent some time updating mysql2pgsql.perl. Changes were driven by an
attempt to migrate a redmine database. Original code was failing for a
number of reasons (regex recursion explosion, . I was wondering it
there's a more formal / appropriate place to put this. I'd also
appreciate a separate set of eyes on my changes. I grabbed an initial
copy from http://pgfoundry.org/projects/mysql2pgsql/
Git repo of the changes at
https://github.com/SmartReceipt/mysql2pgsql/commits/master/

Commit history follows.

commit 3cbe2cfa8782d250e5c4ee814c4585c96105fb45 (HEAD, sr/master,
origin/master, master)
Author: Andrew Hammond <andrew.george.hammond@gmail.com>
Date: Sat Feb 26 12:36:36 2011 -0800

simplify handling of mysql autoincrement to use serial8 datatype

commit 5c559b7073e6f6e72ce11f0f45be4d13cc30fd9a
Author: Andrew Hammond <andrew.george.hammond@gmail.com>
Date: Sat Feb 26 12:26:46 2011 -0800

multi-value inserts are supported in pgsql as of 8.2 and way faster

commit f5798a7911e5114378fd4764a62288e1826f6b56
Author: Andrew Hammond <andrew.george.hammond@gmail.com>
Date: Sat Feb 26 12:22:32 2011 -0800

replace \\ with \\\\

commit d730da318da301157783bf15c6add3e58e32b57e
Author: Andrew Hammond <andrew.george.hammond@gmail.com>
Date: Sat Feb 26 12:11:49 2011 -0800

best practices for handling quoted strings and use lookahead
rather than unnecessary match and replace

commit 20610fcb50d082e2c46bf27190e4d30dba966c27
Author: Andrew Hammond <andrew.george.hammond@gmail.com>
Date: Sat Feb 26 12:08:40 2011 -0800

whitespace & indenting normalization

commit 4281e1c314501f4209245ac55d31f1e43b4ddc21
Author: Andrew Hammond <andrew.george.hammond@gmail.com>
Date: Sat Feb 26 11:58:52 2011 -0800

pgfoundry version 2007-12-04 17:29

#2Josh Berkus
josh@agliodbs.com
In reply to: Andrew Hammond (#1)
Re: mysql2pgsql.perl update

Andrew,

I spent some time updating mysql2pgsql.perl. Changes were driven by an
attempt to migrate a redmine database. Original code was failing for a
number of reasons (regex recursion explosion, . I was wondering it
there's a more formal / appropriate place to put this. I'd also
appreciate a separate set of eyes on my changes. I grabbed an initial
copy from http://pgfoundry.org/projects/mysql2pgsql/
Git repo of the changes at
https://github.com/SmartReceipt/mysql2pgsql/commits/master/

I can give you ownership of the pgFoundry project. What's your
pgfoundry ID?

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

#3Andrew Hammond
andrew.george.hammond@gmail.com
In reply to: Josh Berkus (#2)
Re: mysql2pgsql.perl update

On Mon, Feb 28, 2011 at 10:49 AM, Josh Berkus <josh@agliodbs.com> wrote:

Andrew,

I spent some time updating mysql2pgsql.perl. Changes were driven by an
attempt to migrate a redmine database. Original code was failing for a
number of reasons (regex recursion explosion, . I was wondering it
there's a more formal / appropriate place to put this. I'd also
appreciate a separate set of eyes on my changes. I grabbed an initial
copy from http://pgfoundry.org/projects/mysql2pgsql/
Git repo of the changes at
https://github.com/SmartReceipt/mysql2pgsql/commits/master/

I can give you ownership of the pgFoundry project.  What's your
pgfoundry ID?

pgfoundry id is ahammond.

does foundry support git or should I just link to a repo on github?

A

#4Josh Berkus
josh@agliodbs.com
In reply to: Andrew Hammond (#3)
Re: mysql2pgsql.perl update

does foundry support git or should I just link to a repo on github?

If you prefer using git, the latter.

--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com

#5Andrew Hammond
andrew.george.hammond@gmail.com
In reply to: Josh Berkus (#4)
Re: mysql2pgsql.perl update

On Mon, Feb 28, 2011 at 11:26 AM, Josh Berkus <josh@agliodbs.com> wrote:

does foundry support git or should I just link to a repo on github?

If you prefer using git, the latter.

Ok, will do. Assign the project and I'll update stuff.

Andrew