Comments on system tables and columns

Started by Thom Brownabout 15 years ago4 messageshackers
Jump to latest
#1Thom Brown
thom@linux.com

Hi,

I notice that none of the system tables or columns thereof bear any
comments. Is this intentional, or an oversight? I would have thought
comments would be useful since the column names aren't exactly always
self-explanatory.

Thanks

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In reply to: Thom Brown (#1)
Re: Comments on system tables and columns

Em 28-03-2011 08:14, Thom Brown escreveu:

I notice that none of the system tables or columns thereof bear any
comments. Is this intentional, or an oversight? I would have thought
comments would be useful since the column names aren't exactly always
self-explanatory.

It could be useful in some cases. IIRC the comments are not there to avoid
bloating the catalog. One month ago or so I saw a commit to comment operator
support functions. Maybe it is worth comment system catalog too [1]http://eulerto.blogspot.com/2010/11/comment-on-catalog-tables.html.

[1]: http://eulerto.blogspot.com/2010/11/comment-on-catalog-tables.html

--
Euler Taveira de Oliveira
http://www.timbira.com/

#3Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Thom Brown (#1)
Re: Comments on system tables and columns

Excerpts from Thom Brown's message of lun mar 28 08:14:07 -0300 2011:

Hi,

I notice that none of the system tables or columns thereof bear any
comments. Is this intentional, or an oversight? I would have thought
comments would be useful since the column names aren't exactly always
self-explanatory.

Bruce has been working on changes to have catalog objects (tables, views
and columns) contain comments, but he deferred it to 9.2 because it
involved nontrivial pieces of infrastructure (mainly to avoid
duplication with the SGML catalog documentation).

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

#4Bruce Momjian
bruce@momjian.us
In reply to: Alvaro Herrera (#3)
Re: Comments on system tables and columns

Alvaro Herrera wrote:

Excerpts from Thom Brown's message of lun mar 28 08:14:07 -0300 2011:

Hi,

I notice that none of the system tables or columns thereof bear any
comments. Is this intentional, or an oversight? I would have thought
comments would be useful since the column names aren't exactly always
self-explanatory.

Bruce has been working on changes to have catalog objects (tables, views
and columns) contain comments, but he deferred it to 9.2 because it
involved nontrivial pieces of infrastructure (mainly to avoid
duplication with the SGML catalog documentation).

Attached are diffs that change the Makefile and initdb, and a perl
script to pull the system view comments out of the SGML docs. I need to
do more work to pull stuff for the system tables. This does work in
testing.

I will work on this more for 9.2.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachments:

/pgpatches/sysviews.difftext/x-diffDownload+40-36
/pgpatches/gen_comments.pltext/plainDownload