HTML tags :/

Started by David Fetterover 14 years ago8 messages

david@fetter.org

over 14 years ago

Folks,

While readjusting pg_docbot's URLs for LEAST and GREATEST, I came
across an infelicity. They'd been tagged as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN12680"
and I re-tagged them as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN15582"

I didn't see a more descriptive tag. Am I missing something
important?

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Alvaro Herrera

alvherre@commandprompt.com

over 14 years ago

In reply to: David Fetter (#1)

Re: HTML tags :/

Excerpts from David Fetter's message of lun abr 18 18:34:11 -0300 2011:

Folks,

While readjusting pg_docbot's URLs for LEAST and GREATEST, I came
across an infelicity. They'd been tagged as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN12680"
and I re-tagged them as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN15582"

I didn't see a more descriptive tag. Am I missing something
important?

The sect2 they are in would need an id attribute for there to be a
stable #-style link.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

David Fetter

david@fetter.org

over 14 years ago

In reply to: Alvaro Herrera (#2)

1 attachment(s)

Re: HTML tags :/

On Mon, Apr 18, 2011 at 06:44:03PM -0300, Alvaro Herrera wrote:

Excerpts from David Fetter's message of lun abr 18 18:34:11 -0300 2011:

Folks,

While readjusting pg_docbot's URLs for LEAST and GREATEST, I came
across an infelicity. They'd been tagged as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN12680"
and I re-tagged them as
"http://www.postgresql.org/docs/current/static/functions-conditional.html#AEN15582"

I didn't see a more descriptive tag. Am I missing something
important?

The sect2 they are in would need an id attribute for there to be a
stable #-style link.

Please find attached a patch to fix this.

I believe there are other places in the docs where an id attribute
would be handy. Will check those :)

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachments:

tag_least_greatest.difftext/plain; charset=us-asciiDownload

diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 633f215..14ac073 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -10034,7 +10034,7 @@ SELECT NULLIF(value, '(none)') ...
 
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-least-greatest">
    <title><literal>GREATEST</literal> and <literal>LEAST</literal></title>
 
   <indexterm>

Alvaro Herrera

alvherre@commandprompt.com

over 14 years ago

In reply to: David Fetter (#3)

Re: HTML tags :/

Excerpts from David Fetter's message of lun may 02 10:58:37 -0300 2011:

On Mon, Apr 18, 2011 at 06:44:03PM -0300, Alvaro Herrera wrote:

The sect2 they are in would need an id attribute for there to be a
stable #-style link.

Please find attached a patch to fix this.

I believe there are other places in the docs where an id attribute
would be handy. Will check those :)

I think it'd be good to have id attrs in all the sect2 sections of that
chapter.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

David Fetter

david@fetter.org

over 14 years ago

In reply to: Alvaro Herrera (#4)

Re: HTML tags :/

On Mon, May 02, 2011 at 12:15:09PM -0300, Alvaro Herrera wrote:

Excerpts from David Fetter's message of lun may 02 10:58:37 -0300 2011:

On Mon, Apr 18, 2011 at 06:44:03PM -0300, Alvaro Herrera wrote:

The sect2 they are in would need an id attribute for there to be a
stable #-style link.

Please find attached a patch to fix this.

I believe there are other places in the docs where an id attribute
would be handy. Will check those :)

I think it'd be good to have id attrs in all the sect2 sections of that
chapter.

By "that chapter," do you mean everything in func.sgml, or just the
stuff in the <sect1 id="functions-conditional"> ?

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Alvaro Herrera

alvherre@commandprompt.com

over 14 years ago

In reply to: David Fetter (#5)

Re: HTML tags :/

Excerpts from David Fetter's message of lun may 02 14:30:15 -0300 2011:

On Mon, May 02, 2011 at 12:15:09PM -0300, Alvaro Herrera wrote:

I think it'd be good to have id attrs in all the sect2 sections of that
chapter.

By "that chapter," do you mean everything in func.sgml, or just the
stuff in the <sect1 id="functions-conditional"> ?

Well, I mean the chapter:

There aren't that many sect2's missing the id (about one third of them
are in functions-conditional). The ones in functions-subquery could be
problematic though.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

David Fetter

david@fetter.org

over 14 years ago

In reply to: Alvaro Herrera (#6)

1 attachment(s)

Re: HTML tags :/

On Mon, May 02, 2011 at 04:56:42PM -0300, Alvaro Herrera wrote:

Excerpts from David Fetter's message of lun may 02 14:30:15 -0300 2011:

On Mon, May 02, 2011 at 12:15:09PM -0300, Alvaro Herrera wrote:

I think it'd be good to have id attrs in all the sect2 sections of that
chapter.

By "that chapter," do you mean everything in func.sgml, or just the
stuff in the <sect1 id="functions-conditional"> ?

Well, I mean the chapter:

<chapter id="functions">

There aren't that many sect2's missing the id (about one third of them
are in functions-conditional). The ones in functions-subquery could be
problematic though.

Please find attached a patch adding IDs to the appropriate (I think)
spots.

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachments:

tag_least_greatest_02.difftext/plain; charset=us-asciiDownload

diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 633f215..657835c 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -8717,7 +8717,7 @@ CREATE TYPE rainbow AS ENUM ('red', 'orange', 'yellow', 'green', 'blue', 'purple
    with <command>configure --with-libxml</>.
   </para>
 
-  <sect2>
+  <sect2 id="functions-producing-xml">
    <title>Producing XML Content</title>
 
    <para>
@@ -9093,7 +9093,7 @@ SELECT xmlagg(x) FROM (SELECT * FROM test ORDER BY y DESC) AS tab;
    </sect3>
    </sect2>
 
-   <sect2>
+   <sect2 id="functions-xml-predicates">
     <title>XML Predicates</title>
 
     <para>
@@ -9854,7 +9854,7 @@ SELECT setval('foo', 42, false);    <lineannotation>Next <function>nextval</> wi
    </para>
   </tip>
 
-  <sect2>
+  <sect2 id="functions-case">
    <title><literal>CASE</></title>
 
   <para>
@@ -9966,7 +9966,7 @@ SELECT ... WHERE CASE WHEN x &lt;&gt; 0 THEN y/x &gt; 1.5 ELSE false END;
    </para>
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-coalesce-nvl-ifnull">
    <title><literal>COALESCE</></title>
 
   <indexterm>
@@ -10005,7 +10005,7 @@ SELECT COALESCE(description, short_description, '(none)') ...
    </para>
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-nullif">
    <title><literal>NULLIF</></title>
 
   <indexterm>
@@ -10034,7 +10034,7 @@ SELECT NULLIF(value, '(none)') ...
 
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-greatest-least">
    <title><literal>GREATEST</literal> and <literal>LEAST</literal></title>
 
   <indexterm>
@@ -11492,7 +11492,7 @@ SELECT xmlagg(x) FROM (SELECT x FROM test ORDER BY y DESC) AS tab;
    Boolean (true/false) results.
   </para>
 
-  <sect2>
+  <sect2 id="functions-subquery-exists">
    <title><literal>EXISTS</literal></title>
 
 <synopsis>
@@ -11542,7 +11542,7 @@ WHERE EXISTS (SELECT 1 FROM tab2 WHERE col2 = tab1.col2);
   </para>
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-subquery-in">
    <title><literal>IN</literal></title>
 
 <synopsis>
@@ -11598,7 +11598,7 @@ WHERE EXISTS (SELECT 1 FROM tab2 WHERE col2 = tab1.col2);
   </para>
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-subquery-notin">
    <title><literal>NOT IN</literal></title>
 
 <synopsis>
@@ -11654,7 +11654,7 @@ WHERE EXISTS (SELECT 1 FROM tab2 WHERE col2 = tab1.col2);
   </para>
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-subquery-any-some">
    <title><literal>ANY</literal>/<literal>SOME</literal></title>
 
 <synopsis>
@@ -11719,7 +11719,7 @@ WHERE EXISTS (SELECT 1 FROM tab2 WHERE col2 = tab1.col2);
   </para>
   </sect2>
 
-  <sect2>
+  <sect2 id="functions-subquery-all">
    <title><literal>ALL</literal></title>
 
 <synopsis>

Alvaro Herrera

alvherre@commandprompt.com

over 14 years ago

In reply to: David Fetter (#7)

Re: HTML tags :/

Excerpts from David Fetter's message of lun may 02 17:53:35 -0300 2011:

Please find attached a patch adding IDs to the appropriate (I think)
spots.

Thanks. There are some ID missing on some sect2 still; I had a look
yesterday and the problem is that the subsection titles collide with the
sect2 titles of the previous sect1, which makes choosing good names not
so trivial.

I also tried to backpatch this to 9.0 but it doesn't apply cleanly so I
left it alone. If you want it to be backpatched, please send a modified
patch.

--
Álvaro Herrera <alvherre@commandprompt.com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support