pgsql: Message style cleanup

Is this part really correct?

-       fprintf(stderr, _("%s: final receive failed: %s\n"),
+       fprintf(stderr, _("%s: final receive failed: %s"),

all other msgs have \n.. I see you removed the final dot in many of
the other messages, did you just accidentally grab one too many?
(There are a couple of other examples of removing the \n though, so
perhaps it was intentional? But they're all preceeding
disconnect_and_exit() so I don't see why it shouldn't be consistent?

//Magnus

On Wed, May 4, 2011 at 20:10, Peter Eisentraut <peter_e@gmx.net> wrote:

Message style cleanup

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bff074b1ab0dfed7a7822dcc8942f877efa3b914

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c |   62 ++++++++++++++++----------------
1 files changed, 31 insertions(+), 31 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

On ons, 2011-05-04 at 20:32 +0200, Magnus Hagander wrote:

Is this part really correct?

-       fprintf(stderr, _("%s: final receive failed: %s\n"),
+       fprintf(stderr, _("%s: final receive failed: %s"),

all other msgs have \n.. I see you removed the final dot in many of
the other messages, did you just accidentally grab one too many?
(There are a couple of other examples of removing the \n though, so
perhaps it was intentional? But they're all preceeding
disconnect_and_exit() so I don't see why it shouldn't be consistent?

The result of PQerrorMessage() already ends in \n.

With that in mind, maybe I missed something?

On Wed, May 4, 2011 at 21:09, Peter Eisentraut <peter_e@gmx.net> wrote:

On ons, 2011-05-04 at 20:32 +0200, Magnus Hagander wrote:

Is this part really correct?

-       fprintf(stderr, _("%s: final receive failed: %s\n"),
+       fprintf(stderr, _("%s: final receive failed: %s"),

all other msgs have \n.. I see you removed the final dot in many of
the other messages, did you just accidentally grab one too  many?
(There are a couple of other examples of removing the \n though, so
perhaps it was  intentional? But they're all preceeding
disconnect_and_exit() so I don't see why it shouldn't be consistent?

The result of PQerrorMessage() already ends in \n.

With that in mind, maybe I missed something?

Oh, d'uh. I'm not paying attention. Sorry about the noise.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/