Contrib Versions

Started by David E. Wheelerover 14 years ago6 messages
#1David E. Wheeler
david@kineticode.com

Hackers,

I don't suppose I could convince you to use dotted-decimal version numbers for the contrib extension versions, rather than numerics, could I? At this point, I think that would just mean changing them from 1.0 to 1.0.0.

Why? Well, PGXN uses semantic versions, which have this format, so I'm biased that way when thinking about dependency resolution (which is coming in the the PGXN client). But the other reason is because I think it makes sense for all the versions in a project to be consistent, and the core versions have (mostly) always used this format.

Thoughts?

Best,

David

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: David E. Wheeler (#1)
Re: Contrib Versions

"David E. Wheeler" <david@kineticode.com> writes:

Hackers,
I don't suppose I could convince you to use dotted-decimal version numbers for the contrib extension versions, rather than numerics, could I? At this point, I think that would just mean changing them from 1.0 to 1.0.0.

Why? Well, PGXN uses semantic versions, which have this format, so I'm biased that way when thinking about dependency resolution (which is coming in the the PGXN client). But the other reason is because I think it makes sense for all the versions in a project to be consistent, and the core versions have (mostly) always used this format.

I had somewhat intentionally not numbered them in the same format as the
main release numbers, because if we did that, people would expect them
to match the main release numbers.

I'm also still unwilling to make a core-code commitment to specific
requirements on extension version number format --- we've been around on
that multiple times already, and I don't think the arguments have
changed.

Having said that, I don't really care that much, except that it seems
a bit late in the release cycle to be changing this. People have
presumably already got installations that they hope to not have to
scratch and reload for 9.1 final.

regards, tom lane

#3David E. Wheeler
david@kineticode.com
In reply to: Tom Lane (#2)
Re: Contrib Versions

On May 12, 2011, at 3:09 PM, Tom Lane wrote:

I had somewhat intentionally not numbered them in the same format as the
main release numbers, because if we did that, people would expect them
to match the main release numbers.

Well, I think the fact that they're all 1.x managed to do that well enough.

I'm also still unwilling to make a core-code commitment to specific
requirements on extension version number format --- we've been around on
that multiple times already, and I don't think the arguments have
changed.

It wouldn't be a commitment any more than using 1.0 was. I expect that either way they would be used consistently over time.

Having said that, I don't really care that much, except that it seems
a bit late in the release cycle to be changing this. People have
presumably already got installations that they hope to not have to
scratch and reload for 9.1 final.

Would changing the versions from 1.0 to 1.0.0 really break anything for those folks?

Best,

David

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: David E. Wheeler (#3)
Re: Contrib Versions

"David E. Wheeler" <david@kineticode.com> writes:

On May 12, 2011, at 3:09 PM, Tom Lane wrote:

Having said that, I don't really care that much, except that it seems
a bit late in the release cycle to be changing this. People have
presumably already got installations that they hope to not have to
scratch and reload for 9.1 final.

Would changing the versions from 1.0 to 1.0.0 really break anything for those folks?

It would as soon as they needed to do an ALTER EXTENSION UPDATE ...

regards, tom lane

#5Robert Haas
robertmhaas@gmail.com
In reply to: David E. Wheeler (#3)
Re: Contrib Versions

On Thu, May 12, 2011 at 6:33 PM, David E. Wheeler <david@kineticode.com> wrote:

Having said that, I don't really care that much, except that it seems
a bit late in the release cycle to be changing this.  People have
presumably already got installations that they hope to not have to
scratch and reload for 9.1 final.

Would changing the versions from 1.0 to 1.0.0 really break anything for those folks?

Yes.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#6David E. Wheeler
david@kineticode.com
In reply to: Tom Lane (#4)
Re: Contrib Versions

On May 12, 2011, at 3:50 PM, Tom Lane wrote:

Would changing the versions from 1.0 to 1.0.0 really break anything for those folks?

It would as soon as they needed to do an ALTER EXTENSION UPDATE ..

Ah-ite, screw it then.

Best,

David