pgsql: Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.
Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.
The value when BLCKSZ = 8192 is unchanged, but with larger-than-normal
block sizes we might need to crank things back a bit, as we'll have
more entries per page than normal in that case.
Kevin Grittner
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/5b2b444f66363ee4132b9e398c0535fa59765a63
Modified Files
--------------
src/backend/storage/lmgr/predicate.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
On 07.07.2011 22:09, Robert Haas wrote:
Adjust OLDSERXID_MAX_PAGE based on BLCKSZ.
The value when BLCKSZ = 8192 is unchanged, but with larger-than-normal
block sizes we might need to crank things back a bit, as we'll have
more entries per page than normal in that case.
I'm getting a bunch of warnings on Windows related to this:
.\src\backend\storage\lmgr\predicate.c(768): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(768): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(769): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(769): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(770): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(770): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(770): warning C4146: unary minus operator applied to unsigned type, result still unsigned
.\src\backend\storage\lmgr\predicate.c(771): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(771): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(826): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(826): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(846): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(846): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(851): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(851): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(909): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(909): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(956): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(956): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(1036): warning C4307: '+' : integral constant overflow
.\src\backend\storage\lmgr\predicate.c(1036): warning C4307: '+' : integral constant overflow
I'm not sure if these are harmless or not.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com