pgsql: Add missing newlines at end of error messages

Started by Peter Eisentrautover 14 years ago4 messages
#1Peter Eisentraut
peter_e@gmx.net

Add missing newlines at end of error messages

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e67efb01e886d69d40d1cd87fba4507e8bb1035e

Modified Files
--------------
src/bin/psql/command.c | 2 +-
src/bin/psql/common.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

#2David Fetter
david@fetter.org
In reply to: Peter Eisentraut (#1)
Re: [COMMITTERS] pgsql: Add missing newlines at end of error messages

This seems like a mechanical check. Should it be part of what gets
checked when people push?

Cheers,
David.
On Tue, Jul 26, 2011 at 08:30:16PM +0000, Peter Eisentraut wrote:

Add missing newlines at end of error messages

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e67efb01e886d69d40d1cd87fba4507e8bb1035e

Modified Files
--------------
src/bin/psql/command.c | 2 +-
src/bin/psql/common.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

#3Peter Eisentraut
peter_e@gmx.net
In reply to: David Fetter (#2)
Re: [COMMITTERS] pgsql: Add missing newlines at end of error messages

On tis, 2011-07-26 at 15:13 -0700, David Fetter wrote:

This seems like a mechanical check. Should it be part of what gets
checked when people push?

It's not really that mechanical, because some libpq functions supply the
newline, so you can't just mechanically add or enforce it everywhere.

#4David Fetter
david@fetter.org
In reply to: Peter Eisentraut (#3)
Re: [COMMITTERS] pgsql: Add missing newlines at end of error messages

On Wed, Jul 27, 2011 at 05:14:58PM +0300, Peter Eisentraut wrote:

On tis, 2011-07-26 at 15:13 -0700, David Fetter wrote:

This seems like a mechanical check. Should it be part of what gets
checked when people push?

It's not really that mechanical, because some libpq functions supply the
newline, so you can't just mechanically add or enforce it everywhere.

Thanks for the heads-up :)

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate