pgsql: Add missing format argument to ecpg_log() call

Started by Peter Eisentrautover 14 years ago3 messages
#1Peter Eisentraut
peter_e@gmx.net

Add missing format argument to ecpg_log() call

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cf15fb5cabfbc71e07be23cfbc813daee6c5014f

Modified Files
--------------
src/interfaces/ecpg/ecpglib/execute.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Peter Eisentraut (#1)
Re: pgsql: Add missing format argument to ecpg_log() call

Peter Eisentraut <peter_e@gmx.net> writes:

Add missing format argument to ecpg_log() call

Oh, fun. So why isn't there an __attribute__((format...)) decoration
on ecpg_log()?

regards, tom lane

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#2)
Re: [COMMITTERS] pgsql: Add missing format argument to ecpg_log() call

On tor, 2011-09-08 at 15:32 -0400, Tom Lane wrote:

Peter Eisentraut <peter_e@gmx.net> writes:

Add missing format argument to ecpg_log() call

Oh, fun. So why isn't there an __attribute__((format...)) decoration
on ecpg_log()?

I have a larger patch for that. I just wanted to get the one piece of
obvious breakage backpatched.

I'm also proposing to add -Wmissing-format-attribute to the standard
options set.