RE: [HACKERS] dynamic loading on NT works!

Started by Horak Danielalmost 27 years ago2 messages
#1Horak Daniel
horak@mmp.plzen-city.cz
3 attachment(s)

Hi,

I have solved some problems with dynamic loading on NT. It is possible to
run succesfully both trigger and plpgsql regression tests. The patch is in
the included file "diff".

Dan

PS: current regress.out and regression.diff are included
some notes:
- int2, int4, float8 - different error messages from libc
- geometry - differences in float numbers (mostly least significant digits)
- date & time - 1 hour difference
- constraints - important!!!
- misc - missing lines in result
- rules - different order of returned records
- temp - crash when doing "\c regression" ;-(

Attachments:

diffapplication/octet-stream; name=diffDownload
Index: src/include/utils/mcxt.h
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/include/utils/mcxt.h,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 mcxt.h
--- mcxt.h	1999/03/12 21:36:23	1.1.1.2
+++ mcxt.h	1999/03/19 19:48:35
@@ -22,7 +22,7 @@
 typedef struct GlobalMemoryData *GlobalMemory;
 
 
-extern MemoryContext CurrentMemoryContext;
+extern DLLIMPORT MemoryContext CurrentMemoryContext;
 extern MemoryContext TopMemoryContext;
 
 
Index: src/backend/utils/mmgr/mcxt.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/backend/utils/mmgr/mcxt.c,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 mcxt.c
--- mcxt.c	1999/03/12 21:33:06	1.1.1.2
+++ mcxt.c	1999/03/19 19:46:58
@@ -67,7 +67,7 @@
  * CurrentMemoryContext 
  *		Memory context for general global allocations.
  */
-MemoryContext CurrentMemoryContext = NULL;
+DLLIMPORT MemoryContext CurrentMemoryContext = NULL;
 
 /*****************************************************************************
  *	  PRIVATE DEFINITIONS													 *
Index: src/backend/tcop/postgres.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/backend/tcop/postgres.c,v
retrieving revision 1.4
diff -u -r1.4 postgres.c
--- postgres.c	1999/03/13 12:27:06	1.4
+++ postgres.c	1999/03/19 20:25:57
@@ -142,7 +142,7 @@
 #define sigsetjmp(x,y)	setjmp(x)
 #define siglongjmp longjmp
 #else
-sigjmp_buf	Warn_restart;
+DLLIMPORT sigjmp_buf	Warn_restart;
 
 #endif	 /* defined(nextstep) */
 bool		InError;
Index: src/pl/plpgsql/src/pl_exec.c
===================================================================
RCS file: /usr/local/cvsroot/pgsql/src/pl/plpgsql/src/pl_exec.c,v
retrieving revision 1.1.1.2
diff -u -r1.1.1.2 pl_exec.c
--- pl_exec.c	1999/03/12 21:38:46	1.1.1.2
+++ pl_exec.c	1999/03/19 20:25:25
@@ -75,7 +75,7 @@
 #define siglongjmp		longjmp
 #endif
 
-extern sigjmp_buf Warn_restart; /* in tcop/postgres.c */
+extern DLLIMPORT sigjmp_buf Warn_restart; /* in tcop/postgres.c */
 
 static PLpgSQL_function *error_info_func = NULL;
 static PLpgSQL_stmt *error_info_stmt = NULL;
regress.outapplication/octet-stream; name=regress.outDownload
regression.diffs.gzapplication/octet-stream; name=regression.diffs.gzDownload
#2Bruce Momjian
maillist@candle.pha.pa.us
In reply to: Horak Daniel (#1)
Re: [HACKERS] dynamic loading on NT works!

[Charset iso-8859-2 unsupported, filtering to ASCII...]

Hi,

I have solved some problems with dynamic loading on NT. It is possible to
run succesfully both trigger and plpgsql regression tests. The patch is in
the included file "diff".

Dan

PS: current regress.out and regression.diff are included
some notes:
- int2, int4, float8 - different error messages from libc
- geometry - differences in float numbers (mostly least significant digits)
- date & time - 1 hour difference
- constraints - important!!!
- misc - missing lines in result
- rules - different order of returned records
- temp - crash when doing "\c regression" ;-(

Applied. Hopefully someone will have fixes for the regression problems.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026