documentation issue - extensions

Started by Pavel Stehuleabout 14 years ago9 messages
#1Pavel Stehule
pavel.stehule@gmail.com

Hello

I am trying to create simple extension according to doc
http://www.postgresql.org/docs/9.1/interactive/extend-extensions.html

I have a problem with line that contains backslash statement

-- complain if script is sourced in psql, rather than via CREATE
EXTENSION
\echo Use "CREATE EXTENSION pair" to load this file. \quit

this content causes a error

postgres=# create extension gdlib;
ERROR: syntax error at or near "\"

without this line extension is created fine.

Is documentation correct?

Regards

Pavel

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Pavel Stehule (#1)
Re: documentation issue - extensions

Pavel Stehule <pavel.stehule@gmail.com> writes:

I am trying to create simple extension according to doc
http://www.postgresql.org/docs/9.1/interactive/extend-extensions.html

I have a problem with line that contains backslash statement

-- complain if script is sourced in psql, rather than via CREATE
EXTENSION
\echo Use "CREATE EXTENSION pair" to load this file. \quit

this content causes a error

postgres=# create extension gdlib;
ERROR: syntax error at or near "\"

Are you testing in an up-to-date server? We added the ability to handle
that post-9.1.0.

regards, tom lane

#3Pavel Stehule
pavel.stehule@gmail.com
In reply to: Tom Lane (#2)
Re: documentation issue - extensions

2011/12/7 Tom Lane <tgl@sss.pgh.pa.us>:

Pavel Stehule <pavel.stehule@gmail.com> writes:

I am trying to create simple extension according to doc
http://www.postgresql.org/docs/9.1/interactive/extend-extensions.html

I have a problem with line that contains backslash statement

-- complain if script is sourced in psql, rather than via CREATE
EXTENSION
\echo Use "CREATE EXTENSION pair" to load this file. \quit

this content causes a error

postgres=# create extension gdlib;
ERROR:  syntax error at or near "\"

Are you testing in an up-to-date server?  We added the ability to handle
that post-9.1.0.

it was tested on 9.1.1

Show quoted text

                       regards, tom lane

#4Tom Lane
tgl@sss.pgh.pa.us
In reply to: Pavel Stehule (#3)
Re: documentation issue - extensions

Pavel Stehule <pavel.stehule@gmail.com> writes:

2011/12/7 Tom Lane <tgl@sss.pgh.pa.us>:

Pavel Stehule <pavel.stehule@gmail.com> writes:

I have a problem with line that contains backslash statement

Are you testing in an up-to-date server? We added the ability to handle
that post-9.1.0.

it was tested on 9.1.1

[ checks release notes... ] Well, we added it in 9.1.2, so there you are.

regards, tom lane

#5Pavel Stehule
pavel.stehule@gmail.com
In reply to: Tom Lane (#4)
Re: documentation issue - extensions

2011/12/7 Tom Lane <tgl@sss.pgh.pa.us>:

Pavel Stehule <pavel.stehule@gmail.com> writes:

2011/12/7 Tom Lane <tgl@sss.pgh.pa.us>:

Pavel Stehule <pavel.stehule@gmail.com> writes:

I have a problem with line that contains backslash statement

Are you testing in an up-to-date server?  We added the ability to handle
that post-9.1.0.

it was tested on 9.1.1

[ checks release notes... ]  Well, we added it in 9.1.2, so there you are.

I can upgrade - it's not problem - just it is surprise for me -
because documentation is not related to mayor version. Maybe this
issue can be documented somewhere

Regards

Pavel

Show quoted text

                       regards, tom lane

#6Kevin Grittner
Kevin.Grittner@wicourts.gov
In reply to: Pavel Stehule (#5)
Re: documentation issue - extensions

Pavel Stehule <pavel.stehule@gmail.com> wrote:

I can upgrade - it's not problem - just it is surprise for me -
because documentation is not related to mayor version. Maybe this
issue can be documented somewhere

Don't the release notes, mentioning that the bug is fixed in 9.1.2,
cover that?

-Kevin

#7Pavel Stehule
pavel.stehule@gmail.com
In reply to: Kevin Grittner (#6)
Re: documentation issue - extensions

2011/12/7 Kevin Grittner <Kevin.Grittner@wicourts.gov>:

Pavel Stehule <pavel.stehule@gmail.com> wrote:

I can upgrade - it's not problem - just it is surprise for me -
because documentation is not related to mayor version. Maybe this
issue can be documented somewhere

Don't the release notes, mentioning that the bug is fixed in 9.1.2,
cover that?

It is little bit difficult detect this issue as bug

Regards

Pavel

Show quoted text

-Kevin

#8Robert Haas
robertmhaas@gmail.com
In reply to: Pavel Stehule (#7)
Re: documentation issue - extensions

On Wed, Dec 7, 2011 at 4:37 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:

2011/12/7 Kevin Grittner <Kevin.Grittner@wicourts.gov>:

Pavel Stehule <pavel.stehule@gmail.com> wrote:

I can upgrade - it's not problem - just it is surprise for me -
because documentation is not related to mayor version. Maybe this
issue can be documented somewhere

Don't the release notes, mentioning that the bug is fixed in 9.1.2,
cover that?

It is little bit difficult detect this issue as bug

It's not a bug. It's an not-forward-compatible behavior change in a
minor release.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#9Pavel Stehule
pavel.stehule@gmail.com
In reply to: Robert Haas (#8)
Re: documentation issue - extensions

2011/12/8 Robert Haas <robertmhaas@gmail.com>:

On Wed, Dec 7, 2011 at 4:37 PM, Pavel Stehule <pavel.stehule@gmail.com> wrote:

2011/12/7 Kevin Grittner <Kevin.Grittner@wicourts.gov>:

Pavel Stehule <pavel.stehule@gmail.com> wrote:

I can upgrade - it's not problem - just it is surprise for me -
because documentation is not related to mayor version. Maybe this
issue can be documented somewhere

Don't the release notes, mentioning that the bug is fixed in 9.1.2,
cover that?

It is little bit difficult detect this issue as bug

It's not a bug.  It's an not-forward-compatible behavior change in a
minor release.

so this can be mentioned in documentation elsewhere than release notes
- the best is near related examples - it is different behave than
postgresql's user expect.

I understand to reason now - and it has sense - but it is surprising -
not all has newer postgres - this version is mostly in development
environments than production in this moment.

Regards

Pavel

Show quoted text

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company