psql tab completion for GRANT role

Started by Peter Eisentrautover 14 years ago4 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

psql tab completion currently only supports the form GRANT privilege ON
something TO someone (and the analogous REVOKE), but not the form GRANT
role TO someone. Here is a patch that attempts to implement the latter.

Attachments:

grant-role-tab-completion.patchtext/x-patch; charset=UTF-8; name=grant-role-tab-completion.patchDownload+53-10
#2Robert Haas
robertmhaas@gmail.com
In reply to: Peter Eisentraut (#1)
Re: psql tab completion for GRANT role

On Sun, Jan 8, 2012 at 3:48 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

psql tab completion currently only supports the form GRANT privilege ON
something TO someone (and the analogous REVOKE), but not the form GRANT
role TO someone.  Here is a patch that attempts to implement the latter.

This seems to have fallen through the cracks. It doesn't apply any
more, but one general comment is that it seems undesirable to
repeatedly recapitulate the list of all privileges that exist in the
system. That's a lot of places that someone will have to find and fix
when new privileges are added.

But +1 on the general idea.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Robert Haas (#2)
Re: psql tab completion for GRANT role

On tor, 2012-06-14 at 13:38 -0400, Robert Haas wrote:

On Sun, Jan 8, 2012 at 3:48 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

psql tab completion currently only supports the form GRANT privilege ON
something TO someone (and the analogous REVOKE), but not the form GRANT
role TO someone. Here is a patch that attempts to implement the latter.

This seems to have fallen through the cracks.

No, it was committed in January.

#4Robert Haas
robertmhaas@gmail.com
In reply to: Peter Eisentraut (#3)
Re: psql tab completion for GRANT role

On Tue, Jun 19, 2012 at 3:16 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

On tor, 2012-06-14 at 13:38 -0400, Robert Haas wrote:

On Sun, Jan 8, 2012 at 3:48 PM, Peter Eisentraut <peter_e@gmx.net> wrote:

psql tab completion currently only supports the form GRANT privilege ON
something TO someone (and the analogous REVOKE), but not the form GRANT
role TO someone.  Here is a patch that attempts to implement the latter.

This seems to have fallen through the cracks.

No, it was committed in January.

Oops, I missed that. Sorry for the noise.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company