column name of pg_stat_replication.backend_start
Hi,
The column name of pg_stat_replication.backend_start is confusing because
it's not the time when *backend* was started at all. We should rename it to
"walsender_start" or "replication_start"?
Regards,
--
Fujii Masao
On Sat, Apr 14, 2012 at 8:00 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
The column name of pg_stat_replication.backend_start is confusing because
it's not the time when *backend* was started at all. We should rename it to
"walsender_start" or "replication_start"?
walsenders are backends, of course. I think that any clarity we'd get
from renaming this would be not worth the loss of backward
compatibility or the inconsistency with pg_stat_activity.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Sat, Apr 14, 2012 at 14:22, Robert Haas <robertmhaas@gmail.com> wrote:
On Sat, Apr 14, 2012 at 8:00 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
The column name of pg_stat_replication.backend_start is confusing because
it's not the time when *backend* was started at all. We should rename it to
"walsender_start" or "replication_start"?walsenders are backends, of course. I think that any clarity we'd get
from renaming this would be not worth the loss of backward
compatibility or the inconsistency with pg_stat_activity.
There was a suggestion the other day I think from Bruce to rename it
to session_start in pg_stat_activity. If we do that, we should
probably rename it in pg_stat_replication *as well*, of course...
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
On Sat, Apr 14, 2012 at 10:05 PM, Magnus Hagander <magnus@hagander.net> wrote:
On Sat, Apr 14, 2012 at 14:22, Robert Haas <robertmhaas@gmail.com> wrote:
On Sat, Apr 14, 2012 at 8:00 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
The column name of pg_stat_replication.backend_start is confusing because
it's not the time when *backend* was started at all. We should rename it to
"walsender_start" or "replication_start"?walsenders are backends, of course. I think that any clarity we'd get
from renaming this would be not worth the loss of backward
compatibility or the inconsistency with pg_stat_activity.There was a suggestion the other day I think from Bruce to rename it
to session_start in pg_stat_activity. If we do that, we should
probably rename it in pg_stat_replication *as well*, of course...
Yep, agreed.
Regards,
--
Fujii Masao