A typo fix in a comment in xlog.c

Started by Kyotaro HORIGUCHIover 13 years ago3 messages
#1Kyotaro HORIGUCHI
horiguchi.kyotaro@lab.ntt.co.jp
1 attachment(s)

Hello, I found a duplicate words in the comment of
StartupXLOG@xlog.c and the attached patch fixes it.

Essentially the fix is in one line as follows,

-  * We're in recovery, so unlogged relations relations may be trashed
+  * We're in recovery, so unlogged relations may be trashed

But I did fill-paragraph for the fixed comment so the patch
replaces a little bit more.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

== My e-mail address has been changed since Apr. 1, 2012.

Attachments:

StartupXLOG_xlog.c_typo_fix_20120416.patchtext/x-patch; charset=us-asciiDownload
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 0c301b2..04dec4e 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6354,10 +6354,10 @@ StartupXLOG(void)
 		CheckRequiredParameterValues();
 
 		/*
-		 * We're in recovery, so unlogged relations relations may be trashed
-		 * and must be reset.  This should be done BEFORE allowing Hot Standby
-		 * connections, so that read-only backends don't try to read whatever
-		 * garbage is left over from before.
+		 * We're in recovery, so unlogged relations may be trashed and must
+		 * be reset.  This should be done BEFORE allowing Hot Standby
+		 * connections, so that read-only backends don't try to read
+		 * whatever garbage is left over from before.
 		 */
 		ResetUnloggedRelations(UNLOGGED_RELATION_CLEANUP);
 
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Kyotaro HORIGUCHI (#1)
Re: A typo fix in a comment in xlog.c

On mån, 2012-04-16 at 21:28 +0900, Kyotaro HORIGUCHI wrote:

Hello, I found a duplicate words in the comment of
StartupXLOG@xlog.c and the attached patch fixes it.

Essentially the fix is in one line as follows,

-  * We're in recovery, so unlogged relations relations may be trashed
+  * We're in recovery, so unlogged relations may be trashed

Fixed.

But I did fill-paragraph for the fixed comment so the patch
replaces a little bit more.

You might want to adjust your fill-column setting to 79, so pgindent
doesn't reformat that again. Compare to what I just committed.

#3Kyotaro HORIGUCHI
horiguchi.kyotaro@lab.ntt.co.jp
In reply to: Peter Eisentraut (#2)
Re: A typo fix in a comment in xlog.c

But I did fill-paragraph for the fixed comment so the patch
replaces a little bit more.

You might want to adjust your fill-column setting to 79, so pgindent
doesn't reformat that again. Compare to what I just committed.

Thank you for sugestion. I could't decide fill-column fit to
every code and comments.

--
Kyotaro Horiguchi
NTT Open Source Software Center

== My e-mail address has been changed since Apr. 1, 2012.