psql: server version check for \dO

Started by Josh Kupershmidtalmost 14 years ago2 messageshackers
Jump to latest
#1Josh Kupershmidt
schmiddy@gmail.com

Hi all,

I think psql's \dO command is missing the server version check which
similar commands such as \dx use. Right now \dO errors out with:

test=# \dO
ERROR: relation "pg_catalog.pg_collation" does not exist

when talking to servers older than 9.1, which don't have pg_collation.
Simple patch for listCollations() attached.

Josh

Attachments:

listCollations_versioncheck.difftext/x-patch; charset=US-ASCII; name=listCollations_versioncheck.diffDownload+7-0
#2Magnus Hagander
magnus@hagander.net
In reply to: Josh Kupershmidt (#1)
Re: psql: server version check for \dO

On Thu, May 10, 2012 at 7:09 AM, Josh Kupershmidt <schmiddy@gmail.com> wrote:

Hi all,

I think psql's \dO command is missing the server version check which
similar commands such as \dx use. Right now \dO errors out with:

test=# \dO
ERROR:  relation "pg_catalog.pg_collation" does not exist

when talking to servers older than 9.1, which don't have pg_collation.
Simple patch for listCollations() attached.

Indeed. Thanks, applied and backpatched to 9.1.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/