Report proper GUC parameter names in error messages
Started by Gurjeet Singhover 13 years ago2 messages
Error messages when terminating xlog redo leads the user to believe that
there are parameters named max_prepared_xacts and max_locks_per_xact, which
is not true. This patch corrects the parameter names emitted in the logs.
Best regards,
--
Gurjeet Singh
Attachments:
proper_GUC_names.patchapplication/octet-stream; name=proper_GUC_names.patchDownload
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 911ea8a..806f616 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6032,10 +6032,10 @@ CheckRequiredParameterValues(void)
RecoveryRequiresIntParameter("max_connections",
MaxConnections,
ControlFile->MaxConnections);
- RecoveryRequiresIntParameter("max_prepared_xacts",
+ RecoveryRequiresIntParameter("max_prepared_transactions",
max_prepared_xacts,
ControlFile->max_prepared_xacts);
- RecoveryRequiresIntParameter("max_locks_per_xact",
+ RecoveryRequiresIntParameter("max_locks_per_transaction",
max_locks_per_xact,
ControlFile->max_locks_per_xact);
}
Re: Report proper GUC parameter names in error messages
Gurjeet Singh <singh.gurjeet@gmail.com> writes:
Error messages when terminating xlog redo leads the user to believe that
there are parameters named max_prepared_xacts and max_locks_per_xact, which
is not true. This patch corrects the parameter names emitted in the logs.
Good catch --- applied.
regards, tom lane