Missing OID define

Started by Phil Sorberover 13 years ago4 messages
#1Phil Sorber
phil@omniti.com
1 attachment(s)

Thom Brown and I were doing some hacking the other day and came across
this missing define. We argued over who was going to send the patch in
and I lost. So here it is.

Attachments:

pg_type_uuid_oid.diffapplication/octet-stream; name=pg_type_uuid_oid.diffDownload
diff --git a/src/include/catalog/pg_type.h b/src/include/catalog/pg_type.h
new file mode 100644
index 86be998..d0fe7c5
*** a/src/include/catalog/pg_type.h
--- b/src/include/catalog/pg_type.h
*************** DATA(insert OID = 2211 ( _regtype	   PGN
*** 573,578 ****
--- 573,579 ----
  /* uuid */
  DATA(insert OID = 2950 ( uuid			PGNSP PGUID 16 f b U f t \054 0 0 2951 uuid_in uuid_out uuid_recv uuid_send - - - c p f 0 -1 0 0 _null_ _null_ _null_ ));
  DESCR("UUID datatype");
+ #define UUIDOID 2950
  DATA(insert OID = 2951 ( _uuid			PGNSP PGUID -1 f b A f t \054 0 2950 0 array_in array_out array_recv array_send - - array_typanalyze i x f 0 -1 0 0 _null_ _null_ _null_ ));
  
  /* text search */
#2Thom Brown
thom@linux.com
In reply to: Phil Sorber (#1)
Re: Missing OID define

On 2 October 2012 15:47, Phil Sorber <phil@omniti.com> wrote:

Thom Brown and I were doing some hacking the other day and came across
this missing define. We argued over who was going to send the patch in
and I lost. So here it is.

Capital idea. +1

--
Thom

#3Albe Laurenz
laurenz.albe@wien.gv.at
In reply to: Phil Sorber (#1)
Re: Missing OID define

Phil Sorber wrote:

Thom Brown and I were doing some hacking the other day and came across
this missing define. We argued over who was going to send the patch in
and I lost. So here it is.

+1

I have been missing this #define.

Yours,
Laurenz Albe

#4Robert Haas
robertmhaas@gmail.com
In reply to: Albe Laurenz (#3)
Re: Missing OID define

On Fri, Oct 5, 2012 at 3:32 AM, Albe Laurenz <laurenz.albe@wien.gv.at> wrote:

Phil Sorber wrote:

Thom Brown and I were doing some hacking the other day and came across
this missing define. We argued over who was going to send the patch in
and I lost. So here it is.

+1

I have been missing this #define.

After extensive review, I have committed this patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company