[PATCH] Patch to fix missing libecpg_compat.lib and libpgtypes.lib.

Started by JiangGuiqingabout 13 years ago3 messages
#1JiangGuiqing
jianggq@cn.fujitsu.com
1 attachment(s)

hi

I install postgresql-9.1.5 from source code on windows successfully.
But there is not "libecpg_compat.lib" and "libpgtypes.lib" in the
installed lib directory .
If someone used functions of pgtypes or ecpg_compat library in ecpg
programs,the ecpg program build will fail.

So i modify src/tools/msvc/Install.pm to resolve this problem.
The diff file refer to the attachment "Install.pm.patch".

Regards,
Jiang Guiqing

Attachments:

Install.pm.patchtext/plain; charset=Shift_JIS; name=Install.pm.patchDownload
diff --git a/src/tools/msvc/Install.pm b/src/tools/msvc/Install.pm
index 6036714..91e6a53 100644
--- a/src/tools/msvc/Install.pm
+++ b/src/tools/msvc/Install.pm
@@ -86,7 +86,7 @@ sub Install
 		'Import libraries', $target . '/lib/',
 		"$conf\\",          "postgres\\postgres.lib",
 		"libpq\\libpq.lib", "libecpg\\libecpg.lib",
-		"libpgport\\libpgport.lib");
+		"libpgport\\libpgport.lib","libpgtypes\\libpgtypes.lib","libecpg_compat\\libecpg_compat.lib");
 	CopySetOfFiles(
 		'timezone names',
 		[ glob('src\timezone\tznames\*.txt') ],
#2Peter Eisentraut
peter_e@gmx.net
In reply to: JiangGuiqing (#1)
Re: [PATCH] Patch to fix missing libecpg_compat.lib and libpgtypes.lib.

On Mon, 2012-11-19 at 14:03 +0800, JiangGuiqing wrote:

hi

I install postgresql-9.1.5 from source code on windows successfully.
But there is not "libecpg_compat.lib" and "libpgtypes.lib" in the
installed lib directory .
If someone used functions of pgtypes or ecpg_compat library in ecpg
programs,the ecpg program build will fail.

So i modify src/tools/msvc/Install.pm to resolve this problem.
The diff file refer to the attachment "Install.pm.patch".

Could someone with access to Windows verify this patch?

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Magnus Hagander
magnus@hagander.net
In reply to: Peter Eisentraut (#2)
Re: [PATCH] Patch to fix missing libecpg_compat.lib and libpgtypes.lib.

On Tue, Jan 8, 2013 at 4:16 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

On Mon, 2012-11-19 at 14:03 +0800, JiangGuiqing wrote:

hi

I install postgresql-9.1.5 from source code on windows successfully.
But there is not "libecpg_compat.lib" and "libpgtypes.lib" in the
installed lib directory .
If someone used functions of pgtypes or ecpg_compat library in ecpg
programs,the ecpg program build will fail.

So i modify src/tools/msvc/Install.pm to resolve this problem.
The diff file refer to the attachment "Install.pm.patch".

Could someone with access to Windows verify this patch?

Thta version doesn't even apply to 9.1 - only to master. And the
indent on master is really bad.

That said, function looks good, so I've cleaned i tup and applied.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers