Re: pg_basebackup is taking backup of extra files inside a tablespace directory

On Wed, Nov 28, 2012 at 12:43 PM, Michael Paquier <

michael(dot)paquier(at)gmail(dot)com>wrote:

On Wed, Nov 28, 2012 at 3:55 PM, Hari Babu

<haribabu(dot)kommi(at)huawei(dot)com>wrote:

pg_basebackup is taking backup of extra files other than database related
files in side a TABLESPACE directory.

And why do you have files not related to your PG server inside a folder
dedicated to a PG server?

Incase of pg_upgrade old version to new version, new tablespace will be
created in same tablespace path with different tablespace version number.

So while taking backup need to skip the other data directory files.

ls opt/tbs1
PG_9.2_201204301
PG_9.3_201210071

Regards,

Hari babu.

From: Michael Paquier [mailto:michael.paquier@gmail.com]
Sent: Wednesday, November 28, 2012 12:43 PM
To: Hari Babu
Cc: PostgreSQL-development
Subject: Re: [HACKERS] pg_basebackup is taking backup of extra files inside
a tablespace directory

On Wed, Nov 28, 2012 at 3:55 PM, Hari Babu <haribabu.kommi@huawei.com>
wrote:

pg_basebackup is taking backup of extra files other than database related
files in side a TABLESPACE directory.

And why do you have files not related to your PG server inside a folder
dedicated to a PG server?

--
Michael Paquier
http://michael.otacoo.com

On Wed, Nov 28, 2012 at 1:55 AM, Hari Babu <haribabu.kommi@huawei.com> wrote:

I think backup should be done only files and folders present inside
'/opt/tblspc/PG_*' directory (TABLESPACE_VERSION_DIRECTORY).
Not all the files and folders in side '/opt/tblspc.' directory.

I think I agree. The current behavior would have made sense in older
releases of PG where we plopped down our stuff right inside the
tablespace directory, but now that everything is being shoved in a
subdirectory I don't see a reason to copy anything other than that
subdirectory. Of course it's probably bad style to have anything
that's not related to PG in there, but given that the whole point of
this change was to allow different PG versions to create tablespaces
on the same directory at the same time, we can hardly say that this is
a case that should never arise in real life.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Fri, Nov 30, 2012 at 8:30 PM, Robert Haas <robertmhaas@gmail.com> wrote:

On Wed, Nov 28, 2012 at 1:55 AM, Hari Babu <haribabu.kommi@huawei.com> wrote:

I think backup should be done only files and folders present inside
'/opt/tblspc/PG_*' directory (TABLESPACE_VERSION_DIRECTORY).
Not all the files and folders in side '/opt/tblspc.' directory.

I think I agree. The current behavior would have made sense in older
releases of PG where we plopped down our stuff right inside the
tablespace directory, but now that everything is being shoved in a
subdirectory I don't see a reason to copy anything other than that
subdirectory. Of course it's probably bad style to have anything
that's not related to PG in there, but given that the whole point of
this change was to allow different PG versions to create tablespaces
on the same directory at the same time, we can hardly say that this is
a case that should never arise in real life.

Makes sense, yeah. Of course, anything stuffed *inside* said subdir
will still be included, but that's violating that principle even more
:)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers