trouble with pg_upgrade 9.0 -> 9.1

Started by Groshev Andreyabout 13 years ago28 messages

greenx@yandex.ru

about 13 years ago

Hello!
I'm trying to update a database from version 9.0 to 9.1 by pg_upgrade.
The test is normal, but the actual conversion fails.
This is a bug from pg_upgrade?
I just saw this in the newsletter similar error with a note that it has been fixed in 9.1.2, but I already install 9.1.7.

My environment
centos 6.3
# uname -rm
2.6.32-279.14.1.el6.x86_64 x86_64

# rpm -qa |grep postgres
postgresql90-devel-9.0.11-1PGDG.rhel6.x86_64
postgresql91-9.1.7-1PGDG.rhel6.x86_64
postgresql90-9.0.11-1PGDG.rhel6.x86_64
postgresql90-server-9.0.11-1PGDG.rhel6.x86_64
postgresql91-libs-9.1.7-1PGDG.rhel6.x86_64
postgresql91-server-9.1.7-1PGDG.rhel6.x86_64
postgresql91-devel-9.1.7-1PGDG.rhel6.x86_64
postgresql90-libs-9.0.11-1PGDG.rhel6.x86_64
postgresql90-contrib-9.0.11-1PGDG.rhel6.x86_64
postgresql91-contrib-9.1.7-1PGDG.rhel6.x86_64

# time sudo -u postgres sh -c '/usr/pgsql-9.1/bin/pg_upgrade -b /usr/pgsql-9.0/bin/ -B /usr/pgsql-9.1/bin/ -d /var/lib/pgsql/9.0/data/ -D /var/lib/pgsql/9.1/data/ -vvv -c -l ./log 2>&1 | iconv -f cp1251 -t utf-8'
Running in verbose mode
.....
Running in verbose mode
Running in verbose mode
Performing Consistency Checks
-----------------------------
Checking current, bin, and data directories ok
Checking cluster versions ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" -o "-p 5432 -c autovacuum=off -c autovacuum_freeze_max_age=2000000000" start >> "./log" 2>&1
Checking database user is a superuser ok
Checking for prepared transactions ok
Checking for reg* system oid user data types ok
Checking for contrib/isn with bigint-passing mismatch ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" stop >> "./log" 2>&1
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" -o "-p 5432 -b" start >> "./log" 2>&1
Checking for presence of required libraries ok
Checking database user is a superuser ok
Checking for prepared transactions ok

*Clusters are compatible*
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" stop >> "./log" 2>&1

real 0m4.344s
user 0m0.029s
sys 0m0.051s

Checking current, bin, and data directories ok
Checking cluster versions ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" -o "-p 5432 -c autovacuum=off -c autovacuum_freeze_max_age=2000000000" start >> "./log
" 2>&1
Checking database user is a superuser ok
Checking for prepared transactions ok
Checking for reg* system oid user data types ok
Checking for contrib/isn with bigint-passing mismatch ok
Creating catalog dump "/usr/pgsql-9.1/bin/pg_dumpall" --port 5432 --username "postgres" --schema-only --binary-upgrade
-f "/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_all.sql"
ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" stop >> "./log" 2>&1
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" -o "-p 5432 -b" start >> "./log" 2>&1
Checking for presence of required libraries ok
Checking database user is a superuser ok
Checking for prepared transactions ok

| If pg_upgrade fails after this point, you must
| re-initdb the new cluster before continuing.
| You will also need to remove the ".old" suffix
| from /var/lib/pgsql/9.0/data/global/pg_control.old.

Performing Upgrade
------------------
Adding ".old" suffix to old global/pg_control ok
Analyzing all rows in the new cluster "/usr/pgsql-9.1/bin/vacuumdb" --port 5432 --username "postgres" --all --analyze >> "./log" 2>&1
ok
Freezing all rows on the new cluster "/usr/pgsql-9.1/bin/vacuumdb" --port 5432 --username "postgres" --all --freeze >> "./log" 2>&1
ok
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" stop >> "./log" 2>&1
Deleting new commit clogs ok
Copying old commit clogs to new server cp -Rf "/var/lib/pgsql/9.0/data/pg_clog" "/var/lib/pgsql/9.1/data/pg_clog"
ok
Setting next transaction id for new cluster "/usr/pgsql-9.1/bin/pg_resetxlog" -f -x 728832600 "/var/lib/pgsql/9.1/data" > /dev/null
ok
Resetting WAL archives "/usr/pgsql-9.1/bin/pg_resetxlog" -l 3,2349,11 "/var/lib/pgsql/9.1/data" >> "./log" 2>&1
ok
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" -o "-p 5432 -b" start >> "./log" 2>&1
Setting frozenxid counters in new cluster ok
Creating databases in the new cluster "/usr/pgsql-9.1/bin/psql" --set ON_ERROR_STOP=on --no-psqlrc --port 5432 --username "postgres" -f
"/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_globals.sql" --dbname template1 >> "./log"
ok
Adding support functions to new cluster ok
Restoring database schema to new cluster "/usr/pgsql-9.1/bin/psql" --set ON_ERROR_STOP=on --no-psqlrc --port 5432 --username "postgres" -f
"/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_db.sql" --dbname template1 >> "./log"
psql:/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_db.sql:153584: ПРЕДУПРЕЖДЕНИЕ: => как имя оператора считается устаревшим
DETAIL: Это имя может быть вовсе запрещено в будущих версиях PostgreSQL.
ok
Removing support functions from new cluster ok
Removing support functions from new cluster ok
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" stop >> "./log" 2>&1
Restoring user relation files

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумент
а$Документ
Failure, exiting

real 0m28.443s
user 0m4.868s
sys 0m0.921s

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#1)

Re: trouble with pg_upgrade 9.0 -> 9.1

On Mon, Dec 17, 2012 at 03:33:40PM +0400, Groshev Andrey wrote:

Hello!
I'm trying to update a database from version 9.0 to 9.1 by pg_upgrade.
The test is normal, but the actual conversion fails.
This is a bug from pg_upgrade?
I just saw this in the newsletter similar error with a note that it has been fixed in 9.1.2, but I already install 9.1.7.

Restoring database schema to new cluster "/usr/pgsql-9.1/bin/psql" --set ON_ERROR_STOP=on --no-psqlrc --port 5432 --username "postgres" -f
"/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_db.sql" --dbname template1 >> "./log"
psql:/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_db.sql:153584: ПРЕДУПРЕЖДЕНИЕ: => как имя оператора считается устаревшим
DETAIL: Это имя может быть вовсе запрещено в будущих версиях PostgreSQL.

The above is just a notice about =>, which is fine.

Removing support functions from new cluster ok
Removing support functions from new cluster ok
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" stop >> "./log" 2>&1
Restoring user relation files

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумент
а$Документ
Failure, exiting

I notice the first object is in the lob schema, but the second is lob
the the second is plob. That is a big dump (at least 153584 lines), so
is there anything unusual about this table? If you do a pg_dump
--schema-only on 'database' does the 'lob' table get dumped? There must
be something wrong, but I don't kno what.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#1)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

This is the first pg_upgrade mismatch report we have gotten about 9.1.
I have asked the reporter for details.

Is what is the full 9.1 version number?

---------------------------------------------------------------------------

On Mon, Dec 17, 2012 at 03:33:40PM +0400, Groshev Andrey wrote:

Hello!
I'm trying to update a database from version 9.0 to 9.1 by pg_upgrade.
The test is normal, but the actual conversion fails.
This is a bug from pg_upgrade?
I just saw this in the newsletter similar error with a note that it has been fixed in 9.1.2, but I already install 9.1.7.

My environment
centos 6.3
# uname -rm
2.6.32-279.14.1.el6.x86_64 x86_64

# rpm -qa |grep postgres
postgresql90-devel-9.0.11-1PGDG.rhel6.x86_64
postgresql91-9.1.7-1PGDG.rhel6.x86_64
postgresql90-9.0.11-1PGDG.rhel6.x86_64
postgresql90-server-9.0.11-1PGDG.rhel6.x86_64
postgresql91-libs-9.1.7-1PGDG.rhel6.x86_64
postgresql91-server-9.1.7-1PGDG.rhel6.x86_64
postgresql91-devel-9.1.7-1PGDG.rhel6.x86_64
postgresql90-libs-9.0.11-1PGDG.rhel6.x86_64
postgresql90-contrib-9.0.11-1PGDG.rhel6.x86_64
postgresql91-contrib-9.1.7-1PGDG.rhel6.x86_64

# time sudo -u postgres sh -c '/usr/pgsql-9.1/bin/pg_upgrade -b /usr/pgsql-9.0/bin/ -B /usr/pgsql-9.1/bin/ -d /var/lib/pgsql/9.0/data/ -D /var/lib/pgsql/9.1/data/ -vvv -c -l ./log 2>&1 | iconv -f cp1251 -t utf-8'
Running in verbose mode
.....
Running in verbose mode
Running in verbose mode
Performing Consistency Checks
-----------------------------
Checking current, bin, and data directories ok
Checking cluster versions ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" -o "-p 5432 -c autovacuum=off -c autovacuum_freeze_max_age=2000000000" start >> "./log" 2>&1
Checking database user is a superuser ok
Checking for prepared transactions ok
Checking for reg* system oid user data types ok
Checking for contrib/isn with bigint-passing mismatch ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" stop >> "./log" 2>&1
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" -o "-p 5432 -b" start >> "./log" 2>&1
Checking for presence of required libraries ok
Checking database user is a superuser ok
Checking for prepared transactions ok

*Clusters are compatible*
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" stop >> "./log" 2>&1

real 0m4.344s
user 0m0.029s
sys 0m0.051s

Checking current, bin, and data directories ok
Checking cluster versions ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" -o "-p 5432 -c autovacuum=off -c autovacuum_freeze_max_age=2000000000" start >> "./log
" 2>&1
Checking database user is a superuser ok
Checking for prepared transactions ok
Checking for reg* system oid user data types ok
Checking for contrib/isn with bigint-passing mismatch ok
Creating catalog dump "/usr/pgsql-9.1/bin/pg_dumpall" --port 5432 --username "postgres" --schema-only --binary-upgrade
-f "/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_all.sql"
ok
"/usr/pgsql-9.0/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.0/data" stop >> "./log" 2>&1
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" -o "-p 5432 -b" start >> "./log" 2>&1
Checking for presence of required libraries ok
Checking database user is a superuser ok
Checking for prepared transactions ok

| If pg_upgrade fails after this point, you must
| re-initdb the new cluster before continuing.
| You will also need to remove the ".old" suffix
| from /var/lib/pgsql/9.0/data/global/pg_control.old.

Performing Upgrade
------------------
Adding ".old" suffix to old global/pg_control ok
Analyzing all rows in the new cluster "/usr/pgsql-9.1/bin/vacuumdb" --port 5432 --username "postgres" --all --analyze >> "./log" 2>&1
ok
Freezing all rows on the new cluster "/usr/pgsql-9.1/bin/vacuumdb" --port 5432 --username "postgres" --all --freeze >> "./log" 2>&1
ok
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" stop >> "./log" 2>&1
Deleting new commit clogs ok
Copying old commit clogs to new server cp -Rf "/var/lib/pgsql/9.0/data/pg_clog" "/var/lib/pgsql/9.1/data/pg_clog"
ok
Setting next transaction id for new cluster "/usr/pgsql-9.1/bin/pg_resetxlog" -f -x 728832600 "/var/lib/pgsql/9.1/data" > /dev/null
ok
Resetting WAL archives "/usr/pgsql-9.1/bin/pg_resetxlog" -l 3,2349,11 "/var/lib/pgsql/9.1/data" >> "./log" 2>&1
ok
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" -o "-p 5432 -b" start >> "./log" 2>&1
Setting frozenxid counters in new cluster ok
Creating databases in the new cluster "/usr/pgsql-9.1/bin/psql" --set ON_ERROR_STOP=on --no-psqlrc --port 5432 --username "postgres" -f
"/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_globals.sql" --dbname template1 >> "./log"
ok
Adding support functions to new cluster ok
Restoring database schema to new cluster "/usr/pgsql-9.1/bin/psql" --set ON_ERROR_STOP=on --no-psqlrc --port 5432 --username "postgres" -f
"/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_db.sql" --dbname template1 >> "./log"
psql:/var/lib/pgsql/pg_upgrade/pg_upgrade_dump_db.sql:153584: ПРЕДУПРЕЖДЕНИЕ: => как имя оператора считается устаревшим
DETAIL: Это имя может быть вовсе запрещено в будущих версиях PostgreSQL.
ok
Removing support functions from new cluster ok
Removing support functions from new cluster ok
"/usr/pgsql-9.1/bin/pg_ctl" -w -l "./log" -D "/var/lib/pgsql/9.1/data" stop >> "./log" 2>&1
Restoring user relation files

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумент
а$Документ
Failure, exiting

real 0m28.443s
user 0m4.868s
sys 0m0.921s

--
Sent via pgsql-general mailing list (pgsql-general@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-general

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Bruce Momjian (#3)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

18.12.2012, 05:22, "Bruce Momjian" <bruce@momjian.us>:

This is the first pg_upgrade mismatch report we have gotten about 9.1.
I have asked the reporter for details.

Is what is the full 9.1 version number?

---------------------------------------------------------------------------

# rpm -qa |grep postgres
postgresql90-devel-9.0.11-1PGDG.rhel6.x86_64
postgresql91-9.1.7-1PGDG.rhel6.x86_64
postgresql90-9.0.11-1PGDG.rhel6.x86_64
postgresql90-server-9.0.11-1PGDG.rhel6.x86_64
postgresql91-libs-9.1.7-1PGDG.rhel6.x86_64
postgresql91-server-9.1.7-1PGDG.rhel6.x86_64
postgresql91-devel-9.1.7-1PGDG.rhel6.x86_64
postgresql90-libs-9.0.11-1PGDG.rhel6.x86_64
postgresql90-contrib-9.0.11-1PGDG.rhel6.x86_64
postgresql91-contrib-9.1.7-1PGDG.rhel6.x86_64

Full version ? It is not full postgresql91-9.1.7-1PGDG.rhel6.x86_64 or I do not understand something?
I installed latest postgresql from the repository http://yum.pgrpms.org

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#4)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Tue, Dec 18, 2012 at 09:28:00AM +0400, Groshev Andrey wrote:

18.12.2012, 05:22, "Bruce Momjian" <bruce@momjian.us>:

This is the first pg_upgrade mismatch report we have gotten about 9.1.
I have asked the reporter for details.

Is what is the full 9.1 version number?

---------------------------------------------------------------------------

ï¿½# rpm -qa |grep postgres
ï¿½postgresql90-devel-9.0.11-1PGDG.rhel6.x86_64
ï¿½postgresql91-9.1.7-1PGDG.rhel6.x86_64
ï¿½postgresql90-9.0.11-1PGDG.rhel6.x86_64
ï¿½postgresql90-server-9.0.11-1PGDG.rhel6.x86_64
ï¿½postgresql91-libs-9.1.7-1PGDG.rhel6.x86_64
ï¿½postgresql91-server-9.1.7-1PGDG.rhel6.x86_64
ï¿½postgresql91-devel-9.1.7-1PGDG.rhel6.x86_64
ï¿½postgresql90-libs-9.0.11-1PGDG.rhel6.x86_64
ï¿½postgresql90-contrib-9.0.11-1PGDG.rhel6.x86_64
ï¿½postgresql91-contrib-9.1.7-1PGDG.rhel6.x86_64

Full version ? It is not full postgresql91-9.1.7-1PGDG.rhel6.x86_64 or I do not understand something?
I installed latest postgresql from the repository http://yum.pgrpms.org

Oops, I see that now, sorry. I wanted to make sure you were on the most
recent 9.1 version, and you are.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Bruce Momjian (#3)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Mon, Dec 17, 2012 at 09:21:59PM -0500, Bruce Momjian wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумент
а$Документ
Failure, exiting

I am now confused over the error message above. This is the code that
is generating the error:

/*
* TOAST table names initially match the heap pg_class oid.
* In pre-8.4, TOAST table names change during CLUSTER; in pre-9.0,
* TOAST table names change during ALTER TABLE ALTER COLUMN SET TYPE.
* In >= 9.0, TOAST relation names always use heap table oids, hence
* we cannot check relation names when upgrading from pre-9.0.
* Clusters upgraded to 9.0 will get matching TOAST names.
*/
if (strcmp(old_rel->nspname, new_rel->nspname) != 0 ||
((GET_MAJOR_VERSION(old_cluster.major_version) >= 900 ||
strcmp(old_rel->nspname, "pg_toast") != 0) &&
strcmp(old_rel->relname, new_rel->relname) != 0))
pg_log(PG_FATAL, "Mismatch of relation names: database \"%s\", "
"old rel %s.%s, new rel %s.%s\n",
old_db->db_name, old_rel->nspname, old_rel->relname,
new_rel->nspname, new_rel->relname);

Looking at the Russian, I see 'old rel' public.lob.* and 'new rel'
public.plob.*. I assume the database is called 'database', and the
schema is called 'public', but what is 'lob' and 'plob'? If those are
tables or indexes, what is after the period? Do you have periods
embedded in the table/index names? That is certainly possible, but not
common, e.g.:

test=> create table "test.x" (y int);
CREATE TABLE

Is the schema called "public.lob"? I expected to see schema.objname.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Bruce Momjian (#6)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

later in the log pg_dump, I found the definition of "new rel"

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ" PRIMARY KEY ("@Файл", "Страница");

18.12.2012, 19:38, "Bruce Momjian" <bruce@momjian.us>:

On Mon, Dec 17, 2012 at 09:21:59PM -0500, Bruce Momjian wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
Failure, exiting

I am now confused over the error message above. This is the code that
is generating the error:

        /*
         * TOAST table names initially match the heap pg_class oid.
         * In pre-8.4, TOAST table names change during CLUSTER; in pre-9.0,
         * TOAST table names change during ALTER TABLE ALTER COLUMN SET TYPE.
         * In >= 9.0, TOAST relation names always use heap table oids, hence
         * we cannot check relation names when upgrading from pre-9.0.
         * Clusters upgraded to 9.0 will get matching TOAST names.
         */
        if (strcmp(old_rel->nspname, new_rel->nspname) != 0 ||
            ((GET_MAJOR_VERSION(old_cluster.major_version) >= 900 ||
              strcmp(old_rel->nspname, "pg_toast") != 0) &&
             strcmp(old_rel->relname, new_rel->relname) != 0))
            pg_log(PG_FATAL, "Mismatch of relation names: database \"%s\", "
                   "old rel %s.%s, new rel %s.%s\n",
                   old_db->db_name, old_rel->nspname, old_rel->relname,
                   new_rel->nspname, new_rel->relname);

Looking at the Russian, I see 'old rel' public.lob.* and 'new rel'
public.plob.*. I assume the database is called 'database', and the
schema is called 'public', but what is 'lob' and 'plob'? If those are
tables or indexes, what is after the period? Do you have periods
embedded in the table/index names? That is certainly possible, but not
common, e.g.:

        test=> create table "test.x" (y int);
        CREATE TABLE

Is the schema called "public.lob"? I expected to see schema.objname.

--
  Bruce Momjian <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#7)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Tue, Dec 18, 2012 at 09:34:53PM +0400, Groshev Andrey wrote:

later in the log pg_dump, I found the definition of "new rel"

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ" PRIMARY KEY ("@Файл", "Страница");

Can you post the full definition of the table on this public email list?
Also, why did the error think this was in the public schema? Any idea?

---------------------------------------------------------------------------

18.12.2012, 19:38, "Bruce Momjian" <bruce@momjian.us>:

On Mon, Dec 17, 2012 at 09:21:59PM -0500, Bruce Momjian wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
Failure, exiting

I am now confused over the error message above. This is the code that
is generating the error:

        /*
         * TOAST table names initially match the heap pg_class oid.
         * In pre-8.4, TOAST table names change during CLUSTER; in pre-9.0,
         * TOAST table names change during ALTER TABLE ALTER COLUMN SET TYPE.
         * In >= 9.0, TOAST relation names always use heap table oids, hence
         * we cannot check relation names when upgrading from pre-9.0.
         * Clusters upgraded to 9.0 will get matching TOAST names.
         */
        if (strcmp(old_rel->nspname, new_rel->nspname) != 0 ||
            ((GET_MAJOR_VERSION(old_cluster.major_version) >= 900 ||
              strcmp(old_rel->nspname, "pg_toast") != 0) &&
             strcmp(old_rel->relname, new_rel->relname) != 0))
            pg_log(PG_FATAL, "Mismatch of relation names: database \"%s\", "
                   "old rel %s.%s, new rel %s.%s\n",
                   old_db->db_name, old_rel->nspname, old_rel->relname,
                   new_rel->nspname, new_rel->relname);

Looking at the Russian, I see 'old rel' public.lob.* and 'new rel'
public.plob.*. I assume the database is called 'database', and the
schema is called 'public', but what is 'lob' and 'plob'? If those are
tables or indexes, what is after the period? Do you have periods
embedded in the table/index names? That is certainly possible, but not
common, e.g.:

        test=> create table "test.x" (y int);
        CREATE TABLE

Is the schema called "public.lob"? I expected to see schema.objname.

--
  Bruce Momjian <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Bruce Momjian (#8)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

Can you post the full definition of the table on this public email list?
Also, why did the error think this was in the public schema? Any idea?

---------------------------------------------------------------------------

18.12.2012, 19:38, "Bruce Momjian" <bruce@momjian.us>:

On Mon, Dec 17, 2012 at 09:21:59PM -0500, Bruce Momjian wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
Failure, exiting

...... snip ....

It's all what I'm found about this table.

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: TABLE; Schema: public; Owner: postgres; Tablespace:
--

CREATE TABLE "lob.ВерсияВнешнегоДокумента$Документ" (
"@Файл" integer NOT NULL,
"Страница" integer NOT NULL,
"Данные" bytea
);

ALTER TABLE public."lob.ВерсияВнешнегоДокумента$Документ" OWNER TO postgres;

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

--
-- Name: rlob.ВерсияВнешнегоДокумента$Документ-@Файл; Type: FK CONSTRAINT; Schema: public; Owner: postgres
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "rlob.ВерсияВнешнегоДокумента$Документ-@Файл"
FOREIGN KEY ("@Файл")
REFERENCES "ВерсияВнешнегоДокумента$Документ"("@Файл")
ON UPDATE CASCADE ON DELETE CASCADE DEFERRABLE;

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: ACL; Schema: public; Owner: postgres
--

REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM PUBLIC;
REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM postgres;
GRANT ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO postgres;
GRANT SELECT ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO view_user;

There is another table "ВерсияВнешнегоДокумента$Документ" (without ^lob.)
It is referenced by a foreign key ("rlob.ВерсияВнешнегоДокумента$Документ-@Файл")
But as I understand it, the problem with the primary key.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#10

Kevin Grittner

kgrittn@mail.com

about 13 years ago

In reply to: Groshev Andrey (#9)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

Groshev Andrey wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ

There is a limit on identifiers of 63 *bytes* (not characters)
after which the name is truncated. In UTF8 encoding, the underscore
would be in the 64th position.

-Kevin

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Import Notes

Resolved by subject fallback

#11

Tom Lane

tgl@sss.pgh.pa.us

about 13 years ago

In reply to: Kevin Grittner (#10)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

"Kevin Grittner" <kgrittn@mail.com> writes:

Groshev Andrey wrote:
Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ

There is a limit on identifiers of 63 *bytes* (not characters)
after which the name is truncated. In UTF8 encoding, the underscore
would be in the 64th position.

Hmm ... that is a really good point, except that you are not counting
the "lob." or "plob." part, which we previously saw is part of the
relation name not the schema name. Counting that part, it's already
overlimit, which seems to be proof that Andrey isn't using UTF8 but
some single-byte encoding.

Anyway, that would only explain the issue if pg_upgrade were somehow
changing the database encoding, which surely we'd have heard complaints
about already? Or maybe this has something to do with pg_upgrade's
client-side encoding rather than the server encoding...

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#12

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#9)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Wed, Dec 19, 2012 at 01:51:08PM +0400, Groshev Andrey wrote:

Can you post the full definition of the table on this public email list?
Also, why did the error think this was in the public schema? Any idea?

---------------------------------------------------------------------------

18.12.2012, 19:38, "Bruce Momjian" <bruce@momjian.us>:

On Mon, Dec 17, 2012 at 09:21:59PM -0500, Bruce Momjian wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
Failure, exiting

...... snip ....

It's all what I'm found about this table.

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: TABLE; Schema: public; Owner: postgres; Tablespace:
--

CREATE TABLE "lob.ВерсияВнешнегоДокумента$Документ" (
"@Файл" integer NOT NULL,
"Страница" integer NOT NULL,
"Данные" bytea
);

ALTER TABLE public."lob.ВерсияВнешнегоДокумента$Документ" OWNER TO postgres;

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ"
PRIMARY KEY ("@Файл", "Страница");

--
-- Name: rlob.ВерсияВнешнегоДокумента$Документ-@Файл; Type: FK CONSTRAINT; Schema: public; Owner: postgres
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "rlob.ВерсияВнешнегоДокумента$Документ-@Файл"
FOREIGN KEY ("@Файл")
REFERENCES "ВерсияВнешнегоДокумента$Документ"("@Файл")
ON UPDATE CASCADE ON DELETE CASCADE DEFERRABLE;

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: ACL; Schema: public; Owner: postgres
--

REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM PUBLIC;
REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM postgres;
GRANT ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO postgres;
GRANT SELECT ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO view_user;

There is another table "ВерсияВнешнегоДокумента$Документ" (without ^lob.)
It is referenced by a foreign key ("rlob.ВерсияВнешнегоДокумента$Документ-@Файл")
But as I understand it, the problem with the primary key.

[ Sorry I have not been replying promptly. I have been sick with the
flue for the past four days, and while I read the email promptly, my
brain isn't sharp enough to send email out for everyone to read. I am
better today so hopefully I will be 100% soon. ]

OK, this tells me that the period is in the table name:

-- Name:
lob.ВерсияВнешнегоДокумента$Документ;
Type: TABLE; Schema: public; Owner: postgres; Tablespace:

I needed to check that the period wasn't a symptom of a bug.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#13

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Kevin Grittner (#10)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Wed, Dec 19, 2012 at 12:56:05PM -0500, Kevin Grittner wrote:

Groshev Andrey wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ

There is a limit on identifiers of 63 *bytes* (not characters)
after which the name is truncated. In UTF8 encoding, the underscore
would be in the 64th position.

OK, Kevin is certainly pointing out a bug in the pg_upgrade code, though
I am unclear how it would exhibit the mismatch error reported.

pg_upgrade uses NAMEDATALEN for database, schema, and relation name
storage lengths. While NAMEDATALEN works fine in the backend, it is
possible that a frontend client, like pg_upgrade, could retrieve a name
in the client encoding whose length exceeds NAMEDATALEN if the client
encoding did not match the database encoding (or is it the cluster
encoding for system tables). This would cause truncation of these
values. The truncation would not cause crashes, but might cause
failures by not being able to connect to overly-long database names, and
it weakens the checking of relation/schema names --- the same check that
is reported above.

(I believe initdb.c also erroneously uses NAMEDATALEN.)

For this to be the cause of the users report, there would have to be
different truncation behavior for old and new clusters when you restore
the dump. Did we change how this somehow between 9.0 and 9.1?

In summary, we are getting closer to a fix, but we are not there yet. I
can supply a patch that removes the use of NAMEDATALEN and you can test
that, but again, I don't see how that can cause this.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#14

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#9)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Wed, Dec 19, 2012 at 01:51:08PM +0400, Groshev Andrey wrote:

Can you post the full definition of the table on this public email list?
Also, why did the error think this was in the public schema? Any idea?

---------------------------------------------------------------------------

18.12.2012, 19:38, "Bruce Momjian" <bruce@momjian.us>:

On Mon, Dec 17, 2012 at 09:21:59PM -0500, Bruce Momjian wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
Failure, exiting

...... snip ....

It's all what I'm found about this table.

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: TABLE; Schema: public; Owner: postgres; Tablespace:
--

CREATE TABLE "lob.ВерсияВнешнегоДокумента$Документ" (
"@Файл" integer NOT NULL,
"Страница" integer NOT NULL,
"Данные" bytea
);

ALTER TABLE public."lob.ВерсияВнешнегоДокумента$Документ" OWNER TO postgres;

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ"
PRIMARY KEY ("@Файл", "Страница");

--
-- Name: rlob.ВерсияВнешнегоДокумента$Документ-@Файл; Type: FK CONSTRAINT; Schema: public; Owner: postgres
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "rlob.ВерсияВнешнегоДокумента$Документ-@Файл"
FOREIGN KEY ("@Файл")
REFERENCES "ВерсияВнешнегоДокумента$Документ"("@Файл")
ON UPDATE CASCADE ON DELETE CASCADE DEFERRABLE;

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: ACL; Schema: public; Owner: postgres
--

REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM PUBLIC;
REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM postgres;
GRANT ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO postgres;
GRANT SELECT ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO view_user;

There is another table "ВерсияВнешнегоДокумента$Документ" (without ^lob.)
It is referenced by a foreign key ("rlob.ВерсияВнешнегоДокумента$Документ-@Файл")
But as I understand it, the problem with the primary key.

Does the old database have a table with prefix "plob.", called
plob.ВерсияВнешнегоДокумента$Документ?

If not, if you do pg_dumpall --schema-only --binary-upgrade, is there a
table with that name mentioned?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#15

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Bruce Momjian (#14)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Wed, Dec 19, 2012 at 10:35:11PM -0500, Bruce Momjian wrote:

There is another table "ВерсияВнешнегоДокумента$Документ" (without ^lob.)
It is referenced by a foreign key ("rlob.ВерсияВнешнегоДокумента$Документ-@Файл")
But as I understand it, the problem with the primary key.

Does the old database have a table with prefix "plob.", called
plob.ВерсияВнешнегоДокумента$Документ?

If not, if you do pg_dumpall --schema-only --binary-upgrade, is there a
table with that name mentioned?

Also, when you say "rlob" above, is the 'r' a Latin letter sound that
would look like a Russian 'p' in the error message? (In Cyrillic, a
Latin-looking p sounds like Latin-sounding r.)

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#16

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Bruce Momjian (#14)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

No, old database not use table plob......
only primary key

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

-- For binary upgrade, must preserve pg_class oids
SELECT binary_upgrade.set_next_index_pg_class_oid('786665369'::pg_catalog.oid);

20.12.2012, 06:35, "Bruce Momjian" <bruce@momjian.us>:

On Wed, Dec 19, 2012 at 01:51:08PM +0400, Groshev Andrey wrote:

Can you post the full definition of the table on this public email list?
Also, why did the error think this was in the public schema? Any idea?

---------------------------------------------------------------------------

  18.12.2012, 19:38, "Bruce Momjian" <bruce@momjian.us>:

  On Mon, Dec 17, 2012 at 09:21:59PM -0500, Bruce Momjian wrote:

   Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
   Failure, exiting

...... snip ....

It's all what I'm found about this table.

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: TABLE; Schema: public; Owner: postgres; Tablespace:
--

CREATE TABLE "lob.ВерсияВнешнегоДокумента$Документ" (
     "@Файл" integer NOT NULL,
     "Страница" integer NOT NULL,
     "Данные" bytea
);

ALTER TABLE public."lob.ВерсияВнешнегоДокумента$Документ" OWNER TO postgres;

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
     ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ"
         PRIMARY KEY ("@Файл", "Страница");

--
-- Name: rlob.ВерсияВнешнегоДокумента$Документ-@Файл; Type: FK CONSTRAINT; Schema: public; Owner: postgres
--

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
     ADD CONSTRAINT "rlob.ВерсияВнешнегоДокумента$Документ-@Файл"
         FOREIGN KEY ("@Файл")
         REFERENCES "ВерсияВнешнегоДокумента$Документ"("@Файл")
         ON UPDATE CASCADE ON DELETE CASCADE DEFERRABLE;

--
-- Name: lob.ВерсияВнешнегоДокумента$Документ; Type: ACL; Schema: public; Owner: postgres
--

REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM PUBLIC;
REVOKE ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" FROM postgres;
GRANT ALL ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO postgres;
GRANT SELECT ON TABLE "lob.ВерсияВнешнегоДокумента$Документ" TO view_user;

There is another table "ВерсияВнешнегоДокумента$Документ" (without ^lob.)
It is referenced by a foreign key ("rlob.ВерсияВнешнегоДокумента$Документ-@Файл")
But as I understand it, the problem with the primary key.

Does the old database have a table with prefix "plob.", called
plob.ВерсияВнешнегоДокумента$Документ?

If not, if you do pg_dumpall --schema-only --binary-upgrade, is there a
table with that name mentioned?

--
  Bruce Momjian <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#17

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Bruce Momjian (#15)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

No, people can confuse writing, but it makes a computer.
Unfortunately, I have not found developer this database, but I understand the logic was:
plob - primary key (lob ~ BLOB)
rlob - reference key (lob ~ BLOB)
Maybe if I describe the task, this part of the database, the problem is clear.
We need to maintain external documents (binary scans, per page).
Therefore, there is a table to store the titles and a table to store binary data.
To make it more comfortable I replaced all Russian words translated words.

This a table for headers store.

-- Table: "VersionOfTheExternalDocument$Document"
-- DROP TABLE "VersionOfTheExternalDocument$Document";

CREATE TABLE "VersionOfTheExternalDocument$Document"
(
"@File" integer NOT NULL DEFAULT nextval((pg_get_serial_sequence('"public"."VersionOfTheExternalDocument$Document"'::text, '@File'::text))::regclass),
"GUID" uuid,
"DataTime" timestamp without time zone DEFAULT (now())::timestamp without time zone,
"Name" character varying,
"Size" integer,
CONSTRAINT "VersionOfTheExternalDocument$Document_pkey" PRIMARY KEY ("@File")
)
WITH (
OIDS=FALSE
);
ALTER TABLE "VersionOfTheExternalDocument$Document"
OWNER TO postgres;
GRANT ALL ON TABLE "VersionOfTheExternalDocument$Document" TO postgres;
GRANT SELECT ON TABLE "VersionOfTheExternalDocument$Document" TO view_user;

-- Index: "iVersionOfTheExternalDocument$Document-blb_header"
-- DROP INDEX "iVersionOfTheExternalDocument$Document-blb_header";

CREATE INDEX "iVersionOfTheExternalDocument$Document-blb_header"
ON "VersionOfTheExternalDocument$Document"
USING btree
("GUID", "@Файл", "ДатаВремя")
WHERE "GUID" IS NOT NULL;
---------------------------------------------------------------
And this for data.

-- Table: "lob.VersionOfTheExternalDocument$Document"
-- DROP TABLE "lob.VersionOfTheExternalDocument$Document";
CREATE TABLE "lob.VersionOfTheExternalDocument$Document"
(
"@File" integer NOT NULL,
"Page" integer NOT NULL,
"Data" bytea,
CONSTRAINT "lob.VersionOfTheExternalDocument$Document_pkey" PRIMARY KEY ("@File", "Page"),
CONSTRAINT "rlob.VersionOfTheExternalDocument$Document-@File" FOREIGN KEY ("@File")
REFERENCES "VersionOfTheExternalDocument$Document" ("@File") MATCH SIMPLE
ON UPDATE CASCADE ON DELETE CASCADE DEFERRABLE INITIALLY IMMEDIATE
)
WITH (
OIDS=FALSE
);
ALTER TABLE "lob.VersionOfTheExternalDocument$Document"
OWNER TO postgres;
GRANT ALL ON TABLE "lob.VersionOfTheExternalDocument$Document" TO postgres;
GRANT SELECT ON TABLE "lob.VersionOfTheExternalDocument$Document" TO view_user;

20.12.2012, 07:12, "Bruce Momjian" <bruce@momjian.us>:

On Wed, Dec 19, 2012 at 10:35:11PM -0500, Bruce Momjian wrote:

There is another table "ВерсияВнешнегоДокумента$Документ" (without ^lob.)
It is referenced by a foreign key ("rlob.ВерсияВнешнегоДокумента$Документ-@Файл")
But as I understand it, the problem with the primary key.

Does the old database have a table with prefix "plob.", called
plob.ВерсияВнешнегоДокумента$Документ?

If not, if you do pg_dumpall --schema-only --binary-upgrade, is there a
table with that name mentioned?

Also, when you say "rlob" above, is the 'r' a Latin letter sound that
would look like a Russian 'p' in the error message? (In Cyrillic, a
Latin-looking p sounds like Latin-sounding r.)

--
  Bruce Momjian <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#18

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Tom Lane (#11)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

I'm initialize data dir with use ru_RU.UTF8, but this databse use CP1251, ie one byte per character.

19.12.2012, 21:47, "Tom Lane" <tgl@sss.pgh.pa.us>:

"Kevin Grittner" <kgrittn@mail.com> writes:

Groshev Andrey wrote:
Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
There is a limit on identifiers of 63 *bytes* (not characters)
after which the name is truncated. In UTF8 encoding, the underscore
would be in the 64th position.

Hmm ... that is a really good point, except that you are not counting
the "lob." or "plob." part, which we previously saw is part of the
relation name not the schema name. Counting that part, it's already
overlimit, which seems to be proof that Andrey isn't using UTF8 but
some single-byte encoding.

Anyway, that would only explain the issue if pg_upgrade were somehow
changing the database encoding, which surely we'd have heard complaints
about already? Or maybe this has something to do with pg_upgrade's
client-side encoding rather than the server encoding...

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#19

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#18)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

19.12.2012, 21:47, "Tom Lane" <tgl@sss.pgh.pa.us>:

"Kevin Grittner" <kgrittn@mail.com> writes:

Groshev Andrey wrote:
Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
There is a limit on identifiers of 63 *bytes* (not characters)
after which the name is truncated. In UTF8 encoding, the underscore
would be in the 64th position.

Hmm ... that is a really good point, except that you are not counting
the "lob." or "plob." part, which we previously saw is part of the
relation name not the schema name. Counting that part, it's already
overlimit, which seems to be proof that Andrey isn't using UTF8 but
some single-byte encoding.

Anyway, that would only explain the issue if pg_upgrade were somehow
changing the database encoding, which surely we'd have heard complaints
about already? Or maybe this has something to do with pg_upgrade's
client-side encoding rather than the server encoding...

regards, tom lane

I'm initialize data dir with use ru_RU.UTF8, but this databse use CP1251, ie one byte per character.

Agreed. This is a complicated report because the identifiers:

* contain periods
* are long
* are in cyrillic
* don't use utf8
* are very similar

However, I just can't see how these could be causing the problem.
Looking at the 9.1 pg_upgrade code, we already know that there are the
same number of relations in old and new clusters, so everything must be
being restored. And there is a lob.* and a plob.* that exist. The C
code is also saying that the pg_class.oid of the lob.* in the old
database is the same as the plob.* in the new database. That question
is how is that happening.

Can you email me privately the output of:

pg_dump --schema-only --binary-upgrade database

Thanks. If you want to debug this yourself, check these lines in the
pg_dump output:

-- For binary upgrade, must preserve pg_class oids
SELECT binary_upgrade.set_next_index_pg_class_oid('786665369'::pg_catalog.oid);

See that 786665369? That is the pg_class.oid of the plob in the old
cluster, and hopefully the new one. Find where the lob*_pkey index is
created and get that oid. Those should match the same names of the
pg_class.oid in the old and new clusters, but it seems the new plob* oid
is matching the lob oid in the old cluster.

Also, pg_upgrade sorts everything by oid, so it can't be that somehow
pg_upgrade isn't ordering things right, and because we already passed
the oid check, we already know they have the same oid, but different
names.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#20

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#16)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Thu, Dec 20, 2012 at 08:55:16AM +0400, Groshev Andrey wrote:

No, old database not use table plob......
only primary key

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

-- For binary upgrade, must preserve pg_class oids
SELECT binary_upgrade.set_next_index_pg_class_oid('786665369'::pg_catalog.oid);

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ" PRIMARY KEY ("@Файл", "Страница");

OK, now I know what is happening, though I can't figure out yet how you
got there. Basically, when you create a primary key, the name you
supply goes into two places, pg_class, for the index, and pg_constraint
for the constraint name.

What is happening is that you have a "pg_class" entry called lob.*_pkey
and a "pg_constraint" entry with plob.*. You can verify it yourself by
running queries on the system tables. Let me know if you want me to
show you the queries.

pg_dump dumps the pg_constraint name when recreating the index, while
pg_upgrade uses the pg_class name. When you restore the database into
the new cluster, the pg_class index name is lost and the new primary key
gets identical pg_class and pg_constraint names.

I tried to recreate the problem with these commands:

test=> create table test (x int primary key);
NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "test_pkey" for table "test"
CREATE TABLE
test=> alter index "test_pkey" rename to ptest;
ALTER INDEX
test=> select * from pg_constraint where conname = 'ptest';
conname | connamespace |
---------+--------------+-
ptest | 2200 |
(1 row)

test=> select * from pg_class where relname = 'ptest';
relname | relnamespace |
---------+--------------+-
ptest | 2200 |
(1 row)

As you can see, ALTER INDEX renamed both the pg_constraint and pg_class
names. Is it possible someone manually updated the system table to
rename this primary key? That would cause this error message. The fix
is to just to make sure they match.

Does pg_upgrade need to be modified to handle this case? Are there
legitimate cases where they will not match and the index name will not
be preserved though a dump/restore? This seems safe:

test=> alter table test add constraint zz primary key using index ii;
NOTICE: ALTER TABLE / ADD CONSTRAINT USING INDEX will rename index "ii" to "zz"
ALTER TABLE

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#21

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Bruce Momjian (#20)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

20.12.2012, 13:00, "Bruce Momjian" <bruce@momjian.us>:

On Thu, Dec 20, 2012 at 08:55:16AM +0400, Groshev Andrey wrote:

No, old database not use table plob......
only primary key

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

-- For binary upgrade, must preserve pg_class oids
SELECT binary_upgrade.set_next_index_pg_class_oid('786665369'::pg_catalog.oid);

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ" PRIMARY KEY ("@Файл", "Страница");

OK, now I know what is happening, though I can't figure out yet how you
got there. Basically, when you create a primary key, the name you
supply goes into two places, pg_class, for the index, and pg_constraint
for the constraint name.

What is happening is that you have a "pg_class" entry called lob.*_pkey
and a "pg_constraint" entry with plob.*. You can verify it yourself by
running queries on the system tables. Let me know if you want me to
show you the queries.

pg_dump dumps the pg_constraint name when recreating the index, while
pg_upgrade uses the pg_class name. When you restore the database into
the new cluster, the pg_class index name is lost and the new primary key
gets identical pg_class and pg_constraint names.

I have already begun to approach this to the idea, when noticed that pgAdmin describes this index through "_pkey", and through the pg_dump "plob.".
But your letter immediately pointed me to the end of my research :)

I tried to recreate the problem with these commands:

        test=> create table test (x int primary key);
        NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "test_pkey" for table "test"
        CREATE TABLE
        test=> alter index "test_pkey" rename to ptest;
        ALTER INDEX
        test=> select * from pg_constraint where conname = 'ptest';
         conname | connamespace |
        ---------+--------------+-
         ptest   |         2200 |
        (1 row)

        test=> select * from pg_class where relname = 'ptest';
         relname | relnamespace |
        ---------+--------------+-
         ptest   |         2200 |
        (1 row)

As you can see, ALTER INDEX renamed both the pg_constraint and pg_class
names. Is it possible someone manually updated the system table to
rename this primary key? That would cause this error message. The fix
is to just to make sure they match.

Does pg_upgrade need to be modified to handle this case?

Unfortunately, my knowledge is not enough to talk about it.
I do not know what comes first in this case: pg_class, pg_constraint or pg_catalog.index or pg_catalog.pg_indexes.
Incidentally, in the last of:

#
select schemaname,tablename,indexname,tablespace from pg_catalog.pg_indexes where indexname like '%ВерсияВнешнегоДокумента$Документ%';
schemaname | tablename | indexname | tablespace
------------+--------------------------------------+----------------------------------------------+------------
public | lob.ВерсияВнешнегоДокумента$Документ | lob.ВерсияВнешнегоДокумента$Документ_pkey |
public | ВерсияВнешнегоДокумента$Документ | ВерсияВнешнегоДокумента$Документ_pkey |
public | ВерсияВнешнегоДокумента$Документ | iВерсияВнешнегоДокумента$Документ-blb_header |
(3 rows)

If pg_upgrade said that the old database is not in a very good condition, I would look for a problem in the database, and not something else.

Are there legitimate cases where they will not match and the index name will not
be preserved though a dump/restore? This seems safe:

        test=> alter table test add constraint zz primary key using index ii;
        NOTICE: ALTER TABLE / ADD CONSTRAINT USING INDEX will rename index "ii" to "zz"
        ALTER TABLE

--
  Bruce Momjian <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#22

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#21)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Thu, Dec 20, 2012 at 03:19:17PM +0400, Groshev Andrey wrote:

20.12.2012, 13:00, "Bruce Momjian" <bruce@momjian.us>:

On Thu, Dec 20, 2012 at 08:55:16AM +0400, Groshev Andrey wrote:

No, old database not use table plob......
only primary key

--
-- Name: plob.ВерсияВнешнегоДокумента$Документ; Type: CONSTRAINT; Schema: public; Owner: postgres; Tablespace:
--

-- For binary upgrade, must preserve pg_class oids
SELECT binary_upgrade.set_next_index_pg_class_oid('786665369'::pg_catalog.oid);

ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ" PRIMARY KEY ("@Файл", "Страница");

OK, now I know what is happening, though I can't figure out yet how you
got there. Basically, when you create a primary key, the name you
supply goes into two places, pg_class, for the index, and pg_constraint
for the constraint name.

What is happening is that you have a "pg_class" entry called lob.*_pkey
and a "pg_constraint" entry with plob.*. You can verify it yourself by
running queries on the system tables. Let me know if you want me to
show you the queries.

pg_dump dumps the pg_constraint name when recreating the index, while
pg_upgrade uses the pg_class name. When you restore the database into
the new cluster, the pg_class index name is lost and the new primary key
gets identical pg_class and pg_constraint names.

I have already begun to approach this to the idea, when noticed that pgAdmin describes this index through "_pkey", and through the pg_dump "plob.".
But your letter immediately pointed me to the end of my research :)

Good.

I tried to recreate the problem with these commands:

        test=> create table test (x int primary key);
        NOTICE: CREATE TABLE / PRIMARY KEY will create implicit index "test_pkey" for table "test"
        CREATE TABLE
        test=> alter index "test_pkey" rename to ptest;
        ALTER INDEX
        test=> select * from pg_constraint where conname = 'ptest';
         conname | connamespace |
        ---------+--------------+-
         ptest   |         2200 |
        (1 row)

        test=> select * from pg_class where relname = 'ptest';
         relname | relnamespace |
        ---------+--------------+-
         ptest   |         2200 |
        (1 row)

As you can see, ALTER INDEX renamed both the pg_constraint and pg_class
names. Is it possible someone manually updated the system table to
rename this primary key? That would cause this error message. The fix
is to just to make sure they match.

Does pg_upgrade need to be modified to handle this case?

Unfortunately, my knowledge is not enough to talk about it.
I do not know what comes first in this case: pg_class, pg_constraint or pg_catalog.index or pg_catalog.pg_indexes.
Incidentally, in the last of:

#
select schemaname,tablename,indexname,tablespace from pg_catalog.pg_indexes where indexname like '%ВерсияВнешнегоДокумента$Документ%';
schemaname | tablename | indexname | tablespace
------------+--------------------------------------+----------------------------------------------+------------
public | lob.ВерсияВнешнегоДокумента$Документ | lob.ВерсияВнешнегоДокумента$Документ_pkey |
public | ВерсияВнешнегоДокумента$Документ | ВерсияВнешнегоДокумента$Документ_pkey |
public | ВерсияВнешнегоДокумента$Документ | iВерсияВнешнегоДокумента$Документ-blb_header |
(3 rows)

If pg_upgrade said that the old database is not in a very good condition, I would look for a problem in the database, and not something else.

pg_catalog.pg_indexes is a view. You can to modify pg_class to match
the pg_constraint name. You might be able to just rename the index in
Pgadmin to match.

Perhaps PGAdmin allowed this mismatch to happen?

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#23

Groshev Andrey

greenx@yandex.ru

about 13 years ago

In reply to: Bruce Momjian (#19)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

20.12.2012, 11:43, "Bruce Momjian" <bruce@momjian.us>:

19.12.2012, 21:47, "Tom Lane" <tgl@sss.pgh.pa.us>:

"Kevin Grittner" <kgrittn@mail.com> writes:

  Groshev Andrey wrote:
    Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ
  There is a limit on identifiers of 63 *bytes* (not characters)
  after which the name is truncated. In UTF8 encoding, the underscore
  would be in the 64th position.

Hmm ... that is a really good point, except that you are not counting
the "lob." or "plob." part, which we previously saw is part of the
relation name not the schema name. Counting that part, it's already
overlimit, which seems to be proof that Andrey isn't using UTF8 but
some single-byte encoding.

Anyway, that would only explain the issue if pg_upgrade were somehow
changing the database encoding, which surely we'd have heard complaints
about already? Or maybe this has something to do with pg_upgrade's
client-side encoding rather than the server encoding...

                         regards, tom lane

I'm initialize data dir with use ru_RU.UTF8, but this databse use CP1251, ie one byte per character.

Agreed. This is a complicated report because the identifiers:

* contain periods
* are long
* are in cyrillic
* don't use utf8
* are very similar

However, I just can't see how these could be causing the problem.
Looking at the 9.1 pg_upgrade code, we already know that there are the
same number of relations in old and new clusters, so everything must be
being restored. And there is a lob.* and a plob.* that exist. The C
code is also saying that the pg_class.oid of the lob.* in the old
database is the same as the plob.* in the new database. That question
is how is that happening.

Can you email me privately the output of:

        pg_dump --schema-only --binary-upgrade database

Thanks. If you want to debug this yourself, check these lines in the
pg_dump output:

        -- For binary upgrade, must preserve pg_class oids
        SELECT binary_upgrade.set_next_index_pg_class_oid('786665369'::pg_catalog.oid);

        ALTER TABLE ONLY "lob.ВерсияВнешнегоДокумента$Документ"
            ADD CONSTRAINT "plob.ВерсияВнешнегоДокумента$Документ" PRIMARY KEY ("@Файл", "Страница");

See that 786665369? That is the pg_class.oid of the plob in the old
cluster, and hopefully the new one. Find where the lob*_pkey index is
created and get that oid. Those should match the same names of the
pg_class.oid in the old and new clusters, but it seems the new plob* oid
is matching the lob oid in the old cluster.

Also, pg_upgrade sorts everything by oid, so it can't be that somehow
pg_upgrade isn't ordering things right, and because we already passed
the oid check, we already know they have the same oid, but different
names.

--
  Bruce Momjian <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

Yes, was the last question. How to find out which version should stay?
And of course, I forgot to say a great big thank you!

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#24

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Groshev Andrey (#23)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Thu, Dec 20, 2012 at 03:41:37PM +0400, Groshev Andrey wrote:

See that 786665369? ï¿½That is the pg_class.oid of the plob in the old
cluster, and hopefully the new one. ï¿½Find where the lob*_pkey index is
created and get that oid. ï¿½Those should match the same names of the
pg_class.oid in the old and new clusters, but it seems the new plob* oid
is matching the lob oid in the old cluster.

Also, pg_upgrade sorts everything by oid, so it can't be that somehow
pg_upgrade isn't ordering things right, and because we already passed
the oid check, we already know they have the same oid, but different
names.

--
ï¿½ï¿½Bruce Momjian ï¿½<bruce@momjian.us> ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½http://momjian.us
ï¿½ï¿½EnterpriseDB ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½ï¿½http://enterprisedb.com

ï¿½ï¿½+ It's impossible for everything to be true. +

Yes, was the last question. How to find out which version should stay?
And of course, I forgot to say a great big thank you!

You can pick either name to be the right one; they just have to match.
The oids are fine.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#25

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Bruce Momjian (#13)

1 attachment(s)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Wed, Dec 19, 2012 at 10:19:30PM -0500, Bruce Momjian wrote:

On Wed, Dec 19, 2012 at 12:56:05PM -0500, Kevin Grittner wrote:

Groshev Andrey wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ

There is a limit on identifiers of 63 *bytes* (not characters)
after which the name is truncated. In UTF8 encoding, the underscore
would be in the 64th position.

OK, Kevin is certainly pointing out a bug in the pg_upgrade code, though
I am unclear how it would exhibit the mismatch error reported.

pg_upgrade uses NAMEDATALEN for database, schema, and relation name
storage lengths. While NAMEDATALEN works fine in the backend, it is
possible that a frontend client, like pg_upgrade, could retrieve a name
in the client encoding whose length exceeds NAMEDATALEN if the client
encoding did not match the database encoding (or is it the cluster
encoding for system tables). This would cause truncation of these
values. The truncation would not cause crashes, but might cause
failures by not being able to connect to overly-long database names, and
it weakens the checking of relation/schema names --- the same check that
is reported above.

(I believe initdb.c also erroneously uses NAMEDATALEN.)

I have developed the attached patch to pg_strdup() the string returned
from libpq, rather than use a fixed NAMEDATALEN buffer to store the
value. I am only going to apply this to 9.3 because I can't see this
causing problems except for weaker comparisons for very long identifiers
where the client encoding is longer than the server encoding, and
failures for very long database names, no of which we have gotten bug
reports about.

Turns out initdb.c was fine because it expects only collation names to
be only in ASCII; I added a comment to that effect.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachments:

alloc.difftext/x-diff; charset=us-asciiDownload

diff --git a/contrib/pg_upgrade/info.c b/contrib/pg_upgrade/info.c
new file mode 100644
index 2250442..5cb9b61
*** a/contrib/pg_upgrade/info.c
--- b/contrib/pg_upgrade/info.c
*************** static void get_db_infos(ClusterInfo *cl
*** 23,29 ****
  static void get_rel_infos(ClusterInfo *cluster, DbInfo *dbinfo);
  static void free_rel_infos(RelInfoArr *rel_arr);
  static void print_db_infos(DbInfoArr *dbinfo);
! static void print_rel_infos(RelInfoArr *arr);
  
  
  /*
--- 23,29 ----
  static void get_rel_infos(ClusterInfo *cluster, DbInfo *dbinfo);
  static void free_rel_infos(RelInfoArr *rel_arr);
  static void print_db_infos(DbInfoArr *dbinfo);
! static void print_rel_infos(RelInfoArr *rel_arr);
  
  
  /*
*************** create_rel_filename_map(const char *old_
*** 127,134 ****
  	map->new_relfilenode = new_rel->relfilenode;
  
  	/* used only for logging and error reporing, old/new are identical */
! 	snprintf(map->nspname, sizeof(map->nspname), "%s", old_rel->nspname);
! 	snprintf(map->relname, sizeof(map->relname), "%s", old_rel->relname);
  }
  
  
--- 127,134 ----
  	map->new_relfilenode = new_rel->relfilenode;
  
  	/* used only for logging and error reporing, old/new are identical */
! 	map->nspname = old_rel->nspname;
! 	map->relname = old_rel->relname;
  }
  
  
*************** get_db_infos(ClusterInfo *cluster)
*** 220,227 ****
  	for (tupnum = 0; tupnum < ntups; tupnum++)
  	{
  		dbinfos[tupnum].db_oid = atooid(PQgetvalue(res, tupnum, i_oid));
! 		snprintf(dbinfos[tupnum].db_name, sizeof(dbinfos[tupnum].db_name), "%s",
! 				 PQgetvalue(res, tupnum, i_datname));
  		snprintf(dbinfos[tupnum].db_tblspace, sizeof(dbinfos[tupnum].db_tblspace), "%s",
  				 PQgetvalue(res, tupnum, i_spclocation));
  	}
--- 220,226 ----
  	for (tupnum = 0; tupnum < ntups; tupnum++)
  	{
  		dbinfos[tupnum].db_oid = atooid(PQgetvalue(res, tupnum, i_oid));
! 		dbinfos[tupnum].db_name = pg_strdup(PQgetvalue(res, tupnum, i_datname));
  		snprintf(dbinfos[tupnum].db_tblspace, sizeof(dbinfos[tupnum].db_tblspace), "%s",
  				 PQgetvalue(res, tupnum, i_spclocation));
  	}
*************** get_rel_infos(ClusterInfo *cluster, DbIn
*** 346,355 ****
  		curr->reloid = atooid(PQgetvalue(res, relnum, i_oid));
  
  		nspname = PQgetvalue(res, relnum, i_nspname);
! 		strlcpy(curr->nspname, nspname, sizeof(curr->nspname));
  
  		relname = PQgetvalue(res, relnum, i_relname);
! 		strlcpy(curr->relname, relname, sizeof(curr->relname));
  
  		curr->relfilenode = atooid(PQgetvalue(res, relnum, i_relfilenode));
  
--- 345,354 ----
  		curr->reloid = atooid(PQgetvalue(res, relnum, i_oid));
  
  		nspname = PQgetvalue(res, relnum, i_nspname);
! 		curr->nspname = pg_strdup(nspname);
  
  		relname = PQgetvalue(res, relnum, i_relname);
! 		curr->relname = pg_strdup(relname);
  
  		curr->relfilenode = atooid(PQgetvalue(res, relnum, i_relfilenode));
  
*************** free_db_and_rel_infos(DbInfoArr *db_arr)
*** 377,383 ****
--- 376,385 ----
  	int			dbnum;
  
  	for (dbnum = 0; dbnum < db_arr->ndbs; dbnum++)
+ 	{
  		free_rel_infos(&db_arr->dbs[dbnum].rel_arr);
+ 		pg_free(db_arr->dbs[dbnum].db_name);
+ 	}
  	pg_free(db_arr->dbs);
  	db_arr->dbs = NULL;
  	db_arr->ndbs = 0;
*************** free_db_and_rel_infos(DbInfoArr *db_arr)
*** 387,392 ****
--- 389,401 ----
  static void
  free_rel_infos(RelInfoArr *rel_arr)
  {
+ 	int			relnum;
+ 
+ 	for (relnum = 0; relnum < rel_arr->nrels; relnum++)
+ 	{
+ 		pg_free(rel_arr->rels[relnum].nspname);
+ 		pg_free(rel_arr->rels[relnum].relname);
+ 	}
  	pg_free(rel_arr->rels);
  	rel_arr->nrels = 0;
  }
*************** print_db_infos(DbInfoArr *db_arr)
*** 407,418 ****
  
  
  static void
! print_rel_infos(RelInfoArr *arr)
  {
  	int			relnum;
  
! 	for (relnum = 0; relnum < arr->nrels; relnum++)
  		pg_log(PG_VERBOSE, "relname: %s.%s: reloid: %u reltblspace: %s\n",
! 			   arr->rels[relnum].nspname, arr->rels[relnum].relname,
! 			   arr->rels[relnum].reloid, arr->rels[relnum].tablespace);
  }
--- 416,427 ----
  
  
  static void
! print_rel_infos(RelInfoArr *rel_arr)
  {
  	int			relnum;
  
! 	for (relnum = 0; relnum < rel_arr->nrels; relnum++)
  		pg_log(PG_VERBOSE, "relname: %s.%s: reloid: %u reltblspace: %s\n",
! 			   rel_arr->rels[relnum].nspname, rel_arr->rels[relnum].relname,
! 			   rel_arr->rels[relnum].reloid, rel_arr->rels[relnum].tablespace);
  }
diff --git a/contrib/pg_upgrade/pg_upgrade.h b/contrib/pg_upgrade/pg_upgrade.h
new file mode 100644
index 972e8e9..cae1e46
*** a/contrib/pg_upgrade/pg_upgrade.h
--- b/contrib/pg_upgrade/pg_upgrade.h
*************** extern char *output_files[];
*** 114,121 ****
   */
  typedef struct
  {
! 	char		nspname[NAMEDATALEN];	/* namespace name */
! 	char		relname[NAMEDATALEN];	/* relation name */
  	Oid			reloid;			/* relation oid */
  	Oid			relfilenode;	/* relation relfile node */
  	/* relation tablespace path, or "" for the cluster default */
--- 114,122 ----
   */
  typedef struct
  {
! 	/* Can't use NAMEDATALEN;  not guaranteed to fit on client */
! 	char		*nspname;		/* namespace name */
! 	char		*relname;		/* relation name */
  	Oid			reloid;			/* relation oid */
  	Oid			relfilenode;	/* relation relfile node */
  	/* relation tablespace path, or "" for the cluster default */
*************** typedef struct
*** 143,150 ****
  	Oid			old_relfilenode;
  	Oid			new_relfilenode;
  	/* the rest are used only for logging and error reporting */
! 	char		nspname[NAMEDATALEN];	/* namespaces */
! 	char		relname[NAMEDATALEN];
  } FileNameMap;
  
  /*
--- 144,151 ----
  	Oid			old_relfilenode;
  	Oid			new_relfilenode;
  	/* the rest are used only for logging and error reporting */
! 	char		*nspname;		/* namespaces */
! 	char		*relname;
  } FileNameMap;
  
  /*
*************** typedef struct
*** 153,159 ****
  typedef struct
  {
  	Oid			db_oid;			/* oid of the database */
! 	char		db_name[NAMEDATALEN];	/* database name */
  	char		db_tblspace[MAXPGPATH]; /* database default tablespace path */
  	RelInfoArr	rel_arr;		/* array of all user relinfos */
  } DbInfo;
--- 154,160 ----
  typedef struct
  {
  	Oid			db_oid;			/* oid of the database */
! 	char		*db_name;		/* database name */
  	char		db_tblspace[MAXPGPATH]; /* database default tablespace path */
  	RelInfoArr	rel_arr;		/* array of all user relinfos */
  } DbInfo;
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
new file mode 100644
index 40740dc..3e05ac3
*** a/src/bin/initdb/initdb.c
--- b/src/bin/initdb/initdb.c
*************** setup_collation(void)
*** 1836,1842 ****
  #if defined(HAVE_LOCALE_T) && !defined(WIN32)
  	int			i;
  	FILE	   *locale_a_handle;
! 	char		localebuf[NAMEDATALEN];
  	int			count = 0;
  
  	PG_CMD_DECL;
--- 1836,1842 ----
  #if defined(HAVE_LOCALE_T) && !defined(WIN32)
  	int			i;
  	FILE	   *locale_a_handle;
! 	char		localebuf[NAMEDATALEN]; /* we assume ASCII so this is fine */
  	int			count = 0;
  
  	PG_CMD_DECL;

#26

Tom Lane

tgl@sss.pgh.pa.us

about 13 years ago

In reply to: Bruce Momjian (#20)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

Bruce Momjian <bruce@momjian.us> writes:

As you can see, ALTER INDEX renamed both the pg_constraint and pg_class
names. Is it possible someone manually updated the system table to
rename this primary key? That would cause this error message. The fix
is to just to make sure they match.

Does pg_upgrade need to be modified to handle this case? Are there
legitimate cases where they will not match and the index name will not
be preserved though a dump/restore? This seems safe:

It's not always been true that ALTER INDEX would try to rename
constraints to keep 'em in sync. A quick check says that only 8.3 and
later do that. I'm not sure though how a 9.0 database could get into
such a state without manual catalog hacking, since as you say a dump and
reload should have ended up with the index and constraint having the
same name again.

I'd be inclined not to worry about this in pg_upgrade, at least not till
we see a plausible scenario for the situation to arise without manual
catalog changes.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#27

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Tom Lane (#26)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

On Thu, Dec 20, 2012 at 11:08:58AM -0500, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

As you can see, ALTER INDEX renamed both the pg_constraint and pg_class
names. Is it possible someone manually updated the system table to
rename this primary key? That would cause this error message. The fix
is to just to make sure they match.

Does pg_upgrade need to be modified to handle this case? Are there
legitimate cases where they will not match and the index name will not
be preserved though a dump/restore? This seems safe:

It's not always been true that ALTER INDEX would try to rename
constraints to keep 'em in sync. A quick check says that only 8.3 and
later do that. I'm not sure though how a 9.0 database could get into
such a state without manual catalog hacking, since as you say a dump and
reload should have ended up with the index and constraint having the
same name again.

I'd be inclined not to worry about this in pg_upgrade, at least not till
we see a plausible scenario for the situation to arise without manual
catalog changes.

Agreed. I added a C comment so we don't forget about the matching
requirement.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#28

Bruce Momjian

bruce@momjian.us

about 13 years ago

In reply to: Bruce Momjian (#25)

Re: [GENERAL] trouble with pg_upgrade 9.0 -> 9.1

Applied. We can mark this report closed. Groshev, let us know if you
have any further problems.

---------------------------------------------------------------------------

On Thu, Dec 20, 2012 at 07:19:48AM -0500, Bruce Momjian wrote:

On Wed, Dec 19, 2012 at 10:19:30PM -0500, Bruce Momjian wrote:

On Wed, Dec 19, 2012 at 12:56:05PM -0500, Kevin Grittner wrote:

Groshev Andrey wrote:

Mismatch of relation names: database "database", old rel public.lob.ВерсияВнешнегоДокумента$Документ_pkey, new rel public.plob.ВерсияВнешнегоДокумента$Документ

There is a limit on identifiers of 63 *bytes* (not characters)
after which the name is truncated. In UTF8 encoding, the underscore
would be in the 64th position.

OK, Kevin is certainly pointing out a bug in the pg_upgrade code, though
I am unclear how it would exhibit the mismatch error reported.

pg_upgrade uses NAMEDATALEN for database, schema, and relation name
storage lengths. While NAMEDATALEN works fine in the backend, it is
possible that a frontend client, like pg_upgrade, could retrieve a name
in the client encoding whose length exceeds NAMEDATALEN if the client
encoding did not match the database encoding (or is it the cluster
encoding for system tables). This would cause truncation of these
values. The truncation would not cause crashes, but might cause
failures by not being able to connect to overly-long database names, and
it weakens the checking of relation/schema names --- the same check that
is reported above.

(I believe initdb.c also erroneously uses NAMEDATALEN.)

I have developed the attached patch to pg_strdup() the string returned
from libpq, rather than use a fixed NAMEDATALEN buffer to store the
value. I am only going to apply this to 9.3 because I can't see this
causing problems except for weaker comparisons for very long identifiers
where the client encoding is longer than the server encoding, and
failures for very long database names, no of which we have gotten bug
reports about.

Turns out initdb.c was fine because it expects only collation names to
be only in ASCII; I added a comment to that effect.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

diff --git a/contrib/pg_upgrade/info.c b/contrib/pg_upgrade/info.c
new file mode 100644
index 2250442..5cb9b61
*** a/contrib/pg_upgrade/info.c
--- b/contrib/pg_upgrade/info.c
*************** static void get_db_infos(ClusterInfo *cl
*** 23,29 ****
static void get_rel_infos(ClusterInfo *cluster, DbInfo *dbinfo);
static void free_rel_infos(RelInfoArr *rel_arr);
static void print_db_infos(DbInfoArr *dbinfo);
! static void print_rel_infos(RelInfoArr *arr);

/*
--- 23,29 ----
static void get_rel_infos(ClusterInfo *cluster, DbInfo *dbinfo);
static void free_rel_infos(RelInfoArr *rel_arr);
static void print_db_infos(DbInfoArr *dbinfo);
! static void print_rel_infos(RelInfoArr *rel_arr);

/*
*************** create_rel_filename_map(const char *old_
*** 127,134 ****
map->new_relfilenode = new_rel->relfilenode;

/* used only for logging and error reporing, old/new are identical */
! snprintf(map->nspname, sizeof(map->nspname), "%s", old_rel->nspname);
! snprintf(map->relname, sizeof(map->relname), "%s", old_rel->relname);
}

--- 127,134 ----
map->new_relfilenode = new_rel->relfilenode;

/* used only for logging and error reporing, old/new are identical */
! map->nspname = old_rel->nspname;
! map->relname = old_rel->relname;
}

*************** get_db_infos(ClusterInfo *cluster)
*** 220,227 ****
for (tupnum = 0; tupnum < ntups; tupnum++)
{
dbinfos[tupnum].db_oid = atooid(PQgetvalue(res, tupnum, i_oid));
! 		snprintf(dbinfos[tupnum].db_name, sizeof(dbinfos[tupnum].db_name), "%s",
! 				 PQgetvalue(res, tupnum, i_datname));
snprintf(dbinfos[tupnum].db_tblspace, sizeof(dbinfos[tupnum].db_tblspace), "%s",
PQgetvalue(res, tupnum, i_spclocation));
}
--- 220,226 ----
for (tupnum = 0; tupnum < ntups; tupnum++)
{
dbinfos[tupnum].db_oid = atooid(PQgetvalue(res, tupnum, i_oid));
! 		dbinfos[tupnum].db_name = pg_strdup(PQgetvalue(res, tupnum, i_datname));
snprintf(dbinfos[tupnum].db_tblspace, sizeof(dbinfos[tupnum].db_tblspace), "%s",
PQgetvalue(res, tupnum, i_spclocation));
}
*************** get_rel_infos(ClusterInfo *cluster, DbIn
*** 346,355 ****
curr->reloid = atooid(PQgetvalue(res, relnum, i_oid));

nspname = PQgetvalue(res, relnum, i_nspname);
! strlcpy(curr->nspname, nspname, sizeof(curr->nspname));

relname = PQgetvalue(res, relnum, i_relname);
! strlcpy(curr->relname, relname, sizeof(curr->relname));

curr->relfilenode = atooid(PQgetvalue(res, relnum, i_relfilenode));

--- 345,354 ----
curr->reloid = atooid(PQgetvalue(res, relnum, i_oid));

nspname = PQgetvalue(res, relnum, i_nspname);
! curr->nspname = pg_strdup(nspname);

relname = PQgetvalue(res, relnum, i_relname);
! curr->relname = pg_strdup(relname);

curr->relfilenode = atooid(PQgetvalue(res, relnum, i_relfilenode));

*************** free_db_and_rel_infos(DbInfoArr *db_arr)
*** 377,383 ****
--- 376,385 ----
int			dbnum;

for (dbnum = 0; dbnum < db_arr->ndbs; dbnum++)
+ 	{
free_rel_infos(&db_arr->dbs[dbnum].rel_arr);
+ 		pg_free(db_arr->dbs[dbnum].db_name);
+ 	}
pg_free(db_arr->dbs);
db_arr->dbs = NULL;
db_arr->ndbs = 0;
*************** free_db_and_rel_infos(DbInfoArr *db_arr)
*** 387,392 ****
--- 389,401 ----
static void
free_rel_infos(RelInfoArr *rel_arr)
{
+ 	int			relnum;
+ 
+ 	for (relnum = 0; relnum < rel_arr->nrels; relnum++)
+ 	{
+ 		pg_free(rel_arr->rels[relnum].nspname);
+ 		pg_free(rel_arr->rels[relnum].relname);
+ 	}
pg_free(rel_arr->rels);
rel_arr->nrels = 0;
}
*************** print_db_infos(DbInfoArr *db_arr)
*** 407,418 ****

static void
! print_rel_infos(RelInfoArr *arr)
{
int relnum;

! 	for (relnum = 0; relnum < arr->nrels; relnum++)
pg_log(PG_VERBOSE, "relname: %s.%s: reloid: %u reltblspace: %s\n",
! 			   arr->rels[relnum].nspname, arr->rels[relnum].relname,
! 			   arr->rels[relnum].reloid, arr->rels[relnum].tablespace);
}
--- 416,427 ----

static void
! print_rel_infos(RelInfoArr *rel_arr)
{
int relnum;

! 	for (relnum = 0; relnum < rel_arr->nrels; relnum++)
pg_log(PG_VERBOSE, "relname: %s.%s: reloid: %u reltblspace: %s\n",
! 			   rel_arr->rels[relnum].nspname, rel_arr->rels[relnum].relname,
! 			   rel_arr->rels[relnum].reloid, rel_arr->rels[relnum].tablespace);
}
diff --git a/contrib/pg_upgrade/pg_upgrade.h b/contrib/pg_upgrade/pg_upgrade.h
new file mode 100644
index 972e8e9..cae1e46
*** a/contrib/pg_upgrade/pg_upgrade.h
--- b/contrib/pg_upgrade/pg_upgrade.h
*************** extern char *output_files[];
*** 114,121 ****
*/
typedef struct
{
! 	char		nspname[NAMEDATALEN];	/* namespace name */
! 	char		relname[NAMEDATALEN];	/* relation name */
Oid			reloid;			/* relation oid */
Oid			relfilenode;	/* relation relfile node */
/* relation tablespace path, or "" for the cluster default */
--- 114,122 ----
*/
typedef struct
{
! 	/* Can't use NAMEDATALEN;  not guaranteed to fit on client */
! 	char		*nspname;		/* namespace name */
! 	char		*relname;		/* relation name */
Oid			reloid;			/* relation oid */
Oid			relfilenode;	/* relation relfile node */
/* relation tablespace path, or "" for the cluster default */
*************** typedef struct
*** 143,150 ****
Oid			old_relfilenode;
Oid			new_relfilenode;
/* the rest are used only for logging and error reporting */
! 	char		nspname[NAMEDATALEN];	/* namespaces */
! 	char		relname[NAMEDATALEN];
} FileNameMap;

/*
--- 144,151 ----
Oid			old_relfilenode;
Oid			new_relfilenode;
/* the rest are used only for logging and error reporting */
! 	char		*nspname;		/* namespaces */
! 	char		*relname;
} FileNameMap;

/*
*************** typedef struct
*** 153,159 ****
typedef struct
{
Oid			db_oid;			/* oid of the database */
! 	char		db_name[NAMEDATALEN];	/* database name */
char		db_tblspace[MAXPGPATH]; /* database default tablespace path */
RelInfoArr	rel_arr;		/* array of all user relinfos */
} DbInfo;
--- 154,160 ----
typedef struct
{
Oid			db_oid;			/* oid of the database */
! 	char		*db_name;		/* database name */
char		db_tblspace[MAXPGPATH]; /* database default tablespace path */
RelInfoArr	rel_arr;		/* array of all user relinfos */
} DbInfo;
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
new file mode 100644
index 40740dc..3e05ac3
*** a/src/bin/initdb/initdb.c
--- b/src/bin/initdb/initdb.c
*************** setup_collation(void)
*** 1836,1842 ****
#if defined(HAVE_LOCALE_T) && !defined(WIN32)
int			i;
FILE	   *locale_a_handle;
! 	char		localebuf[NAMEDATALEN];
int			count = 0;

PG_CMD_DECL;
--- 1836,1842 ----
#if defined(HAVE_LOCALE_T) && !defined(WIN32)
int			i;
FILE	   *locale_a_handle;
! 	char		localebuf[NAMEDATALEN]; /* we assume ASCII so this is fine */
int			count = 0;

PG_CMD_DECL;

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers