Minor fix in 'clean' action of 'src/backend/Makefile'
Hi all,
When we execute 'make clean' the file 'src/backend/replication/repl_gram.h'
is not removed.
The attached patch fix it.
Regards,
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Show quoted text
Blog sobre TI: http://fabriziomello.blogspot.com
Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello
Attachments:
fix_clean_src_backend_makefile.patchapplication/octet-stream; name=fix_clean_src_backend_makefile.patchDownload
diff --git a/src/backend/Makefile b/src/backend/Makefile
index 323b417..a2d5f8d 100644
--- a/src/backend/Makefile
+++ b/src/backend/Makefile
@@ -291,7 +291,9 @@ clean:
$(top_builddir)/src/include/parser/gram.h \
$(top_builddir)/src/include/catalog/schemapg.h \
$(top_builddir)/src/include/utils/fmgroids.h \
- $(top_builddir)/src/include/utils/probes.h
+ $(top_builddir)/src/include/utils/probes.h \
+ $(top_builddir)/src/backend/replication/repl_gram.h
+
ifeq ($(PORTNAME), cygwin)
rm -f postgres.dll postgres.def libpostgres.a
endif
On 02.01.2013 18:05, Fabrízio de Royes Mello wrote:
Hi all,
When we execute 'make clean' the file 'src/backend/replication/repl_gram.h'
is not removed.
That's on purpose. repl_gram.h is generated by bison, along with
repl_gram.c. Neither is removed by "make clean", because they're needed
in a distribution tarball. "make maintainer-clean" does remove them.
Hmm, looking closer though, repl_gram.h is not actually needed for
anything, though. We could just remove the -d flag from the bison
invocation and not build it to begin with. I'll go and do that..
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 02.01.2013 18:20, Heikki Linnakangas wrote:
Hmm, looking closer though, repl_gram.h is not actually needed for
anything, though. We could just remove the -d flag from the bison
invocation and not build it to begin with. I'll go and do that..
And looking even closer, we don't use the -d flag in git master anymore,
so repl_gram.h is not being built, and there's nothing to do here. I
suppose we could change back-branches to also not build it, but I don't
think I'm going to bother.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Jan 2, 2013 at 2:23 PM, Heikki Linnakangas
<hlinnakangas@vmware.com>wrote:
On 02.01.2013 18:20, Heikki Linnakangas wrote:
Hmm, looking closer though, repl_gram.h is not actually needed for
anything, though. We could just remove the -d flag from the bison
invocation and not build it to begin with. I'll go and do that..And looking even closer, we don't use the -d flag in git master anymore,
so repl_gram.h is not being built, and there's nothing to do here. I
suppose we could change back-branches to also not build it, but I don't
think I'm going to bother.
You all right... thanks....
--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
Show quoted text
Blog sobre TI: http://fabriziomello.blogspot.com
Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello