segmentation fault in pg_basebackup
Hi,
The pg_basebackup in HEAD caused a segmentation fault in my box.
$ pg_basebackup -D mmm
Segmentation fault: 11
The cause is that WriteRecoveryConf() is wrongly called even if -R option is
not specified in pg_basebackup. Attached patch fixes this problem.
Regards,
--
Fujii Masao
Attachments:
pg_basebackup_segv_bugfix_v1.patchapplication/octet-stream; name=pg_basebackup_segv_bugfix_v1.patchDownload
*** a/src/bin/pg_basebackup/pg_basebackup.c
--- b/src/bin/pg_basebackup/pg_basebackup.c
***************
*** 1084,1090 **** ReceiveAndUnpackTarFile(PGconn *conn, PGresult *res, int rownum)
if (copybuf != NULL)
PQfreemem(copybuf);
! if (basetablespace)
WriteRecoveryConf();
}
--- 1084,1090 ----
if (copybuf != NULL)
PQfreemem(copybuf);
! if (basetablespace && writerecoveryconf)
WriteRecoveryConf();
}
On Wed, Jan 9, 2013 at 4:56 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
Hi,
The pg_basebackup in HEAD caused a segmentation fault in my box.
$ pg_basebackup -D mmm
Segmentation fault: 11The cause is that WriteRecoveryConf() is wrongly called even if -R option is
not specified in pg_basebackup. Attached patch fixes this problem.
Ugh, my fault. Failure when merging my changes with those from Zoltan.
Applied, thanks.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers