s/size_t/off_t/ in sendTimeLineHistory
Hi,
When looking at the report of probable fallout from the elog stuff I
noticed this warning:
walsender.c(366): warning #186: pointless comparison of unsigned integer with zero
Which is accurate, the rather unlikely problem of a seek error could not
be noticed atm and would probably send strange stuff over the wire.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachments:
sendTimeLineHistory-off_t.patchtext/x-patch; charset=us-asciiDownload
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
index 5408b14..e4700da 100644
--- a/src/backend/replication/walsender.c
+++ b/src/backend/replication/walsender.c
@@ -315,8 +315,8 @@ SendTimeLineHistory(TimeLineHistoryCmd *cmd)
char histfname[MAXFNAMELEN];
char path[MAXPGPATH];
int fd;
- size_t histfilelen;
- size_t bytesleft;
+ off_t histfilelen;
+ off_t bytesleft;
/*
* Reply with a result set with one row, and two columns. The first col
On 15.01.2013 00:27, Andres Freund wrote:
When looking at the report of probable fallout from the elog stuff I
noticed this warning:walsender.c(366): warning #186: pointless comparison of unsigned integer with zero
Which is accurate, the rather unlikely problem of a seek error could not
be noticed atm and would probably send strange stuff over the wire.
Thanks, applied.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers