USE_PGXS contrib build is broken

On Mon, Feb 4, 2013 at 2:38 PM, Alvaro Herrera <alvherre@2ndquadrant.com>wrote:

I just noticed that contrib programs don't build in USE_PGXS=1
environment:

$ pwd
/pgsql/build/HEAD/contrib/pg_upgrade
$ LC_ALL=C USE_PGXS=1 make
make: *** No rule to make target `check.o', needed by `pg_upgrade'. Stop.

FWIW, I am able to build just fine using USE_PGXS!

Gurjeet Singh wrote:

On Mon, Feb 4, 2013 at 2:38 PM, Alvaro Herrera <alvherre@2ndquadrant.com>wrote:

I just noticed that contrib programs don't build in USE_PGXS=1
environment:

$ pwd
/pgsql/build/HEAD/contrib/pg_upgrade
$ LC_ALL=C USE_PGXS=1 make
make: *** No rule to make target `check.o', needed by `pg_upgrade'. Stop.

FWIW, I am able to build just fine using USE_PGXS!

Hmm. Mine is a VPATH build; maybe that makes a difference. Now I'm not
really certain that pgxs is supposed to work for VPATH.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

On Mon, Feb 4, 2013 at 3:37 PM, Alvaro Herrera <alvherre@2ndquadrant.com>wrote:

Gurjeet Singh wrote:

On Mon, Feb 4, 2013 at 2:38 PM, Alvaro Herrera <alvherre@2ndquadrant.com
wrote:

I just noticed that contrib programs don't build in USE_PGXS=1
environment:

$ pwd
/pgsql/build/HEAD/contrib/pg_upgrade
$ LC_ALL=C USE_PGXS=1 make
make: *** No rule to make target `check.o', needed by `pg_upgrade'.

Stop.

FWIW, I am able to build just fine using USE_PGXS!

Hmm. Mine is a VPATH build; maybe that makes a difference. Now I'm not
really certain that pgxs is supposed to work for VPATH.

Yup, looks like that. When I tried my (default) VPATH build, it did throw
that error! But a regular build went just fine.

My VPATH build that breaks:

USE_PGXS=1 pgmake -C contrib/pg_upgrade

Which gets translated into

USE_PGXS=1 make -C /home/gurjeet/dev/pgdbuilds/pg_master -C
contrib/pg_upgrade