Re: [HACKERS] misc and triggers regression tests failed on 6. 5be t a1

Started by ZEUGSWETTER Andreas IZ5over 26 years ago2 messages

Andreas.Zeugswetter@telecom.at

over 26 years ago

1 attachment(s)

I have applied a new refint from Massimo. Can people check that and
make the needed fixes to it and trigger.sql?

Since you seem to want this functionality, could you alter
check_primary_key,
so that it chooses a default action of "dependent", and not force us to
specify an action ?

I applied it because it was supplied to me. I have no opinion on way or
the other. If you want to reverse this all out, feel free, or add the
dependent option.

I am sorry, I misinterpreted the still failing trigger regression test. The
offending code
has been removed, the action is now always dependent :-)

I suggest the following patch, to finally make trigger regression happy
again:

<<refint1.patch>>
After that you can remove the following from TODO:
Remove ERROR: check_primary_key: even number of arguments should be
specified
Trigger regression test fails

Andreas

Attachments:

refint1.patchapplication/octet-stream; name=refint1.patchDownload

*** ./contrib/spi/refint.c.orig	Tue May 11 11:26:33 1999
--- ./contrib/spi/refint.c	Tue May 11 14:15:45 1999
***************
*** 3,10 ****
   *		constraints using general triggers.
   */
  
- #define  DEBUG_QUERY 1
- 
  #include "executor/spi.h"		/* this is what you need to work with SPI */
  #include "commands/trigger.h"	/* -"- and triggers */
  #include <ctype.h>				/* tolower () */
--- 3,8 ----
*** ./src/backend/utils/adt/acl.c.orig	Mon Mar 22 11:32:41 1999
--- ./src/backend/utils/adt/acl.c	Tue May 11 13:54:19 1999
***************
*** 108,114 ****
  
  #ifdef ACLDEBUG_TRACE
  	printf("aclparse: input = '%s'\n", s);
! #endif ACLDEBUG_TRACE
  	aip->ai_idtype = ACL_IDTYPE_UID;
  	s = getid(s, name);
  	if (*s != ACL_MODECHG_ADD_CHR &&
--- 108,114 ----
  
  #ifdef ACLDEBUG_TRACE
  	printf("aclparse: input = '%s'\n", s);
! #endif
  	aip->ai_idtype = ACL_IDTYPE_UID;
  	s = getid(s, name);
  	if (*s != ACL_MODECHG_ADD_CHR &&

Bruce Momjian

maillist@candle.pha.pa.us

over 26 years ago

In reply to: ZEUGSWETTER Andreas IZ5 (#1)

Applied.

I have applied a new refint from Massimo. Can people check that and
make the needed fixes to it and trigger.sql?

Since you seem to want this functionality, could you alter
check_primary_key,
so that it chooses a default action of "dependent", and not force us to
specify an action ?

I applied it because it was supplied to me. I have no opinion on way or
the other. If you want to reverse this all out, feel free, or add the
dependent option.

I am sorry, I misinterpreted the still failing trigger regression test. The
offending code
has been removed, the action is now always dependent :-)

I suggest the following patch, to finally make trigger regression happy
again:

<<refint1.patch>>
After that you can remove the following from TODO:
Remove ERROR: check_primary_key: even number of arguments should be
specified
Trigger regression test fails

Andreas

[Attachment, skipping...]

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026