pgsql: Revert "pg_ctl: Add idempotent option"

Started by Peter Eisentrautover 12 years ago3 messages
#1Peter Eisentraut
peter_e@gmx.net

Revert "pg_ctl: Add idempotent option"

This reverts commit 87306184580c9c49717b00d48a2f9e717f21e0a8. The
behavior in certain cases is still being debated, and it's too late to
solve this before beta.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/187ca5e8e90baacc2d36c8bd0b08040f33c07fa1

Modified Files
--------------
contrib/start-scripts/linux | 4 ++--
doc/src/sgml/ref/pg_ctl-ref.sgml | 21 ---------------------
src/bin/pg_ctl/pg_ctl.c | 29 +++++++----------------------
3 files changed, 9 insertions(+), 45 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Fujii Masao
masao.fujii@gmail.com
In reply to: Peter Eisentraut (#1)
1 attachment(s)
Re: [COMMITTERS] pgsql: Revert "pg_ctl: Add idempotent option"

On Tue, Apr 30, 2013 at 11:02 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

Revert "pg_ctl: Add idempotent option"

This reverts commit 87306184580c9c49717b00d48a2f9e717f21e0a8. The
behavior in certain cases is still being debated, and it's too late to
solve this before beta.

You also need to remove the description of this feature from release note.
Attached patch does that.

Regards,

--
Fujii Masao

Attachments:

release_note_change_v1.patchapplication/octet-stream; name=release_note_change_v1.patchDownload
*** a/doc/src/sgml/release-9.3.sgml
--- b/doc/src/sgml/release-9.3.sgml
***************
*** 1054,1067 ****
  
        <listitem>
         <para>
-         Allow pg_ctl --idempotent to a 'success' return code if the requested
-         start/stop action fails, but the cluster is already in the requested
-         state (Peter Eisentraut)
-        </para>
-       </listitem>
- 
-       <listitem>
-        <para>
          Change pg_ctl to return an error code if start fails because the
          server is already running (Peter Eisentraut)                                        
         </para>
--- 1054,1059 ----
#3Bruce Momjian
bruce@momjian.us
In reply to: Fujii Masao (#2)
Re: [COMMITTERS] pgsql: Revert "pg_ctl: Add idempotent option"

On Sat, May 4, 2013 at 12:11:48AM +0900, Fujii Masao wrote:

On Tue, Apr 30, 2013 at 11:02 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

Revert "pg_ctl: Add idempotent option"

This reverts commit 87306184580c9c49717b00d48a2f9e717f21e0a8. The
behavior in certain cases is still being debated, and it's too late to
solve this before beta.

You also need to remove the description of this feature from release note.
Attached patch does that.

Regards,

--
Fujii Masao

*** a/doc/src/sgml/release-9.3.sgml
--- b/doc/src/sgml/release-9.3.sgml
***************
*** 1054,1067 ****
<listitem>
<para>
-         Allow pg_ctl --idempotent to a 'success' return code if the requested
-         start/stop action fails, but the cluster is already in the requested
-         state (Peter Eisentraut)
-        </para>
-       </listitem>
- 
-       <listitem>
-        <para>
Change pg_ctl to return an error code if start fails because the
server is already running (Peter Eisentraut)                                        
</para>
--- 1054,1059 ----

Yes, thanks. I am updating 9.3 release notes now, and will add doc
links too.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers