Small typo in syncrep.h

Started by Pavan Deolaseeover 12 years ago2 messages

pavan.deolasee@gmail.com

over 12 years ago

2 attachment(s)

Hello,

While reading code, I noticed a small typo in syncrep.h. It
says SyncRepUpdateSyncStandbysDefined() is called by wal writer whereas its
called by the checkpointer process, at least in the HEAD. Previously, it
was being called by the bgwriter process.

Attached patches fix this in the relevant releases.

Thanks,
Pavan

--
Pavan Deolasee
http://www.linkedin.com/in/pavandeolasee

Attachments:

syncrep-typo-91.patchapplication/octet-stream; name=syncrep-typo-91.patchDownload

diff --git a/src/include/replication/syncrep.h b/src/include/replication/syncrep.h
index d71047e..14e6200 100644
--- a/src/include/replication/syncrep.h
+++ b/src/include/replication/syncrep.h
@@ -40,7 +40,7 @@ extern void SyncRepCleanupAtProcExit(void);
 extern void SyncRepInitConfig(void);
 extern void SyncRepReleaseWaiters(void);
 
-/* called by wal writer */
+/* called by bgwriter */
 extern void SyncRepUpdateSyncStandbysDefined(void);
 
 /* called by various procs */

syncrep-typo-head.patchapplication/octet-stream; name=syncrep-typo-head.patchDownload

diff --git a/src/include/replication/syncrep.h b/src/include/replication/syncrep.h
index 5635621..30e61c0 100644
--- a/src/include/replication/syncrep.h
+++ b/src/include/replication/syncrep.h
@@ -44,7 +44,7 @@ extern void SyncRepCleanupAtProcExit(void);
 extern void SyncRepInitConfig(void);
 extern void SyncRepReleaseWaiters(void);
 
-/* called by wal writer */
+/* called by checkpointer */
 extern void SyncRepUpdateSyncStandbysDefined(void);
 
 /* called by various procs */

Robert Haas

robertmhaas@gmail.com

over 12 years ago

In reply to: Pavan Deolasee (#1)

Re: Small typo in syncrep.h

On Thu, May 23, 2013 at 4:44 AM, Pavan Deolasee
<pavan.deolasee@gmail.com> wrote:

While reading code, I noticed a small typo in syncrep.h. It says
SyncRepUpdateSyncStandbysDefined() is called by wal writer whereas its
called by the checkpointer process, at least in the HEAD. Previously, it was
being called by the bgwriter process.

Attached patches fix this in the relevant releases.

Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers