Re: [HACKERS] 6.5 cvs: problem with includes in src/interfaces/libpq++/

Oleg Bartunov <oleg@sai.msu.su> writes:

To compile postgres using gcc 2.7.2.1 I had to modify 2 files
src/interfaces/libpq++/pgconnection.cc
src/interfaces/libpq++/pgenv.h
Particularly,
#include <iostream> to #include <iostream.h>
#include <strstream> to #include <strstream.h>

I am seeing the same thing here with gcc 2.7.2.2. We need to adopt
a considered policy about whether libpq++ will still support gcc 2.7.*,
not just break it without thinking.

I'd vote for still supporting 2.7.*, but I know that the C++ library
shipped with this gcc release is not real up-to-date. It may not be
practical to support both latest-C++-spec compilers and the older
generation; I'm not sure what the issues are.

If the conclusion is "no", then the configure script ought to be
changed to not try to build libpq++ unless up-to-date libraries
are available.

The addition/removal of '.h' has happened before. Some need it, some
can't handle it.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Oleg Bartunov <oleg@sai.msu.su> writes:

To compile postgres using gcc 2.7.2.1 I had to modify 2 files
src/interfaces/libpq++/pgconnection.cc
src/interfaces/libpq++/pgenv.h
Particularly,
#include <iostream> to #include <iostream.h>
#include <strstream> to #include <strstream.h>

My fault. I was using

gcc version egcs-2.91.60 19981201 (egcs-1.1.1 release)

when creating the above patches. However, please make the above
correct change, as all <iostream> does is to include <iostream.h> and
similarly <strstream> just includes <strstream.h>. I think the meaning
is deeper with other compilers, but with egcs they are just aliases. I
did, as Tom Lane puts it, just break it without thinking.

Cheers,

Patrick

On 15-May-99 Patrick Welche wrote:

Oleg Bartunov <oleg@sai.msu.su> writes:

To compile postgres using gcc 2.7.2.1 I had to modify 2 files
src/interfaces/libpq++/pgconnection.cc
src/interfaces/libpq++/pgenv.h
Particularly,
#include <iostream> to #include <iostream.h>
#include <strstream> to #include <strstream.h>

My fault. I was using

gcc version egcs-2.91.60 19981201 (egcs-1.1.1 release)

when creating the above patches. However, please make the above
correct change, as all <iostream> does is to include <iostream.h> and
similarly <strstream> just includes <strstream.h>. I think the meaning
is deeper with other compilers, but with egcs they are just aliases. I
did, as Tom Lane puts it, just break it without thinking.

libpq++ is being redone. Since 6.5 is under code freeze right now it'll
be 6.5.1 before the new stuff can show up. pgenv.h is already history
as it uses pretty much all deprecated functions.

Vince.
--
==========================================================================
Vince Vielhaber -- KA8CSH email: vev@michvhf.com flame-mail: /dev/null
# include <std/disclaimers.h> TEAM-OS2
Online Campground Directory http://www.camping-usa.com
Online Giftshop Superstore http://www.cloudninegifts.com
==========================================================================

libpq++ is being redone. Since 6.5 is under code freeze right now it'll
be 6.5.1 before the new stuff can show up. pgenv.h is already history
as it uses pretty much all deprecated functions.

Vince.

I think we may be able to put libpq++ into 6.5 at this point. It is
pretty limited now. I certainly don't think you are going to get it
into 6.5.1, because those are mostly fix releases.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

On 17-May-99 Bruce Momjian wrote:

libpq++ is being redone. Since 6.5 is under code freeze right now it'll
be 6.5.1 before the new stuff can show up. pgenv.h is already history
as it uses pretty much all deprecated functions.

Vince.

I think we may be able to put libpq++ into 6.5 at this point. It is
pretty limited now. I certainly don't think you are going to get it
into 6.5.1, because those are mostly fix releases.

Don't have it on this machine, but I'll send it along tomorrow or the
next day. Right now the only thing that's not working with the examples
is the large object stuff with binaries and I haven't tracked that down.
But it doesn't work with the example in the docs for libpq either...
Still alot I want to do but it's in alot better shape now than it was.
Dmitry's suggestions aren't in yet but will be soon.

Vince.
--
==========================================================================
Vince Vielhaber -- KA8CSH email: vev@michvhf.com flame-mail: /dev/null
# include <std/disclaimers.h> TEAM-OS2
Online Campground Directory http://www.camping-usa.com
Online Giftshop Superstore http://www.cloudninegifts.com
==========================================================================

Don't have it on this machine, but I'll send it along tomorrow or the
next day. Right now the only thing that's not working with the examples
is the large object stuff with binaries and I haven't tracked that down.
But it doesn't work with the example in the docs for libpq either...
Still alot I want to do but it's in alot better shape now than it was.
Dmitry's suggestions aren't in yet but will be soon.

Yes, I would like to get something new in libpq++.

-- 
  Bruce Momjian                        |  http://www.op.net/~candle
  maillist@candle.pha.pa.us            |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026