signed vs. unsigned in plpy_procedure.c
Hi,
src/postgresql/src/pl/plpython/plpy_procedure.c: In function ‘PLy_procedure_munge_source’:
src/postgresql/src/pl/plpython/plpy_procedure.c:507:2: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
Assert(plen >= 0 && plen < mlen);
Which has a point, we assign sprintf()s result to a size_t and then
check for a negative value. Which doesn't work.
Obviously the impact is miniscule, but removing legitimate warnings is a
good thing. Trivial patch attached.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachments:
plpy_procedure_unsigned.patchtext/x-patch; charset=us-asciiDownload+2-2
On 02.07.2013 13:39, Andres Freund wrote:
src/postgresql/src/pl/plpython/plpy_procedure.c: In function �PLy_procedure_munge_source�:
src/postgresql/src/pl/plpython/plpy_procedure.c:507:2: warning: comparison of unsigned expression>= 0 is always true [-Wtype-limits]
Assert(plen>= 0&& plen< mlen);Which has a point, we assign sprintf()s result to a size_t and then
check for a negative value. Which doesn't work.Obviously the impact is miniscule, but removing legitimate warnings is a
good thing. Trivial patch attached.
Thanks, applied.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers