output/security_label.source referring to abs_builddir instead of libdir
In make check, there are 4 shared libraries that are loaded for test cases
from the src/test/regress folder. Whereas, output of other libraries
contain @libdir@ tag, the output file for security_label (dumm_seclabel)
contains a tag for @abs_builddir@ in the output/security_label.source file.
I believe this an issue, and rather than referring @abs_builddir@, it
should instead contain the tag @libdir@. Also note that while I could
provide a path for dynamic libraries via "dlpath" option of pg_regress,
this is not honored by security_label test case.
PFA patch for this fix.
Regards.
--
*
*
*Hamid Quddus Akhtar*
Configuration Management Team
Ph: +92.333.544.9950
Skype ID: EngineeredVirus
www.enterprisedb.co
<http://www.enterprisedb.com/>m<http://www.enterprisedb.com/>
*
Follow us on Twitter*
@EnterpriseDB
Visit EnterpriseDB for tutorials, webinars,
whitepapers<http://www.enterprisedb.com/resources-community> and
more <http://www.enterprisedb.com/resources-community>
Attachments:
security_label.source.output.patchapplication/octet-stream; name=security_label.source.output.patchDownload
diff --git a/src/test/regress/output/security_label.source b/src/test/regress/output/security_label.source
index 9be8bbd..0e20244 100644
--- a/src/test/regress/output/security_label.source
+++ b/src/test/regress/output/security_label.source
@@ -38,7 +38,7 @@ ERROR: no security label providers have been loaded
SECURITY LABEL ON ROLE seclabel_user3 IS 'unclassified'; -- fail
ERROR: no security label providers have been loaded
-- Load dummy external security provider
-LOAD '@abs_builddir@/dummy_seclabel@DLSUFFIX@';
+LOAD '@libdir@/dummy_seclabel@DLSUFFIX@';
--
-- Test of SECURITY LABEL statement with a plugin
--
On Tue, Sep 17, 2013 at 07:04:14PM +0500, Hamid Quddus Akhtar wrote:
In make check, there are 4 shared libraries that are loaded for test cases
from the src/test/regress folder. Whereas, output of other libraries
contain @libdir@ tag, the output file for security_label (dumm_seclabel)
contains a tag for @abs_builddir@ in the output/security_label.source file.I believe this an issue, and rather than referring @abs_builddir@, it
should instead contain the tag @libdir@. Also note that while I could
provide a path for dynamic libraries via "dlpath" option of pg_regress,
this is not honored by security_label test case.PFA patch for this fix.
More simply, if input/security_label.source says @libdir@,
output/security_label.source ought to match that. Committed.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers