pgsql: Fix bugs in SSI tuple locking.

Started by Heikki Linnakangasover 12 years ago2 messages
#1Heikki Linnakangas
heikki.linnakangas@iki.fi

Fix bugs in SSI tuple locking.

1. In heap_hot_search_buffer(), the PredicateLockTuple() call is passed
wrong offset number. heapTuple->t_self is set to the tid of the first
tuple in the chain that's visited, not the one actually being read.

2. CheckForSerializableConflictIn() uses the tuple's t_ctid field
instead of t_self to check for exiting predicate locks on the tuple. If
the tuple was updated, but the updater rolled back, t_ctid points to the
aborted dead tuple.

Reported by Hannu Krosing. Backpatch to 9.1.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/81fbbfe3352d3965ee3d8eaafe164b2335c43f72

Modified Files
--------------
src/backend/access/heap/heapam.c | 4 +++-
src/backend/storage/lmgr/predicate.c | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Kevin Grittner
kgrittn@ymail.com
In reply to: Heikki Linnakangas (#1)
Re: [COMMITTERS] pgsql: Fix bugs in SSI tuple locking.

Heikki Linnakangas <heikki.linnakangas@iki.fi> wrote:

Fix bugs in SSI tuple locking.

Thanks Heikki, both for these fixes and the discovery and
discussion of the xmin issue!

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers