pg_upgrade misreports full disk

Started by Peter Eisentrautover 12 years ago2 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

When pg_upgrade encounters a full disk while copying relation files,
it reports this as:

error while copying relation "xyz" (...): Success

because it doesn't set errno in some error cases. In other places we
treat short writes as ENOSPC, so here is a patch to do that for
pg_upgrade as well.

Attachments:

pg_upgrade-fix.patchtext/x-diff; name=pg_upgrade-fix.patchDownload+8-0
#2Robert Haas
robertmhaas@gmail.com
In reply to: Peter Eisentraut (#1)
Re: pg_upgrade misreports full disk

On Wed, Nov 13, 2013 at 10:28 AM, Peter Eisentraut <peter_e@gmx.net> wrote:

When pg_upgrade encounters a full disk while copying relation files,
it reports this as:

error while copying relation "xyz" (...): Success

because it doesn't set errno in some error cases. In other places we
treat short writes as ENOSPC, so here is a patch to do that for
pg_upgrade as well.

+1 for committing this and back-patching it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers