Mar 2020

1 commit
Prevent reindex of invalid indexes on TOAST tables
10 Mar 2020Michael Paquiermaster13beta1REL_19_STABLE13beta1REL_18_STABLE13beta1REL_17_STABLE13beta1REL_16_STABLE13beta1REL_15_STABLE13beta1REL_14_STABLE13beta1REL_13_STABLE13beta1+1 moreAlso in: reindex concurrently and two toast indexes (modified before commit)

Mar - Apr 2019

3 commits
Rework handling of invalid indexes with REINDEX CONCURRENTLY
17 Apr 2019Michael Paquiermaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1642 of 2 reviewers saw the final version

Matches the five-file invalid-index repair in #164, preserving its backend behavior and documentation changes. The commit fixes the missing closing parenthesis and adds regression coverage for a repeated uniqueness failure and removal of its invalid temporary index.

  • Peter Eisentrautsaw the final versiontrailerPeter endorsed the attached invalid-index fix in #169, after which only light documentation and test changes distinguish the committed version.
  • Dagfinn Ilmari Mannsåkersaw the final versiontrailerDagfinn examined the regression-test approach and caught the missing documentation parenthesis in #167, which Michael confirmed fixing in #168.
Fix REINDEX CONCURRENTLY of partitions
12 Apr 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 99% suremodified before commitlight changesfrom patchset #159

Matches #159, including changeDependenciesOf(), relispartition preservation, inheritance-link transfer, and partition-tree tests. Peter reordered the inheritance-transfer block and polished comments; the commit credits both Michael Paquier and Peter Eisentraut.

REINDEX CONCURRENTLY
29 Mar 2019Peter Eisentrautmaster12beta1REL_19_STABLE12beta1REL_18_STABLE12beta1REL_17_STABLE12beta1REL_16_STABLE12beta1REL_15_STABLE12beta1REL_14_STABLE12beta1REL_13_STABLE12beta1+1 more
LLM analysis, 100% surelanded as postedfrom patchset #1380 of 4 reviewers saw the final version

The 26-file commit matches #138 modulo rebase and whitespace. Its sole normalized changed-line difference is the omitted pgstat.h addition in src/backend/catalog/index.c, verified already present in the commit's parent.

  • Andres Freundsaw an earlier versiontrailerAndres identified concurrency races in #5, examined locking and OID tradeoffs in #25 and #64, and defended the syntax in #125, before subsequent implementation revisions.
  • Fujii Masaono review foundtrailerAlthough credited in the commit, Fujii has no identifiable review activity in the supplied thread.
  • Jim Nasbysaw an earlier versiontrailerJim reviewed cache invalidation in #7, tested and improved the implementation in #13 and #16, and examined changed-OID consequences in #54, before substantial later changes.
  • Sergei Kornilovsaw an earlier versiontrailerSergei tested and reviewed these versions through #137, but #138 subsequently reworked deletion and lock handling beyond light changes.

Credits across 4 commits

Author
Michael Paquier3
Peter Eisentraut2
Andreas Karlsson1
Julien Rouhaud1
Reviewer
Andres Freund1
Dagfinn Ilmari Mannsåker1
Fujii Masao1
Jim Nasby1
Michael Paquier1
Peter Eisentraut1
Sergei Kornilov1
Reported by
Alvaro Herrera1
Dagfinn Ilmari Mannsåker1
Justin Pryzby1
Sergei Kornilov1
Committer
Michael Paquier2
Peter Eisentraut2