Regression test errors

Started by Martín Marquésabout 12 years ago3 messageshackers
Jump to latest
#1Martín Marqués
martin@2ndquadrant.com

I was testing some builds I was doing and found that the regression
tests fails when doing the against a Hot Standby server:

$ make standbycheck
[...]
============== running regression test queries ==============
test hs_standby_check ... ok
test hs_standby_allowed ... FAILED
test hs_standby_disallowed ... FAILED
test hs_standby_functions ... ok

======================
2 of 4 tests failed.
======================

The differences that caused some tests to fail can be viewed in the
file "/usr/local/postgresql-9.3.3/src/test/regress/regression.diffs".
A copy of the test summary that you see
above is saved in the file
"/usr/local/postgresql-9.3.3/src/test/regress/regression.out".

The regression.diffs and patch attached.

I haven't checked how far back those go. I don't think it's even
important to back patch this, but it's nice for future testing.

Regards,

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

regression.diffsapplication/octet-stream; name=regression.diffsDownload+5-2
0001-Standby-regression-checks-failed.patchtext/x-patch; charset=US-ASCII; name=0001-Standby-regression-checks-failed.patchDownload+3-6
#2Martín Marqués
martin@2ndquadrant.com
In reply to: Martín Marqués (#1)
Re: Regression test errors

OK, noticed how horrible this patch was (thanks for the heads up from
Jaime Casanova). This happens when trying to fetch changes one made on
a test copy after a day of lots of work back to a git repository: you
just make very silly mistakes.

Well, now I got the changes right (tested the patch, because silly
changes should be tested as well ;)).

2014-03-07 21:46 GMT-03:00 Martín Marqués <martin@2ndquadrant.com>:

I was testing some builds I was doing and found that the regression
tests fails when doing the against a Hot Standby server:

$ make standbycheck
[...]
============== running regression test queries ==============
test hs_standby_check ... ok
test hs_standby_allowed ... FAILED
test hs_standby_disallowed ... FAILED
test hs_standby_functions ... ok

======================
2 of 4 tests failed.
======================

The differences that caused some tests to fail can be viewed in the
file "/usr/local/postgresql-9.3.3/src/test/regress/regression.diffs".
A copy of the test summary that you see
above is saved in the file
"/usr/local/postgresql-9.3.3/src/test/regress/regression.out".

The regression.diffs and patch attached.

I haven't checked how far back those go. I don't think it's even
important to back patch this, but it's nice for future testing.

Regards,

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachments:

0001-Two-Hot-Standby-regression-tests-failed-for-various-.patchtext/x-diff; charset=US-ASCII; name=0001-Two-Hot-Standby-regression-tests-failed-for-various-.patchDownload+3-6
#3Bruce Momjian
bruce@momjian.us
In reply to: Martín Marqués (#2)
Re: Regression test errors

On Sun, Mar 9, 2014 at 09:23:33AM -0300, Mart�n Marqu�s wrote:

OK, noticed how horrible this patch was (thanks for the heads up from
Jaime Casanova). This happens when trying to fetch changes one made on
a test copy after a day of lots of work back to a git repository: you
just make very silly mistakes.

Well, now I got the changes right (tested the patch, because silly
changes should be tested as well ;)).

Patch applied to head. Thanks.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers