Patch for CREATE RULE sgml

Started by Emanuel Calvoalmost 12 years ago7 messages

Emanuel Calvo

emanuel.calvo@2ndquadrant.com

almost 12 years ago

2 attachment(s)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi guys,

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

But the question here is that I'm not sure which format follow:

- --
{ INSERT | UPDATE | DELETE | SELECT}

INSERT
UPDATE
DELETE
SELECT
- --

I attach a patch for each one.

Regards,

- --
- --
Emanuel Calvo
Consultant // 2ndQuadrant
Bs. As., Argentina // (GMT-3)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJTK05yAAoJEIBeI/HMagHmXEkQAJdXdqtPkRi8ZueupUYQxq9+
wJGOeBRGQRYLxZF2n6lqPy789JhjC8n9WyF5/In1zp9LAbbhLXQGaiR+Rueb5Xyv
c7m/4+qmrDnds8qTHtNZl7gdDqNm8Qbl8K5/puYKrifBBC6R11HrPiAGckbZuoB9
aO5GJn/qtBNVPDH+1MWhGXu4IRJpFNiH/BW5BD7R3vSMUaO4dbFxE9bmc9seeZL+
67SSMTANgROsjKkYP/roRRrYyW10AF3/20VLoFdfgYtXRDgo2eBJyR+TokjEhvce
h7EOROPpoNFkVHUpaN5UOMYmvlJH+D1IX6pex6nUsQ1YDI0mFJWV+UEKzozC3FO6
BFDRipsrTmzNxo+/BfLsRXhmmiHjaLlsLRZS3aiA41q3BxcbmL7lta4xIdxd+x9T
RCHzb96dJqrB2bp9PgaSgH/lxOqTwCQ4rylK3gUOeWpMU8TzLwyuy4bUD2bQYgFj
SkLl1aWYTs3WQFPQJ5tO2J3LO6hfvMbxBCAAloeqaghlo2uhnWHQpD+YIMR9/vGx
3bDiVMh2MWWWF4CNe9RQxW5jYwK8JtR79D5u6lNXK4zJ+NYJqYa3kUOprfZnVuM7
pH2EQEnMWQ6PdlSkNv/1lgRBXzb2rynaht9qzsWylhpiieM2+O6w7MsqsPNdPMP7
sii2/ymQmu5yatHo/Mwc
=rkEY
-----END PGP SIGNATURE-----

Attachments:

add_events_on_create_rule.patchtext/x-diff; name=add_events_on_create_rule.patchDownload

diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..22b46e2 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,9 @@ PostgreSQL documentation
 CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
     TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
     DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+    { INSERT | UPDATE | DELETE | SELECT}
 </synopsis>
  </refsynopsisdiv>

add_events_on_create_rule_2.patchtext/x-diff; name=add_events_on_create_rule_2.patchDownload

diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..a4df024 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,12 @@ PostgreSQL documentation
 CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
     TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
     DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+    INSERT
+    UPDATE
+    DELETE
+    SELECT
 </synopsis>
  </refsynopsisdiv>

Emanuel Calvo

emanuel.calvo@2ndquadrant.com

almost 12 years ago

In reply to: Emanuel Calvo (#1)

2 attachment(s)

Patch for CREATE RULE sgml -- Was in: [DOCS]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi guys,

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

But the question here is that I'm not sure which format follow:

{ INSERT | UPDATE | DELETE | SELECT}

INSERT
UPDATE
DELETE
SELECT
- --

I attach a patch for each one.

I sent a mail to pgsql-docs but no response has been received.

Thanks and regards,

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJTLGERAAoJEIBeI/HMagHmUYcP/ibZQaTYDgLmclqgv6wbeTnT
m9d9mhYEJVhdyowGcJ5s+OSCN5tj2vGJifjxUAQ+6hW+0mzj9kqQLoWJyb9DYn1o
AbbUM6+p2Q1+P5KAUYMVZDRiGN6EqFPw2BgsXhIA2rXHT/PiSPpKvFK6wQ0rmSyX
houtfrXEl4zzLHyrmHZmWHyz6DgPyTM/jtHTd/yhAl1OxKR5V583bHEfDUz3zYEX
v6NjBiq5TY6uaXVF0B0cya8nRfW3KP240cwZTF5zRoyHZ1LNlHLPEPs2huNZPLbk
tp3UIHhdiZKl7ddJcWTTeuv4ABQXQVBLQwHWR91szMr+dz/Wsk0zmeFNzlCKCzzN
cehz5n6yewIiosS1MlD7lxOAHPN0yiXtsjiOWoQYbLaxkcTO74oUZK1iWXD025TB
vSegM0L1a1GJFNjyZhQnUgMLWELhsC5y1g7Pn7D9YkzeyicEFtFRTkGDR9eh9LmV
PNtV4w5M/hZtbappfoW7IL6tLtZnjHUA+UjPflnoae0uQ8G+MOW+3rkXt30BksdR
VXvbhXTXaKLj2cEs8cfyBuVUs8AwBGssjfX2OxkSYjvGYcHVoSN/o0cqOWUD/mMi
98ORZcLrzWk70kQ0zxW9wIXbkp4M+8uogyzL9ViveiLREHYD9SRlWMGPpgbcs/aM
fB7fgznJGvXZoRefJKdQ
=UWLa
-----END PGP SIGNATURE-----

Attachments:

add_events_on_create_rule.patchtext/x-diff; name=add_events_on_create_rule.patchDownload

diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..22b46e2 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,9 @@ PostgreSQL documentation
 CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
     TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
     DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+    { INSERT | UPDATE | DELETE | SELECT}
 </synopsis>
  </refsynopsisdiv>

add_events_on_create_rule_2.patchtext/x-diff; name=add_events_on_create_rule_2.patchDownload

diff --git a/doc/src/sgml/ref/create_rule.sgml b/doc/src/sgml/ref/create_rule.sgml
index d3212b5..a4df024 100644
--- a/doc/src/sgml/ref/create_rule.sgml
+++ b/doc/src/sgml/ref/create_rule.sgml
@@ -24,6 +24,12 @@ PostgreSQL documentation
 CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
     TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
     DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+
+<phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+    INSERT
+    UPDATE
+    DELETE
+    SELECT
 </synopsis>
  </refsynopsisdiv>

Michael Paquier

michael.paquier@gmail.com

almost 12 years ago

In reply to: Emanuel Calvo (#2)

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<emanuel.calvo@2ndquadrant.com> wrote:

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

But the question here is that I'm not sure which format follow:

{ INSERT | UPDATE | DELETE | SELECT}

or

INSERT
UPDATE
DELETE
SELECT
- --

I attach a patch for each one.

I sent a mail to pgsql-docs but no response has been received.

The list of events possible is already listed in the section
"Parameters" => "event":
Page: http://www.postgresql.org/docs/devel/static/sql-createrule.html
Quote: "The event is one of SELECT, INSERT, UPDATE, or DELETE."
Regards,
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Jaime Casanova

jaime@2ndquadrant.com

almost 12 years ago

In reply to: Michael Paquier (#3)

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

On Fri, Mar 21, 2014 at 8:15 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<emanuel.calvo@2ndquadrant.com> wrote:

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

The list of events possible is already listed in the section
"Parameters" => "event":

AFAIU, the synopsis is used to build the help command (\h) in psql.
Currently in that help the events doesn't appear.
btw, CREATE TRIGGER already looks this way:
http://www.postgresql.org/docs/current/static/sql-createtrigger.html

--
Jaime Casanova www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566 Cell: +593 987171157

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Michael Paquier

michael.paquier@gmail.com

almost 12 years ago

In reply to: Jaime Casanova (#4)

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

On Sat, Mar 22, 2014 at 11:18 AM, Jaime Casanova <jaime@2ndquadrant.com> wrote:

On Fri, Mar 21, 2014 at 8:15 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:

On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<emanuel.calvo@2ndquadrant.com> wrote:

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

The list of events possible is already listed in the section
"Parameters" => "event":

AFAIU, the synopsis is used to build the help command (\h) in psql.
Currently in that help the events doesn't appear.
btw, CREATE TRIGGER already looks this way:
http://www.postgresql.org/docs/current/static/sql-createtrigger.html

You are right, I forgot this one... In this case patch 2 could be backpatched...
--
Michael

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Fujii Masao

masao.fujii@gmail.com

almost 12 years ago

In reply to: Emanuel Calvo (#2)

1 attachment(s)

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<emanuel.calvo@2ndquadrant.com> wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi guys,

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

But the question here is that I'm not sure which format follow:

{ INSERT | UPDATE | DELETE | SELECT}

or

INSERT
UPDATE
DELETE
SELECT
- --

I attach a patch for each one.

Though I'm not sure the right policy of the format in synopsis, ISTM that
the following format is suitable in this case, i.e., if the value list
is very simple.
Patch attached.

SELECT | INSERT | UPDATE | DELETE

Regards,

--
Fujii Masao

Attachments:

add_events_on_create_rule_fujii.patchtext/x-patch; charset=US-ASCII; name=add_events_on_create_rule_fujii.patchDownload

*** a/doc/src/sgml/ref/create_rule.sgml
--- b/doc/src/sgml/ref/create_rule.sgml
***************
*** 24,29 **** PostgreSQL documentation
--- 24,33 ----
  CREATE [ OR REPLACE ] RULE <replaceable class="parameter">name</replaceable> AS ON <replaceable class="parameter">event</replaceable>
      TO <replaceable class="parameter">table_name</replaceable> [ WHERE <replaceable class="parameter">condition</replaceable> ]
      DO [ ALSO | INSTEAD ] { NOTHING | <replaceable class="parameter">command</replaceable> | ( <replaceable class="parameter">command</replaceable> ; <replaceable class="parameter">command</replaceable> ... ) }
+ 
+ <phrase>where <replaceable class="parameter">event</replaceable> can be one of:</phrase>
+ 
+     SELECT | INSERT | UPDATE | DELETE
  </synopsis>
   </refsynopsisdiv>

Bruce Momjian

bruce@momjian.us

over 11 years ago

In reply to: Fujii Masao (#6)

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

On Mon, Mar 24, 2014 at 09:51:07PM +0900, Fujii Masao wrote:

On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<emanuel.calvo@2ndquadrant.com> wrote:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Hi guys,

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

But the question here is that I'm not sure which format follow:

{ INSERT | UPDATE | DELETE | SELECT}

or

INSERT
UPDATE
DELETE
SELECT
- --

I attach a patch for each one.

Though I'm not sure the right policy of the format in synopsis, ISTM that
the following format is suitable in this case, i.e., if the value list
is very simple.
Patch attached.

SELECT | INSERT | UPDATE | DELETE

Patch applied.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers