pgsql: psql: conditionally display oids and replication identity

Started by Bruce Momjianover 11 years ago7 messages
#1Bruce Momjian
bruce@momjian.us

psql: conditionally display oids and replication identity

In psql \d+, display oids only when they exist, and display replication
identity only when it is non-default. Also document the defaults for
replication identity for system and non-system tables. Update
regression output.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/4168c00a5d9c0c0c17cdfc902587b6d22ea1720f

Modified Files
--------------
doc/src/sgml/ref/alter_table.sgml | 4 +++-
doc/src/sgml/ref/psql-ref.sgml | 4 +++-
src/bin/psql/describe.c | 17 ++++++-----------
src/test/regress/expected/create_table_like.out | 6 ------
src/test/regress/expected/foreign_data.out | 2 --
src/test/regress/expected/inherit.out | 13 -------------
src/test/regress/expected/replica_identity.out | 16 ++++++++--------
src/test/regress/expected/rules.out | 1 -
src/test/regress/sql/replica_identity.sql | 2 +-
9 files changed, 21 insertions(+), 44 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Bruce Momjian (#1)
Re: pgsql: psql: conditionally display oids and replication identity

Bruce Momjian <bruce@momjian.us> writes:

psql: conditionally display oids and replication identity

Buildfarm isn't terribly pleased with this --- looks like you missed
contrib/test_decoding/

regards, tom lane

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Bruce Momjian
bruce@momjian.us
In reply to: Tom Lane (#2)
Re: pgsql: psql: conditionally display oids and replication identity

On Tue, Apr 15, 2014 at 02:32:53PM -0400, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

psql: conditionally display oids and replication identity

Buildfarm isn't terribly pleased with this --- looks like you missed
contrib/test_decoding/

Fixed. I added a personal script option that allows me to test contrib,
but forgot to run it.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#4David Fetter
david@fetter.org
In reply to: Bruce Momjian (#3)
test script, was Re: [COMMITTERS] pgsql: psql: conditionally display oids and replication identity

On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote:

On Tue, Apr 15, 2014 at 02:32:53PM -0400, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

psql: conditionally display oids and replication identity

Buildfarm isn't terribly pleased with this --- looks like you missed
contrib/test_decoding/

Fixed. I added a personal script option that allows me to test contrib,
but forgot to run it.

Is that script of general utility for committers? If so, it might be
good to include it in the distribution. I'd be happy to go through
and perl-ify it, document it, etc. Or maybe it could be a new make
target...

Cheers,
David.
--
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david.fetter@gmail.com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#5Andres Freund
andres@2ndquadrant.com
In reply to: David Fetter (#4)
Re: test script, was Re: [COMMITTERS] pgsql: psql: conditionally display oids and replication identity

On 2014-04-15 12:32:36 -0700, David Fetter wrote:

On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote:

On Tue, Apr 15, 2014 at 02:32:53PM -0400, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

psql: conditionally display oids and replication identity

Buildfarm isn't terribly pleased with this --- looks like you missed
contrib/test_decoding/

Fixed. I added a personal script option that allows me to test contrib,
but forgot to run it.

Is that script of general utility for committers? If so, it might be
good to include it in the distribution. I'd be happy to go through
and perl-ify it, document it, etc. Or maybe it could be a new make
target...

"make check-world"

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#6Tom Lane
tgl@sss.pgh.pa.us
In reply to: David Fetter (#4)
Re: test script, was Re: [COMMITTERS] pgsql: psql: conditionally display oids and replication identity

David Fetter <david@fetter.org> writes:

On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote:

Fixed. I added a personal script option that allows me to test contrib,
but forgot to run it.

Is that script of general utility for committers? If so, it might be
good to include it in the distribution. I'd be happy to go through
and perl-ify it, document it, etc. Or maybe it could be a new make
target...

I'm pretty sure "make check-world" would've covered this already.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#7Bruce Momjian
bruce@momjian.us
In reply to: David Fetter (#4)
1 attachment(s)
Re: test script, was Re: [COMMITTERS] pgsql: psql: conditionally display oids and replication identity

On Tue, Apr 15, 2014 at 12:32:36PM -0700, David Fetter wrote:

On Tue, Apr 15, 2014 at 02:46:34PM -0400, Bruce Momjian wrote:

On Tue, Apr 15, 2014 at 02:32:53PM -0400, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

psql: conditionally display oids and replication identity

Buildfarm isn't terribly pleased with this --- looks like you missed
contrib/test_decoding/

Fixed. I added a personal script option that allows me to test contrib,
but forgot to run it.

Is that script of general utility for committers? If so, it might be
good to include it in the distribution. I'd be happy to go through
and perl-ify it, document it, etc. Or maybe it could be a new make
target...

My script is wrapper around src/tools/pgtest. I am attaching it in case
there are snippets in there that are useful to people.

--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachments:

pgtesttext/plain; charset=us-asciiDownload