min_recovery_apply_delay

Started by Peter Eisentrautalmost 12 years ago5 messageshackers
Jump to latest
#1Peter Eisentraut
peter_e@gmx.net

Wouldn't a better name be recovery_min_apply_delay?

Other parameters are usually named something_min_something.

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#2Fabrízio de Royes Mello
fabriziomello@gmail.com
In reply to: Peter Eisentraut (#1)
Re: min_recovery_apply_delay

Em sexta-feira, 9 de maio de 2014, Peter Eisentraut <peter_e@gmx.net>
escreveu:

Wouldn't a better name be recovery_min_apply_delay?

+1

The original name was recovery_apply_delay but in some point of review it
was changed to reflect better the limit.

Other parameters are usually named something_min_something.

Ok

If you want I can send a patch to change it.

Fabrízio Mello.

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL

Show quoted text

Timbira: http://www.timbira.com.br
Blog sobre TI: http://fabriziomello.blogspot.com
Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello

#3Robert Haas
robertmhaas@gmail.com
In reply to: Fabrízio de Royes Mello (#2)
Re: min_recovery_apply_delay

On Fri, May 9, 2014 at 10:44 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:

Wouldn't a better name be recovery_min_apply_delay?

+1

Works for me.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Fabrízio de Royes Mello
fabriziomello@gmail.com
In reply to: Robert Haas (#3)
Re: min_recovery_apply_delay

On Sat, May 10, 2014 at 5:22 PM, Robert Haas <robertmhaas@gmail.com> wrote:

On Fri, May 9, 2014 at 10:44 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:

Wouldn't a better name be recovery_min_apply_delay?

+1

Works for me.

Done!!

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL

Show quoted text

Timbira: http://www.timbira.com.br
Blog sobre TI: http://fabriziomello.blogspot.com
Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
Twitter: http://twitter.com/fabriziomello

Attachments:

rename_min_recovery_apply_delay_to_recovery_min_apply_delay.patchtext/x-diff; charset=US-ASCII; name=rename_min_recovery_apply_delay_to_recovery_min_apply_delay.patchDownload+13-13
#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Fabrízio de Royes Mello (#4)
Re: min_recovery_apply_delay

=?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com> writes:

On Sat, May 10, 2014 at 5:22 PM, Robert Haas <robertmhaas@gmail.com> wrote:

On Fri, May 9, 2014 at 10:44 PM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:

Wouldn't a better name be recovery_min_apply_delay?

+1

Works for me.

Done!!

Since there were no objections, and time is growing (very) short,
I'm going to go ahead and push this in. It looks safe enough for
a last-minute change.

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers