Supporting tcl 8.6

Started by Christoph Bergover 11 years ago3 messages
#1Christoph Berg
cb@df7cb.de
1 attachment(s)

Hi,

the current tcl version is 8.6, and configure should recognize it. The
attached patch has been in the Debian/Ubuntu packages for a while, so
it's tested.

Christoph
--
cb@df7cb.de | http://www.df7cb.de/

Attachments:

tcl86text/plain; charset=us-asciiDownload
diff --git a/config/tcl.m4 b/config/tcl.m4
new file mode 100644
index e886057..a9fe7ba
*** a/config/tcl.m4
--- b/config/tcl.m4
***************
*** 4,10 ****
  
  
  AC_DEFUN([PGAC_PATH_TCLSH],
! [AC_PATH_PROGS(TCLSH, [tclsh tcl tclsh8.5 tclsh85 tclsh8.4 tclsh84 tclsh8.3 tclsh83])
  if test x"$TCLSH" = x""; then
    AC_MSG_ERROR([Tcl shell not found])
  fi
--- 4,10 ----
  
  
  AC_DEFUN([PGAC_PATH_TCLSH],
! [AC_PATH_PROGS(TCLSH, [tclsh tcl tclsh8.6 tclsh86 tclsh8.5 tclsh85 tclsh8.4 tclsh84 tclsh8.3 tclsh83])
  if test x"$TCLSH" = x""; then
    AC_MSG_ERROR([Tcl shell not found])
  fi
diff --git a/configure b/configure
new file mode 100755
index 9953389..5154ace
*** a/configure
--- b/configure
*************** fi
*** 13891,13897 ****
  
  # Check for Tcl configuration script tclConfig.sh
  if test "$with_tcl" = yes; then
!     for ac_prog in tclsh tcl tclsh8.5 tclsh85 tclsh8.4 tclsh84 tclsh8.3 tclsh83
  do
    # Extract the first word of "$ac_prog", so it can be a program name with args.
  set dummy $ac_prog; ac_word=$2
--- 13891,13897 ----
  
  # Check for Tcl configuration script tclConfig.sh
  if test "$with_tcl" = yes; then
!     for ac_prog in tclsh tcl tclsh8.6 tclsh86 tclsh8.5 tclsh85 tclsh8.4 tclsh84 tclsh8.3 tclsh83
  do
    # Extract the first word of "$ac_prog", so it can be a program name with args.
  set dummy $ac_prog; ac_word=$2
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Christoph Berg (#1)
Re: Supporting tcl 8.6

Christoph Berg <cb@df7cb.de> writes:

the current tcl version is 8.6, and configure should recognize it. The
attached patch has been in the Debian/Ubuntu packages for a while, so
it's tested.

While that patch looks harmless enough, I'm curious why you'd need it
--- isn't tcl installed as plain "tclsh"?

regards, tom lane

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Christoph Berg
cb@df7cb.de
In reply to: Tom Lane (#2)
Re: Supporting tcl 8.6

Re: Tom Lane 2014-05-10 <27409.1399729811@sss.pgh.pa.us>

Christoph Berg <cb@df7cb.de> writes:

the current tcl version is 8.6, and configure should recognize it. The
attached patch has been in the Debian/Ubuntu packages for a while, so
it's tested.

While that patch looks harmless enough, I'm curious why you'd need it
--- isn't tcl installed as plain "tclsh"?

That's what I thought, but at least at the beginning of the year,
Ubuntu's then-development 14.04 suite didn't have tclsh, but only
tclsh8.6. It was surprising, but easy enough to fix, hence the patch.

Thanks for applying! (And sorry for the last-minute submission, but
better now than later...)

Christoph
--
cb@df7cb.de | http://www.df7cb.de/

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers